* nested_free_all_saved_vmcss freeing vmx->vmcs01?
@ 2014-01-03 19:02 Marcelo Tosatti
2014-01-03 19:53 ` Jan Kiszka
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2014-01-03 19:02 UTC (permalink / raw)
To: Jan Kiszka, Paolo Bonzini, kvm-devel
Am i missing something, or should nested_free_all_saved_vmcss not
call
if (vmx->loaded_vmcs != &vmx->vmcs01)
free_loaded_vmcs(&vmx->vmcs01);
?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: nested_free_all_saved_vmcss freeing vmx->vmcs01? 2014-01-03 19:02 nested_free_all_saved_vmcss freeing vmx->vmcs01? Marcelo Tosatti @ 2014-01-03 19:53 ` Jan Kiszka 0 siblings, 0 replies; 2+ messages in thread From: Jan Kiszka @ 2014-01-03 19:53 UTC (permalink / raw) To: Marcelo Tosatti, Paolo Bonzini, kvm-devel [-- Attachment #1: Type: text/plain, Size: 517 bytes --] On 2014-01-03 20:02, Marcelo Tosatti wrote: > > Am i missing something, or should nested_free_all_saved_vmcss not > call > > if (vmx->loaded_vmcs != &vmx->vmcs01) > free_loaded_vmcs(&vmx->vmcs01); > > ? This is relevant if we call nested_free_all_saved_vmcss on cleanup while L2 was still active. In this case, the free_loaded_vmcs(vmx->loaded_vmcs) will free the item's loaded_vmcs we skipped earlier in that function - OK, and now I also understand your patch. Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 263 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-03 19:53 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-03 19:02 nested_free_all_saved_vmcss freeing vmx->vmcs01? Marcelo Tosatti 2014-01-03 19:53 ` Jan Kiszka
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.