[Qemu-devel] [PATCH] Makefile: properly install bios-256k.bin

[Qemu-devel] [PATCH] Makefile: properly install bios-256k.bin

[Peter Lieven]

Commit bcf2b7d introduced new 256k seabios files. However,
they were not installed.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bdff4e4..807054b 100644
--- a/Makefile
+++ b/Makefile
@@ -290,7 +290,7 @@ common  de-ch  es     fo  fr-ca  hu     ja  mk  nl-be      pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \
 acpi-dsdt.aml q35-acpi-dsdt.aml \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin \
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH] Makefile: properly install bios-256k.bin

[Peter Maydell]

On 6 January 2014 12:54, Peter Lieven <pl@kamp.de> wrote:
> Commit bcf2b7d introduced new 256k seabios files. However,
> they were not installed.

This is a dup of this patch by Eduardo from last month:
http://patchwork.ozlabs.org/patch/299233/

thanks
-- PMM

Re: [Qemu-devel] [PATCH] Makefile: properly install bios-256k.bin

[Peter Maydell]

On 6 January 2014 13:17, Peter Lieven <pl@kamp.de> wrote:
> On 06.01.2014 14:12, Peter Maydell wrote:
>
> On 6 January 2014 12:54, Peter Lieven <pl@kamp.de> wrote:
>
> Commit bcf2b7d introduced new 256k seabios files. However,
> they were not installed.
>
> This is a dup of this patch by Eduardo from last month:
> http://patchwork.ozlabs.org/patch/299233/
>
> Thanks for the pointer. However, this patch is not in master atm.

Yes, that's why I quoted a patchwork URL rather than
a commit hash :-)

In general, the first of several identical patches for a
fix is the one that should be committed, and there's not
much point in sending in duplicates (especially when the
first patch already has review tags.)

thanks
-- PMM

Re: [Qemu-devel] [PATCH] Makefile: properly install bios-256k.bin

[Peter Lieven]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On 06.01.2014 14:12, Peter Maydell wrote:
> On 6 January 2014 12:54, Peter Lieven <pl@kamp.de> wrote:
>> Commit bcf2b7d introduced new 256k seabios files. However,
>> they were not installed.
> This is a dup of this patch by Eduardo from last month:
> http://patchwork.ozlabs.org/patch/299233/
Thanks for the pointer. However, this patch is not in master atm.

https://github.com/qemu/qemu/blob/master/Makefile

Peter


[-- Attachment #2: Type: text/html, Size: 1219 bytes --]

Re: [Qemu-devel] [PATCH] Makefile: properly install bios-256k.bin

[Peter Lieven]

On 06.01.2014 14:17, Peter Maydell wrote:
> On 6 January 2014 13:17, Peter Lieven <pl@kamp.de> wrote:
>> On 06.01.2014 14:12, Peter Maydell wrote:
>>
>> On 6 January 2014 12:54, Peter Lieven <pl@kamp.de> wrote:
>>
>> Commit bcf2b7d introduced new 256k seabios files. However,
>> they were not installed.
>>
>> This is a dup of this patch by Eduardo from last month:
>> http://patchwork.ozlabs.org/patch/299233/
>>
>> Thanks for the pointer. However, this patch is not in master atm.
> Yes, that's why I quoted a patchwork URL rather than
> a commit hash :-)
>
> In general, the first of several identical patches for a
> fix is the one that should be committed, and there's not
> much point in sending in duplicates (especially when the
> first patch already has review tags.)
thats clear.
I did not want to have credit for this I have just not realized
that there is already a patch.

Peter