* fimc-lite.c: compile warning indicates bug
@ 2014-01-07 13:32 Hans Verkuil
2014-01-07 14:42 ` Sylwester Nawrocki
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2014-01-07 13:32 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: Linux Media Mailing List
Hi Sylwester,
I just did a quick build with the latest set of commits and I found this
warning:
.../media-git/drivers/media/platform/exynos4-is/fimc-lite.c: In function 'fimc_lite_probe':
.../media-git/drivers/media/platform/exynos4-is/fimc-lite.c:1583:1: warning: label 'err_sd' defined but not used [-Wunused-label]
err_sd:
^
As far as I can tell err_sd should certainly be used to do proper cleanup.
Can you check the code and prepare a patch?
Thanks!
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fimc-lite.c: compile warning indicates bug
2014-01-07 13:32 fimc-lite.c: compile warning indicates bug Hans Verkuil
@ 2014-01-07 14:42 ` Sylwester Nawrocki
2014-02-10 9:00 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Sylwester Nawrocki @ 2014-01-07 14:42 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Hi Hans,
On 07/01/14 14:32, Hans Verkuil wrote:
> Hi Sylwester,
>
> I just did a quick build with the latest set of commits and I found this
> warning:
>
> .../media-git/drivers/media/platform/exynos4-is/fimc-lite.c: In function 'fimc_lite_probe':
> .../media-git/drivers/media/platform/exynos4-is/fimc-lite.c:1583:1: warning: label 'err_sd' defined but not used [-Wunused-label]
> err_sd:
> ^
>
> As far as I can tell err_sd should certainly be used to do proper cleanup.
> Can you check the code and prepare a patch?
Yes, I also noticed it in the media daily builds. It's a rebase error,
unfortunately the mainline driver is now far behind our internal code.
I will prepare a patch to fix this as soon as possible.
Regards,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fimc-lite.c: compile warning indicates bug
2014-01-07 14:42 ` Sylwester Nawrocki
@ 2014-02-10 9:00 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2014-02-10 9:00 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: Linux Media Mailing List
On 01/07/2014 03:42 PM, Sylwester Nawrocki wrote:
> Hi Hans,
>
> On 07/01/14 14:32, Hans Verkuil wrote:
>> Hi Sylwester,
>>
>> I just did a quick build with the latest set of commits and I found this
>> warning:
>>
>> .../media-git/drivers/media/platform/exynos4-is/fimc-lite.c: In function 'fimc_lite_probe':
>> .../media-git/drivers/media/platform/exynos4-is/fimc-lite.c:1583:1: warning: label 'err_sd' defined but not used [-Wunused-label]
>> err_sd:
>> ^
>>
>> As far as I can tell err_sd should certainly be used to do proper cleanup.
>> Can you check the code and prepare a patch?
>
> Yes, I also noticed it in the media daily builds. It's a rebase error,
> unfortunately the mainline driver is now far behind our internal code.
> I will prepare a patch to fix this as soon as possible.
This is now the only warning left. Did you post a patch and did I miss it?
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-10 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 13:32 fimc-lite.c: compile warning indicates bug Hans Verkuil
2014-01-07 14:42 ` Sylwester Nawrocki
2014-02-10 9:00 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.