[PATCH] Btrfs-progs: bail if we find errors in the extent tree

[PATCH] Btrfs-progs: bail if we find errors in the extent tree

[Josef Bacik]

For some reason we weren't exiting if there were errors in the extent tree,
which means we could have errors in just the extent tree and things like
xfstests would keep going because we completely throw away the return value.
Thanks,

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 cmds-check.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cmds-check.c b/cmds-check.c
index 689fe6c..cbabfdc 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -6409,8 +6409,10 @@ int cmd_check(int argc, char **argv)
 		goto out;
 	}
 	ret = check_chunks_and_extents(root);
-	if (ret)
+	if (ret) {
 		fprintf(stderr, "Errors found in extent allocation tree or chunk allocation\n");
+		goto out;
+	}
 
 	fprintf(stderr, "checking free space cache\n");
 	ret = check_space_cache(root);
-- 
1.8.3.1

Re: [PATCH] Btrfs-progs: bail if we find errors in the extent tree

[Josef Bacik]

On 01/07/2014 03:34 PM, Josef Bacik wrote:
> For some reason we weren't exiting if there were errors in the extent tree,
> which means we could have errors in just the extent tree and things like
> xfstests would keep going because we completely throw away the return value.
> Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
>   cmds-check.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cmds-check.c b/cmds-check.c
> index 689fe6c..cbabfdc 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -6409,8 +6409,10 @@ int cmd_check(int argc, char **argv)
>   		goto out;
>   	}
>   	ret = check_chunks_and_extents(root);
> -	if (ret)
> +	if (ret) {
>   		fprintf(stderr, "Errors found in extent allocation tree or chunk allocation\n");
> +		goto out;
> +	}
>   
>   	fprintf(stderr, "checking free space cache\n");
>   	ret = check_space_cache(root);
Sigh ignore this, it is causing other problems, I'm going to have to 
figure out a better solution to this.  Thanks,

Josef