* [PATCH] Btrfs-progs: bail if we find errors in the extent tree
@ 2014-01-07 20:34 Josef Bacik
2014-01-07 21:07 ` Josef Bacik
0 siblings, 1 reply; 2+ messages in thread
From: Josef Bacik @ 2014-01-07 20:34 UTC (permalink / raw)
To: linux-btrfs
For some reason we weren't exiting if there were errors in the extent tree,
which means we could have errors in just the extent tree and things like
xfstests would keep going because we completely throw away the return value.
Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
---
cmds-check.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmds-check.c b/cmds-check.c
index 689fe6c..cbabfdc 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -6409,8 +6409,10 @@ int cmd_check(int argc, char **argv)
goto out;
}
ret = check_chunks_and_extents(root);
- if (ret)
+ if (ret) {
fprintf(stderr, "Errors found in extent allocation tree or chunk allocation\n");
+ goto out;
+ }
fprintf(stderr, "checking free space cache\n");
ret = check_space_cache(root);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Btrfs-progs: bail if we find errors in the extent tree
2014-01-07 20:34 [PATCH] Btrfs-progs: bail if we find errors in the extent tree Josef Bacik
@ 2014-01-07 21:07 ` Josef Bacik
0 siblings, 0 replies; 2+ messages in thread
From: Josef Bacik @ 2014-01-07 21:07 UTC (permalink / raw)
To: linux-btrfs
On 01/07/2014 03:34 PM, Josef Bacik wrote:
> For some reason we weren't exiting if there were errors in the extent tree,
> which means we could have errors in just the extent tree and things like
> xfstests would keep going because we completely throw away the return value.
> Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
> cmds-check.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cmds-check.c b/cmds-check.c
> index 689fe6c..cbabfdc 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -6409,8 +6409,10 @@ int cmd_check(int argc, char **argv)
> goto out;
> }
> ret = check_chunks_and_extents(root);
> - if (ret)
> + if (ret) {
> fprintf(stderr, "Errors found in extent allocation tree or chunk allocation\n");
> + goto out;
> + }
>
> fprintf(stderr, "checking free space cache\n");
> ret = check_space_cache(root);
Sigh ignore this, it is causing other problems, I'm going to have to
figure out a better solution to this. Thanks,
Josef
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-07 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 20:34 [PATCH] Btrfs-progs: bail if we find errors in the extent tree Josef Bacik
2014-01-07 21:07 ` Josef Bacik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.