[PATCH] Support for Yamaha MOXF

[PATCH] Support for Yamaha MOXF

[Michael Slade]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

My apologies if I'm doing this wrong.

I have managed to get a Yamaha MOXF8 working with the attached patch.  
Presumably also works with a MOXF6.

The new Yamaha MOXF6/8 are successors to the MOX6/8.  Apart from things 
like new voices, a flash expansion port, and a different colour at the 
ends, they are pretty much identical in operation.

The MOXF has a USB ID of 0499:150f.  So I needed to add a new 
quirks-table.h stanza for it, by copy-pasting the MOX one and changing 
he ID.

I haven't tested it to death or anything,  but I am having no trouble 
recording and playing audio and midi.

Let me know if this patch is acceptable or of there is more that is 
needed from me.

Note, this patch is against Ubuntu Raring's 3.8.0 kernel, but it's a 
trivial patch.

Mick.


[-- Attachment #2: alsa-yamaha-moxf.patch --]
[-- Type: text/x-patch, Size: 758 bytes --]

--- linux-3.8.0.orig/sound/usb/quirks-table.h
+++ linux-3.8.0/sound/usb/quirks-table.h
@@ -353,6 +359,32 @@
 		}
 	}
 },
+{
+	USB_DEVICE(0x0499, 0x150f),
+	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+		/* .vendor_name = "Yamaha", */
+		/* .product_name = "MOXF6/MOXF8", */
+		.ifnum = QUIRK_ANY_INTERFACE,
+		.type = QUIRK_COMPOSITE,
+		.data = (const struct snd_usb_audio_quirk[]) {
+			{
+				.ifnum = 1,
+				.type = QUIRK_AUDIO_STANDARD_INTERFACE
+			},
+			{
+				.ifnum = 2,
+				.type = QUIRK_AUDIO_STANDARD_INTERFACE
+			},
+			{
+				.ifnum = 3,
+				.type = QUIRK_MIDI_YAMAHA
+			},
+			{
+				.ifnum = -1
+			}
+		}
+	}
+},
 YAMAHA_DEVICE(0x2000, "DGP-7"),
 YAMAHA_DEVICE(0x2001, "DGP-5"),
 YAMAHA_DEVICE(0x2002, NULL),

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] Support for Yamaha MOXF

[Takashi Iwai]

At Thu, 09 Jan 2014 16:09:10 +1100,
Michael Slade wrote:
> 
> My apologies if I'm doing this wrong.
> 
> I have managed to get a Yamaha MOXF8 working with the attached patch.  
> Presumably also works with a MOXF6.
> 
> The new Yamaha MOXF6/8 are successors to the MOX6/8.  Apart from things 
> like new voices, a flash expansion port, and a different colour at the 
> ends, they are pretty much identical in operation.
> 
> The MOXF has a USB ID of 0499:150f.  So I needed to add a new 
> quirks-table.h stanza for it, by copy-pasting the MOX one and changing 
> he ID.
> 
> I haven't tested it to death or anything,  but I am having no trouble 
> recording and playing audio and midi.
> 
> Let me know if this patch is acceptable or of there is more that is 
> needed from me.
> 
> Note, this patch is against Ubuntu Raring's 3.8.0 kernel, but it's a 
> trivial patch.

The code change looks OK, but please reformat the patch in the way to
follow Documentation/SubmittigPatches and resubmit to ML.


thanks,

Takashi

> 
> Mick.
> 
> [2 alsa-yamaha-moxf.patch <text/x-patch (7bit)>]
> --- linux-3.8.0.orig/sound/usb/quirks-table.h
> +++ linux-3.8.0/sound/usb/quirks-table.h
> @@ -353,6 +359,32 @@
>  		}
>  	}
>  },
> +{
> +	USB_DEVICE(0x0499, 0x150f),
> +	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
> +		/* .vendor_name = "Yamaha", */
> +		/* .product_name = "MOXF6/MOXF8", */
> +		.ifnum = QUIRK_ANY_INTERFACE,
> +		.type = QUIRK_COMPOSITE,
> +		.data = (const struct snd_usb_audio_quirk[]) {
> +			{
> +				.ifnum = 1,
> +				.type = QUIRK_AUDIO_STANDARD_INTERFACE
> +			},
> +			{
> +				.ifnum = 2,
> +				.type = QUIRK_AUDIO_STANDARD_INTERFACE
> +			},
> +			{
> +				.ifnum = 3,
> +				.type = QUIRK_MIDI_YAMAHA
> +			},
> +			{
> +				.ifnum = -1
> +			}
> +		}
> +	}
> +},
>  YAMAHA_DEVICE(0x2000, "DGP-7"),
>  YAMAHA_DEVICE(0x2001, "DGP-5"),
>  YAMAHA_DEVICE(0x2002, NULL),
> [3  <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Support for Yamaha MOXF

[Clemens Ladisch]

Michael Slade wrote:
> I have managed to get a Yamaha MOXF8 working with the attached patch.

In theory, it should already work with kernel 3.11.


Regards,
Clemens

Re: [PATCH] Support for Yamaha MOXF

[Takashi Iwai]

At Thu, 09 Jan 2014 08:52:40 +0100,
Clemens Ladisch wrote:
> 
> Michael Slade wrote:
> > I have managed to get a Yamaha MOXF8 working with the attached patch.
> 
> In theory, it should already work with kernel 3.11.

Ah, good point.  I forgot your recent rework.

Michael, please check whether 3.11 and later kernel works without your
patch.  If it doesn't, please send the fix patch again.


Takashi