From: David Daney <ddaney@caviumnetworks.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>,
<blogic@openwrt.org>, <david.daney@cavium.com>
Subject: Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
Date: Wed, 15 Jan 2014 11:11:48 -0800 [thread overview]
Message-ID: <52D6DD74.60308@caviumnetworks.com> (raw)
In-Reply-To: <1389812784-30085-1-git-send-email-florian@openwrt.org>
On 01/15/2014 11:06 AM, Florian Fainelli wrote:
> Attempting to build for Cavium Octeon with an unpatched or old
> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
> Call cc-option on this option to make sure we can safely use it.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
NACK.
If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
without this option yields a system the generates random errors. So I
would argue that if -Wa,-mfix-cn63xxp1 is not supported by your
assembler, breaking the build is the proper thing to do.
David Daney
> ---
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 873a0ca..f372b84 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
> ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
> cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
> endif
> -cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
> +cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
> cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
>
> cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
blogic@openwrt.org, david.daney@cavium.com
Subject: Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
Date: Wed, 15 Jan 2014 11:11:48 -0800 [thread overview]
Message-ID: <52D6DD74.60308@caviumnetworks.com> (raw)
Message-ID: <20140115191148.pGavEfT-2Mx6mnXoyclh-Z0__00TZOxTcmUGXgHsf8g@z> (raw)
In-Reply-To: <1389812784-30085-1-git-send-email-florian@openwrt.org>
On 01/15/2014 11:06 AM, Florian Fainelli wrote:
> Attempting to build for Cavium Octeon with an unpatched or old
> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
> Call cc-option on this option to make sure we can safely use it.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
NACK.
If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
without this option yields a system the generates random errors. So I
would argue that if -Wa,-mfix-cn63xxp1 is not supported by your
assembler, breaking the build is the proper thing to do.
David Daney
> ---
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 873a0ca..f372b84 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
> ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
> cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
> endif
> -cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
> +cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
> cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
>
> cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
>
next prev parent reply other threads:[~2014-01-15 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 19:06 [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option Florian Fainelli
2014-01-15 19:06 ` Florian Fainelli
2014-01-15 19:11 ` David Daney [this message]
2014-01-15 19:11 ` David Daney
2014-01-15 20:04 ` Florian Fainelli
2014-01-15 21:24 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6DD74.60308@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=blogic@openwrt.org \
--cc=david.daney@cavium.com \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.