* [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
@ 2014-01-15 19:06 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2014-01-15 19:06 UTC (permalink / raw)
To: linux-mips; +Cc: ralf, blogic, david.daney, Florian Fainelli
Attempting to build for Cavium Octeon with an unpatched or old
toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
Call cc-option on this option to make sure we can safely use it.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
arch/mips/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 873a0ca..f372b84 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
endif
-cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
+cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
@ 2014-01-15 19:06 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2014-01-15 19:06 UTC (permalink / raw)
To: linux-mips; +Cc: ralf, blogic, david.daney, Florian Fainelli
Attempting to build for Cavium Octeon with an unpatched or old
toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
Call cc-option on this option to make sure we can safely use it.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
arch/mips/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 873a0ca..f372b84 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
endif
-cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
+cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
@ 2014-01-15 19:11 ` David Daney
0 siblings, 0 replies; 6+ messages in thread
From: David Daney @ 2014-01-15 19:11 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-mips, ralf, blogic, david.daney
On 01/15/2014 11:06 AM, Florian Fainelli wrote:
> Attempting to build for Cavium Octeon with an unpatched or old
> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
> Call cc-option on this option to make sure we can safely use it.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
NACK.
If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
without this option yields a system the generates random errors. So I
would argue that if -Wa,-mfix-cn63xxp1 is not supported by your
assembler, breaking the build is the proper thing to do.
David Daney
> ---
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 873a0ca..f372b84 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
> ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
> cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
> endif
> -cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
> +cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
> cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
>
> cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
@ 2014-01-15 19:11 ` David Daney
0 siblings, 0 replies; 6+ messages in thread
From: David Daney @ 2014-01-15 19:11 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-mips, ralf, blogic, david.daney
On 01/15/2014 11:06 AM, Florian Fainelli wrote:
> Attempting to build for Cavium Octeon with an unpatched or old
> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
> Call cc-option on this option to make sure we can safely use it.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
NACK.
If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
without this option yields a system the generates random errors. So I
would argue that if -Wa,-mfix-cn63xxp1 is not supported by your
assembler, breaking the build is the proper thing to do.
David Daney
> ---
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 873a0ca..f372b84 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -155,7 +155,7 @@ cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += $(call cc-option,-march=octeon) -Wa,--trap
> ifeq (,$(findstring march=octeon, $(cflags-$(CONFIG_CPU_CAVIUM_OCTEON))))
> cflags-$(CONFIG_CPU_CAVIUM_OCTEON) += -Wa,-march=octeon
> endif
> -cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,-mfix-cn63xxp1
> +cflags-$(CONFIG_CAVIUM_CN63XXP1) += -Wa,$(call cc-option,-mfix-cn63xxp1)
> cflags-$(CONFIG_CPU_BMIPS) += -march=mips32 -Wa,-mips32 -Wa,--trap
>
> cflags-$(CONFIG_CPU_R4000_WORKAROUNDS) += $(call cc-option,-mfix-r4000,)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
2014-01-15 19:11 ` David Daney
(?)
@ 2014-01-15 20:04 ` Florian Fainelli
2014-01-15 21:24 ` Florian Fainelli
-1 siblings, 1 reply; 6+ messages in thread
From: Florian Fainelli @ 2014-01-15 20:04 UTC (permalink / raw)
To: David Daney; +Cc: Linux-MIPS, Ralf Baechle, John Crispin, david.daney
2014/1/15 David Daney <ddaney@caviumnetworks.com>:
> On 01/15/2014 11:06 AM, Florian Fainelli wrote:
>>
>> Attempting to build for Cavium Octeon with an unpatched or old
>> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
>> Call cc-option on this option to make sure we can safely use it.
>>
>> Signed-off-by: Florian Fainelli <florian@openwrt.org>
>
>
> NACK.
>
> If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
> without this option yields a system the generates random errors. So I would
> argue that if -Wa,-mfix-cn63xxp1 is not supported by your assembler,
> breaking the build is the proper thing to do.
Fair enough. Maybe the condition should be refined to be based off
CONFIG_CAVIUM_CN63XXP1?
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
2014-01-15 20:04 ` Florian Fainelli
@ 2014-01-15 21:24 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2014-01-15 21:24 UTC (permalink / raw)
To: David Daney; +Cc: Linux-MIPS, Ralf Baechle, John Crispin, david.daney
2014/1/15 Florian Fainelli <florian@openwrt.org>:
> 2014/1/15 David Daney <ddaney@caviumnetworks.com>:
>> On 01/15/2014 11:06 AM, Florian Fainelli wrote:
>>>
>>> Attempting to build for Cavium Octeon with an unpatched or old
>>> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
>>> Call cc-option on this option to make sure we can safely use it.
>>>
>>> Signed-off-by: Florian Fainelli <florian@openwrt.org>
>>
>>
>> NACK.
>>
>> If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
>> without this option yields a system the generates random errors. So I would
>> argue that if -Wa,-mfix-cn63xxp1 is not supported by your assembler,
>> breaking the build is the proper thing to do.
>
> Fair enough. Maybe the condition should be refined to be based off
> CONFIG_CAVIUM_CN63XXP1?
Which is already the case... sorry for the noise.
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-15 21:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 19:06 [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option Florian Fainelli
2014-01-15 19:06 ` Florian Fainelli
2014-01-15 19:11 ` David Daney
2014-01-15 19:11 ` David Daney
2014-01-15 20:04 ` Florian Fainelli
2014-01-15 21:24 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.