All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 5/5] ath9k: Fix TX IQ calibration for SoC chips
Date: Fri, 17 Jan 2014 08:30:22 +0100	[thread overview]
Message-ID: <52D8DC0E.40207@neratec.com> (raw)
In-Reply-To: <21208.20686.79159.966434@gargle.gargle.HOWL>

On 01/16/2014 10:36 PM, Sujith Manoharan wrote:
> Wojciech Dubowik wrote:
>> I guess I won't be able to reproduce bad scan results with wireless
>> testing since I have
>> changed scan reporting to pure rssi in my openwrt compat.
>> In normal case you get a sum of rssi and noise floor and it will be
>> correct i.e. when
>> NF is shifted by 14db so will be rssi.
>> So it's just my use case.
>>
>> Anyway I have just solved the issue by applying calibrated noise floor
>> values from eeprom
>> instead of nominal in nf_get functions and nf histogram. Now the rssi
>> seems stable in my test
>> environment. I have just started testing but it looks promising.
> I don't see how that would fix the issue. The race still remains since
> there is a window between NF cal init and completion. The results
> of the calibration depends on the environment and using default values
> from the eeprom will not fix this, I think.
>
> Sujith
I agree it's more of a workaround because there can be situations
where measured value is far from calibrated. In my setup it
helps but I haven't yet tested what happens in the noisy environment.

Do you know a better way to fix this? I am not so deep into calibration
tasks but I have a working setup so I could spend more time on that.

Wojtek

WARNING: multiple messages have this Message-ID (diff)
From: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/5] ath9k: Fix TX IQ calibration for SoC chips
Date: Fri, 17 Jan 2014 08:30:22 +0100	[thread overview]
Message-ID: <52D8DC0E.40207@neratec.com> (raw)
In-Reply-To: <21208.20686.79159.966434@gargle.gargle.HOWL>

On 01/16/2014 10:36 PM, Sujith Manoharan wrote:
> Wojciech Dubowik wrote:
>> I guess I won't be able to reproduce bad scan results with wireless
>> testing since I have
>> changed scan reporting to pure rssi in my openwrt compat.
>> In normal case you get a sum of rssi and noise floor and it will be
>> correct i.e. when
>> NF is shifted by 14db so will be rssi.
>> So it's just my use case.
>>
>> Anyway I have just solved the issue by applying calibrated noise floor
>> values from eeprom
>> instead of nominal in nf_get functions and nf histogram. Now the rssi
>> seems stable in my test
>> environment. I have just started testing but it looks promising.
> I don't see how that would fix the issue. The race still remains since
> there is a window between NF cal init and completion. The results
> of the calibration depends on the environment and using default values
> from the eeprom will not fix this, I think.
>
> Sujith
I agree it's more of a workaround because there can be situations
where measured value is far from calibrated. In my setup it
helps but I haven't yet tested what happens in the noisy environment.

Do you know a better way to fix this? I am not so deep into calibration
tasks but I have a working setup so I could spend more time on that.

Wojtek


  reply	other threads:[~2014-01-17  7:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17  5:10 [PATCH 1/5] ath9k: Separate routines for PCOEM and SoC calibration Sujith Manoharan
2013-11-17  5:10 ` [PATCH 2/5] ath9k: Remove RTT/MCI code from " Sujith Manoharan
2013-11-17  5:10 ` [PATCH 3/5] ath9k: Remove unnecessary check Sujith Manoharan
2013-11-17  5:10 ` [PATCH 4/5] ath9k: Fix Carrier Leak calibration for SoC chips Sujith Manoharan
2013-11-17  5:10 ` [PATCH 5/5] ath9k: Fix TX IQ " Sujith Manoharan
2014-01-09 12:17   ` Wojciech Dubowik
2014-01-09 13:10     ` Sujith Manoharan
2014-01-09 13:35       ` Wojciech Dubowik
2014-01-09 13:52         ` Sujith Manoharan
2014-01-09 13:59           ` Wojciech Dubowik
2014-01-13 14:34             ` Wojciech Dubowik
2014-01-13 15:07               ` Sujith Manoharan
     [not found]                 ` <52D402C3.3070606@neratec.com>
     [not found]                   ` <21204.1991.201080.986559@gargle.gargle.HOWL>
2014-01-13 15:42                     ` Sujith Manoharan
2014-01-13 16:06                       ` Sujith Manoharan
2014-01-15  7:54                         ` Wojciech Dubowik
2014-01-15  8:15                           ` Sujith Manoharan
2014-01-15  8:30                             ` Wojciech Dubowik
2014-01-16 11:06                               ` [ath9k-devel] " Sujith Manoharan
2014-01-16 11:06                                 ` Sujith Manoharan
2014-01-16 11:19                                 ` [ath9k-devel] " Sujith Manoharan
2014-01-16 11:19                                   ` Sujith Manoharan
2014-01-16 11:44                                   ` [ath9k-devel] " Wojciech Dubowik
2014-01-16 11:44                                     ` Wojciech Dubowik
2014-01-16 21:36                                     ` [ath9k-devel] " Sujith Manoharan
2014-01-16 21:36                                       ` Sujith Manoharan
2014-01-17  7:30                                       ` Wojciech Dubowik [this message]
2014-01-17  7:30                                         ` Wojciech Dubowik
2014-01-20  3:33                                         ` [ath9k-devel] " Sujith Manoharan
2014-01-20  3:33                                           ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D8DC0E.40207@neratec.com \
    --to=wojciech.dubowik@neratec.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.