All of lore.kernel.org
 help / color / mirror / Atom feed
From: syin@broadcom.com (Sherman Yin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: capri: add dependency on OF
Date: Fri, 17 Jan 2014 11:51:30 -0800	[thread overview]
Message-ID: <52D989C2.6030603@broadcom.com> (raw)
In-Reply-To: <1389912312-16285-1-git-send-email-linus.walleij@linaro.org>

On 14-01-16 02:45 PM, Linus Walleij wrote:
> As this driver is using pinconf_generic_dt_node_to_map_pin() it
> needs to depend on OF so as not to cause build problems on
> archs that do not support OF.
>
> Cc: Sherman Yin <syin@broadcom.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>   drivers/pinctrl/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f1dda4d9de13..be361b7cd30f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,6 +106,7 @@ config PINCTRL_BCM2835
>
>   config PINCTRL_CAPRI
>   	bool "Broadcom Capri pinctrl driver"
> +	depends on OF
>   	select PINMUX
>   	select PINCONF
>   	select GENERIC_PINCONF
>

Thanks for the fix, Linus.  While we're visiting this config, should we 
add "depends on MACH_BCM_MOBILE" as well?

Thanks,
Sherman

WARNING: multiple messages have this Message-ID (diff)
From: Sherman Yin <syin@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: Stephen Warren <swarren@nvidia.com>, Christian Daudt <bcm@fixthebug.org>
Subject: Re: [PATCH] pinctrl: capri: add dependency on OF
Date: Fri, 17 Jan 2014 11:51:30 -0800	[thread overview]
Message-ID: <52D989C2.6030603@broadcom.com> (raw)
In-Reply-To: <1389912312-16285-1-git-send-email-linus.walleij@linaro.org>

On 14-01-16 02:45 PM, Linus Walleij wrote:
> As this driver is using pinconf_generic_dt_node_to_map_pin() it
> needs to depend on OF so as not to cause build problems on
> archs that do not support OF.
>
> Cc: Sherman Yin <syin@broadcom.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>   drivers/pinctrl/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f1dda4d9de13..be361b7cd30f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,6 +106,7 @@ config PINCTRL_BCM2835
>
>   config PINCTRL_CAPRI
>   	bool "Broadcom Capri pinctrl driver"
> +	depends on OF
>   	select PINMUX
>   	select PINCONF
>   	select GENERIC_PINCONF
>

Thanks for the fix, Linus.  While we're visiting this config, should we 
add "depends on MACH_BCM_MOBILE" as well?

Thanks,
Sherman

  reply	other threads:[~2014-01-17 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 22:45 [PATCH] pinctrl: capri: add dependency on OF Linus Walleij
2014-01-16 22:45 ` Linus Walleij
2014-01-17 19:51 ` Sherman Yin [this message]
2014-01-17 19:51   ` Sherman Yin
2014-01-17 23:12   ` Linus Walleij
2014-01-17 23:12     ` Linus Walleij
2014-01-17 23:13     ` Linus Walleij
2014-01-17 23:13       ` Linus Walleij
2014-01-17 23:27       ` Stephen Warren
2014-01-17 23:27         ` Stephen Warren
2014-01-20  8:17         ` Linus Walleij
2014-01-20  8:17           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D989C2.6030603@broadcom.com \
    --to=syin@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.