* [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-16 22:45 ` Linus Walleij 0 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-16 22:45 UTC (permalink / raw) To: linux-arm-kernel As this driver is using pinconf_generic_dt_node_to_map_pin() it needs to depend on OF so as not to cause build problems on archs that do not support OF. Cc: Sherman Yin <syin@broadcom.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index f1dda4d9de13..be361b7cd30f 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -106,6 +106,7 @@ config PINCTRL_BCM2835 config PINCTRL_CAPRI bool "Broadcom Capri pinctrl driver" + depends on OF select PINMUX select PINCONF select GENERIC_PINCONF -- 1.8.4.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-16 22:45 ` Linus Walleij 0 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-16 22:45 UTC (permalink / raw) To: linux-kernel, linux-arm-kernel; +Cc: Stephen Warren, Linus Walleij, Sherman Yin As this driver is using pinconf_generic_dt_node_to_map_pin() it needs to depend on OF so as not to cause build problems on archs that do not support OF. Cc: Sherman Yin <syin@broadcom.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index f1dda4d9de13..be361b7cd30f 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -106,6 +106,7 @@ config PINCTRL_BCM2835 config PINCTRL_CAPRI bool "Broadcom Capri pinctrl driver" + depends on OF select PINMUX select PINCONF select GENERIC_PINCONF -- 1.8.4.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] pinctrl: capri: add dependency on OF 2014-01-16 22:45 ` Linus Walleij @ 2014-01-17 19:51 ` Sherman Yin -1 siblings, 0 replies; 12+ messages in thread From: Sherman Yin @ 2014-01-17 19:51 UTC (permalink / raw) To: linux-arm-kernel On 14-01-16 02:45 PM, Linus Walleij wrote: > As this driver is using pinconf_generic_dt_node_to_map_pin() it > needs to depend on OF so as not to cause build problems on > archs that do not support OF. > > Cc: Sherman Yin <syin@broadcom.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/pinctrl/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index f1dda4d9de13..be361b7cd30f 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -106,6 +106,7 @@ config PINCTRL_BCM2835 > > config PINCTRL_CAPRI > bool "Broadcom Capri pinctrl driver" > + depends on OF > select PINMUX > select PINCONF > select GENERIC_PINCONF > Thanks for the fix, Linus. While we're visiting this config, should we add "depends on MACH_BCM_MOBILE" as well? Thanks, Sherman ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-17 19:51 ` Sherman Yin 0 siblings, 0 replies; 12+ messages in thread From: Sherman Yin @ 2014-01-17 19:51 UTC (permalink / raw) To: Linus Walleij, linux-kernel, linux-arm-kernel Cc: Stephen Warren, Christian Daudt On 14-01-16 02:45 PM, Linus Walleij wrote: > As this driver is using pinconf_generic_dt_node_to_map_pin() it > needs to depend on OF so as not to cause build problems on > archs that do not support OF. > > Cc: Sherman Yin <syin@broadcom.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/pinctrl/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index f1dda4d9de13..be361b7cd30f 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -106,6 +106,7 @@ config PINCTRL_BCM2835 > > config PINCTRL_CAPRI > bool "Broadcom Capri pinctrl driver" > + depends on OF > select PINMUX > select PINCONF > select GENERIC_PINCONF > Thanks for the fix, Linus. While we're visiting this config, should we add "depends on MACH_BCM_MOBILE" as well? Thanks, Sherman ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] pinctrl: capri: add dependency on OF 2014-01-17 19:51 ` Sherman Yin @ 2014-01-17 23:12 ` Linus Walleij -1 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-17 23:12 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: > Thanks for the fix, Linus. While we're visiting this config, should we add > "depends on MACH_BCM_MOBILE" as well? No, it's nice to get the compile coverage. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-17 23:12 ` Linus Walleij 0 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-17 23:12 UTC (permalink / raw) To: Sherman Yin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren, Christian Daudt On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: > Thanks for the fix, Linus. While we're visiting this config, should we add > "depends on MACH_BCM_MOBILE" as well? No, it's nice to get the compile coverage. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] pinctrl: capri: add dependency on OF 2014-01-17 23:12 ` Linus Walleij @ 2014-01-17 23:13 ` Linus Walleij -1 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-17 23:13 UTC (permalink / raw) To: linux-arm-kernel On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: > >> Thanks for the fix, Linus. While we're visiting this config, should we add >> "depends on MACH_BCM_MOBILE" as well? > > No, it's nice to get the compile coverage. But maybe you can experiment with that special option that only turns on the driver on other platforms to do compile test. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-17 23:13 ` Linus Walleij 0 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-17 23:13 UTC (permalink / raw) To: Sherman Yin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren, Christian Daudt On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: > >> Thanks for the fix, Linus. While we're visiting this config, should we add >> "depends on MACH_BCM_MOBILE" as well? > > No, it's nice to get the compile coverage. But maybe you can experiment with that special option that only turns on the driver on other platforms to do compile test. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] pinctrl: capri: add dependency on OF 2014-01-17 23:13 ` Linus Walleij @ 2014-01-17 23:27 ` Stephen Warren -1 siblings, 0 replies; 12+ messages in thread From: Stephen Warren @ 2014-01-17 23:27 UTC (permalink / raw) To: linux-arm-kernel On 01/17/2014 04:13 PM, Linus Walleij wrote: > On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij > <linus.walleij@linaro.org> wrote: >> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: >> >>> Thanks for the fix, Linus. While we're visiting this config, should we add >>> "depends on MACH_BCM_MOBILE" as well? >> >> No, it's nice to get the compile coverage. > > But maybe you can experiment with that special option that only > turns on the driver on other platforms to do compile test. a/k/a depends on XXX || COMPILE_TEST ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-17 23:27 ` Stephen Warren 0 siblings, 0 replies; 12+ messages in thread From: Stephen Warren @ 2014-01-17 23:27 UTC (permalink / raw) To: Linus Walleij, Sherman Yin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren, Christian Daudt On 01/17/2014 04:13 PM, Linus Walleij wrote: > On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij > <linus.walleij@linaro.org> wrote: >> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: >> >>> Thanks for the fix, Linus. While we're visiting this config, should we add >>> "depends on MACH_BCM_MOBILE" as well? >> >> No, it's nice to get the compile coverage. > > But maybe you can experiment with that special option that only > turns on the driver on other platforms to do compile test. a/k/a depends on XXX || COMPILE_TEST ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] pinctrl: capri: add dependency on OF 2014-01-17 23:27 ` Stephen Warren @ 2014-01-20 8:17 ` Linus Walleij -1 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-20 8:17 UTC (permalink / raw) To: linux-arm-kernel On Sat, Jan 18, 2014 at 12:27 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 01/17/2014 04:13 PM, Linus Walleij wrote: >> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij >> <linus.walleij@linaro.org> wrote: >>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: >>> >>>> Thanks for the fix, Linus. While we're visiting this config, should we add >>>> "depends on MACH_BCM_MOBILE" as well? >>> >>> No, it's nice to get the compile coverage. >> >> But maybe you can experiment with that special option that only >> turns on the driver on other platforms to do compile test. > > a/k/a > depends on XXX || COMPILE_TEST Yep, thanks Stephen :-) Linus Walleij ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] pinctrl: capri: add dependency on OF @ 2014-01-20 8:17 ` Linus Walleij 0 siblings, 0 replies; 12+ messages in thread From: Linus Walleij @ 2014-01-20 8:17 UTC (permalink / raw) To: Stephen Warren Cc: Sherman Yin, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren, Christian Daudt On Sat, Jan 18, 2014 at 12:27 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 01/17/2014 04:13 PM, Linus Walleij wrote: >> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij >> <linus.walleij@linaro.org> wrote: >>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <syin@broadcom.com> wrote: >>> >>>> Thanks for the fix, Linus. While we're visiting this config, should we add >>>> "depends on MACH_BCM_MOBILE" as well? >>> >>> No, it's nice to get the compile coverage. >> >> But maybe you can experiment with that special option that only >> turns on the driver on other platforms to do compile test. > > a/k/a > depends on XXX || COMPILE_TEST Yep, thanks Stephen :-) Linus Walleij ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-01-20 8:17 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-16 22:45 [PATCH] pinctrl: capri: add dependency on OF Linus Walleij 2014-01-16 22:45 ` Linus Walleij 2014-01-17 19:51 ` Sherman Yin 2014-01-17 19:51 ` Sherman Yin 2014-01-17 23:12 ` Linus Walleij 2014-01-17 23:12 ` Linus Walleij 2014-01-17 23:13 ` Linus Walleij 2014-01-17 23:13 ` Linus Walleij 2014-01-17 23:27 ` Stephen Warren 2014-01-17 23:27 ` Stephen Warren 2014-01-20 8:17 ` Linus Walleij 2014-01-20 8:17 ` Linus Walleij
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.