All of lore.kernel.org
 help / color / mirror / Atom feed
From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] USB: at91: fix the number of endpoint parameter
Date: Mon, 20 Jan 2014 11:39:18 +0800	[thread overview]
Message-ID: <52DC9A66.6080009@atmel.com> (raw)
In-Reply-To: <20140118052059.GL9558@ns203013.ovh.net>

Hi J,

On 01/18/2014 01:20 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:59 Fri 17 Jan     , Bo Shen wrote:
>> In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS
>> is only 7. So, fix it for sama5d3 SoC using the udc->num_ep.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>>
>>   drivers/usb/gadget/atmel_usba_udc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
>> index 2cb52e0..7e67a81 100644
>> --- a/drivers/usb/gadget/atmel_usba_udc.c
>> +++ b/drivers/usb/gadget/atmel_usba_udc.c
>> @@ -1670,7 +1670,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>>   	if (ep_status) {
>>   		int i;
>>
>> -		for (i = 0; i < USBA_NR_ENDPOINTS; i++)
>> +		for (i = 0; i < udc->num_ep; i++)
>
> no the limit need to specified in the driver as a checkpoint by the compatible
> or platform driver id

You mean, we should not trust the data passed from dt node or platform 
data? Or do you think we should do double confirm?

> Best Regards,
> J.
>>   			if (ep_status & (1 << i)) {
>>   				if (ep_is_control(&udc->usba_ep[i]))
>>   					usba_control_irq(udc, &udc->usba_ep[i]);
>> --
>> 1.8.5.2
>>

Best Regards,
Bo Shen

WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Felipe Balbi <balbi@ti.com>, <nicolas.ferre@atmel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] USB: at91: fix the number of endpoint parameter
Date: Mon, 20 Jan 2014 11:39:18 +0800	[thread overview]
Message-ID: <52DC9A66.6080009@atmel.com> (raw)
In-Reply-To: <20140118052059.GL9558@ns203013.ovh.net>

Hi J,

On 01/18/2014 01:20 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:59 Fri 17 Jan     , Bo Shen wrote:
>> In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS
>> is only 7. So, fix it for sama5d3 SoC using the udc->num_ep.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>>
>>   drivers/usb/gadget/atmel_usba_udc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
>> index 2cb52e0..7e67a81 100644
>> --- a/drivers/usb/gadget/atmel_usba_udc.c
>> +++ b/drivers/usb/gadget/atmel_usba_udc.c
>> @@ -1670,7 +1670,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>>   	if (ep_status) {
>>   		int i;
>>
>> -		for (i = 0; i < USBA_NR_ENDPOINTS; i++)
>> +		for (i = 0; i < udc->num_ep; i++)
>
> no the limit need to specified in the driver as a checkpoint by the compatible
> or platform driver id

You mean, we should not trust the data passed from dt node or platform 
data? Or do you think we should do double confirm?

> Best Regards,
> J.
>>   			if (ep_status & (1 << i)) {
>>   				if (ep_is_control(&udc->usba_ep[i]))
>>   					usba_control_irq(udc, &udc->usba_ep[i]);
>> --
>> 1.8.5.2
>>

Best Regards,
Bo Shen

  reply	other threads:[~2014-01-20  3:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17  2:59 [PATCH 1/2] USB: at91: fix the number of endpoint parameter Bo Shen
2014-01-17  2:59 ` Bo Shen
2014-01-17  2:59 ` [PATCH 2/2] USB: at91: using USBA_NR_DMAS for DMA channels Bo Shen
2014-01-17  2:59   ` Bo Shen
2014-01-17  9:29   ` Nicolas Ferre
2014-01-17  9:29     ` Nicolas Ferre
2014-02-18 16:19   ` Felipe Balbi
2014-02-18 16:19     ` Felipe Balbi
2014-02-19  1:14     ` Bo Shen
2014-02-19  1:14       ` Bo Shen
2014-02-19  1:22       ` Felipe Balbi
2014-02-19  1:22         ` Felipe Balbi
2014-02-19  1:46         ` Bo Shen
2014-02-19  1:46           ` Bo Shen
2014-01-17  9:29 ` [PATCH 1/2] USB: at91: fix the number of endpoint parameter Nicolas Ferre
2014-01-17  9:29   ` Nicolas Ferre
2014-01-18  5:20 ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-18  5:20   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-20  3:39   ` Bo Shen [this message]
2014-01-20  3:39     ` Bo Shen
2014-01-21  5:49     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-21  5:49       ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-21  8:12       ` Bo Shen
2014-01-21  8:12         ` Bo Shen
2014-01-21  9:06         ` Nicolas Ferre
2014-01-21  9:06           ` Nicolas Ferre
2014-02-07  8:37           ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07  8:37             ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DC9A66.6080009@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.