From: Wen Congyang <wency@cn.fujitsu.com>
To: rshriram@cs.ubc.ca, Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Dong Eddie <eddie.dong@intel.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 13/13 V6] tools/libxl: network buffering cmdline switch
Date: Mon, 27 Jan 2014 14:58:35 +0800 [thread overview]
Message-ID: <52E6039B.6040806@cn.fujitsu.com> (raw)
In-Reply-To: <CAP8mzPNEiuL9NZdRNjUhuMyGweZJExRE1KdAzU5ZkRnQXodbrg@mail.gmail.com>
At 01/27/2014 06:31 AM, Shriram Rajagopalan Wrote:
> On Tue, Jan 21, 2014 at 1:05 AM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>
>> From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
>>
>> Command line switch to 'xl remus' command, to enable network buffering.
>> Pass on this flag to libxl so that it can act accordingly.
>> Also update man pages to reflect the addition of a new option to
>> 'xl remus' command.
>>
>> Note: the network buffering is enabled as default. If you want to
>> disable it, please use -n option.
>>
>>
>
>> diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
>> index ebe0220..f05e07b 100644
>> --- a/tools/libxl/xl_cmdtable.c
>> +++ b/tools/libxl/xl_cmdtable.c
>> @@ -481,6 +481,9 @@ struct cmd_spec cmd_table[] = {
>> "-i MS Checkpoint domain memory every MS
>> milliseconds (def. 200ms).\n"
>> "-b Replicate memory checkpoints to /dev/null
>> (blackhole)\n"
>> "-u Disable memory checkpoint compression.\n"
>> + "-n Enable network output buffering.\n"
>>
>
> Since network buffering is enabled by default, this should be "Disable
> network output..".
Yes, we forgot to update this description.
Thanks
Wen Congyang
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2014-01-27 6:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 9:05 [PATCH 00/13 V6] Remus/Libxl: Network buffering support Lai Jiangshan
2014-01-21 9:05 ` [PATCH 01/13 V6] remus: add libnl3 dependency to autoconf scripts Lai Jiangshan
2014-01-21 9:05 ` [PATCH 02/13 V6] remus: implement network buffering hotplug scripts Lai Jiangshan
2014-01-26 22:27 ` Shriram Rajagopalan
2014-01-27 7:06 ` Wen Congyang
2014-01-27 18:05 ` Shriram Rajagopalan
2014-01-28 9:29 ` Ian Campbell
2014-02-10 2:29 ` Lai Jiangshan
2014-01-21 9:05 ` [PATCH 03/13 V6] tools/libxl: update libxl_domain_remus_info Lai Jiangshan
2014-01-21 9:05 ` [PATCH 04/13 V6] tools/libxl: introduce a new structure libxl__remus_state Lai Jiangshan
2014-01-21 9:05 ` [PATCH 05/13 V6] remus: introduce a function to check whether network buffering is enabled Lai Jiangshan
2014-01-21 9:05 ` [PATCH 06/13 V6] remus: implement the API to setup network buffering Lai Jiangshan
2014-01-26 22:30 ` Shriram Rajagopalan
2014-01-27 6:57 ` Wen Congyang
2014-01-21 9:05 ` [PATCH 07/13 V6] remus: implement the API to buffer/release packages Lai Jiangshan
2014-01-21 9:05 ` [PATCH 08/13 V6] remus: implement the API to teardown network buffering Lai Jiangshan
2014-01-21 9:05 ` [PATCH 09/13 V6] remus: use the API to setup " Lai Jiangshan
2014-01-21 9:05 ` [PATCH 10/13 V6] remus: use the API to teardown " Lai Jiangshan
2014-01-21 9:05 ` [PATCH 11/13 V6] remus: rename remus_failover_cb() to remus_replication_failure_cb() Lai Jiangshan
2014-01-21 9:05 ` [PATCH 12/13 V6] tools/libxl: control network buffering in remus callbacks Lai Jiangshan
2014-01-21 9:05 ` [PATCH 13/13 V6] tools/libxl: network buffering cmdline switch Lai Jiangshan
2014-01-26 22:31 ` Shriram Rajagopalan
2014-01-27 6:58 ` Wen Congyang [this message]
2014-01-24 10:14 ` [PATCH 00/13 V6] Remus/Libxl: Network buffering support Lai Jiangshan
2014-01-24 10:20 ` Ian Campbell
2014-01-26 22:26 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E6039B.6040806@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=laijs@cn.fujitsu.com \
--cc=roger.pau@citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.