From: Wen Congyang <wency@cn.fujitsu.com>
To: rshriram@cs.ubc.ca, Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Dong Eddie <eddie.dong@intel.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 02/13 V6] remus: implement network buffering hotplug scripts
Date: Mon, 27 Jan 2014 15:06:16 +0800 [thread overview]
Message-ID: <52E60568.7060305@cn.fujitsu.com> (raw)
In-Reply-To: <CAP8mzPPhwsQ=mn-xJAG7FzvHoBdSBVdrtFdzgMJM2gac_CpmuA@mail.gmail.com>
At 01/27/2014 06:27 AM, Shriram Rajagopalan Wrote:
> On Tue, Jan 21, 2014 at 1:05 AM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>
>> From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
>>
>> This patch introduces remus-netbuf-setup hotplug script responsible for
>> setting up and tearing down the necessary infrastructure required for
>> network output buffering in Remus. This script is intended to be invoked
>> by libxl for each guest interface, when starting or stopping Remus.
>>
>> Apart from returning success/failure indication via the usual hotplug
>> entries in xenstore, this script also writes to xenstore, the name of
>> the IFB device to be used to control the vif's network output.
>>
>> The script relies on libnl3 command line utilities to perform various
>> setup/teardown functions. The script is confined to Linux platforms only
>> since NetBSD does not seem to have libnl3.
>>
>> Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>> Reviewed-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> tools/hotplug/Linux/Makefile | 1 +
>> tools/hotplug/Linux/remus-netbuf-setup | 183
>> +++++++++++++++++++++++++++++++++
>> 2 files changed, 184 insertions(+)
>> create mode 100644 tools/hotplug/Linux/remus-netbuf-setup
>>
>>
> The last time I posted this script, the feedback was that the script and
> the code invoking
> the script should be in a single patch. So I would suggest doing the same.
We use the script in patch6. It adds 479 lines. These two patches are big
patches(add more than 100 lines), so why put them into a single patch?
Thanks
Wen Congyang
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2014-01-27 7:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 9:05 [PATCH 00/13 V6] Remus/Libxl: Network buffering support Lai Jiangshan
2014-01-21 9:05 ` [PATCH 01/13 V6] remus: add libnl3 dependency to autoconf scripts Lai Jiangshan
2014-01-21 9:05 ` [PATCH 02/13 V6] remus: implement network buffering hotplug scripts Lai Jiangshan
2014-01-26 22:27 ` Shriram Rajagopalan
2014-01-27 7:06 ` Wen Congyang [this message]
2014-01-27 18:05 ` Shriram Rajagopalan
2014-01-28 9:29 ` Ian Campbell
2014-02-10 2:29 ` Lai Jiangshan
2014-01-21 9:05 ` [PATCH 03/13 V6] tools/libxl: update libxl_domain_remus_info Lai Jiangshan
2014-01-21 9:05 ` [PATCH 04/13 V6] tools/libxl: introduce a new structure libxl__remus_state Lai Jiangshan
2014-01-21 9:05 ` [PATCH 05/13 V6] remus: introduce a function to check whether network buffering is enabled Lai Jiangshan
2014-01-21 9:05 ` [PATCH 06/13 V6] remus: implement the API to setup network buffering Lai Jiangshan
2014-01-26 22:30 ` Shriram Rajagopalan
2014-01-27 6:57 ` Wen Congyang
2014-01-21 9:05 ` [PATCH 07/13 V6] remus: implement the API to buffer/release packages Lai Jiangshan
2014-01-21 9:05 ` [PATCH 08/13 V6] remus: implement the API to teardown network buffering Lai Jiangshan
2014-01-21 9:05 ` [PATCH 09/13 V6] remus: use the API to setup " Lai Jiangshan
2014-01-21 9:05 ` [PATCH 10/13 V6] remus: use the API to teardown " Lai Jiangshan
2014-01-21 9:05 ` [PATCH 11/13 V6] remus: rename remus_failover_cb() to remus_replication_failure_cb() Lai Jiangshan
2014-01-21 9:05 ` [PATCH 12/13 V6] tools/libxl: control network buffering in remus callbacks Lai Jiangshan
2014-01-21 9:05 ` [PATCH 13/13 V6] tools/libxl: network buffering cmdline switch Lai Jiangshan
2014-01-26 22:31 ` Shriram Rajagopalan
2014-01-27 6:58 ` Wen Congyang
2014-01-24 10:14 ` [PATCH 00/13 V6] Remus/Libxl: Network buffering support Lai Jiangshan
2014-01-24 10:20 ` Ian Campbell
2014-01-26 22:26 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E60568.7060305@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=laijs@cn.fujitsu.com \
--cc=roger.pau@citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.