From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Dong Eddie <eddie.dong@intel.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
rshriram@cs.ubc.ca, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 02/13 V6] remus: implement network buffering hotplug scripts
Date: Mon, 10 Feb 2014 10:29:51 +0800 [thread overview]
Message-ID: <52F8399F.5030804@cn.fujitsu.com> (raw)
In-Reply-To: <1390901372.7753.2.camel@kazak.uk.xensource.com>
On 01/28/2014 05:29 PM, Ian Campbell wrote:
> On Mon, 2014-01-27 at 10:05 -0800, Shriram Rajagopalan wrote:
>> On Sun, Jan 26, 2014 at 11:06 PM, Wen Congyang <wency@cn.fujitsu.com>
>> wrote:
>> > The last time I posted this script, the feedback was that
>> the script and> the code invoking > the script should be in a
>> single patch. So I would suggest doing the same.
>>
>>
>> We use the script in patch6. It adds 479 lines. These two
>> patches are big patches(add more than 100 lines), so why put
>> them into a single patch?
>
>>
>> That is a valid question. IIRC, IanJ was the one who wanted the code
>> and the script together. IanJ, any thoughts?
>
> Unless the patches are so big they won't get past the mailing list
> filters (which are 100s of Kb I think) the important thing is the
> logical separation of functionality into separate patches, not the
> individual line count of each patch.
>
We did the logically separate, patches are split by functionalities, ^_^.
They are a little more fine-grain-separation than previous versions.
fine-grain-separation patches are much convenient to be reviewed in the
mail-list and in the future changlog.
If any one insist the original way, we will change it back.
thx,
Lai
next prev parent reply other threads:[~2014-02-10 2:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 9:05 [PATCH 00/13 V6] Remus/Libxl: Network buffering support Lai Jiangshan
2014-01-21 9:05 ` [PATCH 01/13 V6] remus: add libnl3 dependency to autoconf scripts Lai Jiangshan
2014-01-21 9:05 ` [PATCH 02/13 V6] remus: implement network buffering hotplug scripts Lai Jiangshan
2014-01-26 22:27 ` Shriram Rajagopalan
2014-01-27 7:06 ` Wen Congyang
2014-01-27 18:05 ` Shriram Rajagopalan
2014-01-28 9:29 ` Ian Campbell
2014-02-10 2:29 ` Lai Jiangshan [this message]
2014-01-21 9:05 ` [PATCH 03/13 V6] tools/libxl: update libxl_domain_remus_info Lai Jiangshan
2014-01-21 9:05 ` [PATCH 04/13 V6] tools/libxl: introduce a new structure libxl__remus_state Lai Jiangshan
2014-01-21 9:05 ` [PATCH 05/13 V6] remus: introduce a function to check whether network buffering is enabled Lai Jiangshan
2014-01-21 9:05 ` [PATCH 06/13 V6] remus: implement the API to setup network buffering Lai Jiangshan
2014-01-26 22:30 ` Shriram Rajagopalan
2014-01-27 6:57 ` Wen Congyang
2014-01-21 9:05 ` [PATCH 07/13 V6] remus: implement the API to buffer/release packages Lai Jiangshan
2014-01-21 9:05 ` [PATCH 08/13 V6] remus: implement the API to teardown network buffering Lai Jiangshan
2014-01-21 9:05 ` [PATCH 09/13 V6] remus: use the API to setup " Lai Jiangshan
2014-01-21 9:05 ` [PATCH 10/13 V6] remus: use the API to teardown " Lai Jiangshan
2014-01-21 9:05 ` [PATCH 11/13 V6] remus: rename remus_failover_cb() to remus_replication_failure_cb() Lai Jiangshan
2014-01-21 9:05 ` [PATCH 12/13 V6] tools/libxl: control network buffering in remus callbacks Lai Jiangshan
2014-01-21 9:05 ` [PATCH 13/13 V6] tools/libxl: network buffering cmdline switch Lai Jiangshan
2014-01-26 22:31 ` Shriram Rajagopalan
2014-01-27 6:58 ` Wen Congyang
2014-01-24 10:14 ` [PATCH 00/13 V6] Remus/Libxl: Network buffering support Lai Jiangshan
2014-01-24 10:20 ` Ian Campbell
2014-01-26 22:26 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F8399F.5030804@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=Ian.Campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.