Re: [PATCH 1/8] pci-rcar-gen2: add of match table

[Ben Dooks <ben.dooks@codethink.co.uk>]

On 27/01/14 12:48, Sergei Shtylyov wrote:
> Hello.
>
> On 26-01-2014 20:48, Ben Dooks wrote:
>
>> Add OF match table for pci-rcar-gen2 driver for device tree support.
>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: linux-pci@vger.kernel.org
>> Cc: linux-sh@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> ---
>>   drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>
>> diff --git a/drivers/pci/host/pci-rcar-gen2.c
>> b/drivers/pci/host/pci-rcar-gen2.c
>> index ceec147..ea65bac 100644
>> --- a/drivers/pci/host/pci-rcar-gen2.c
>> +++ b/drivers/pci/host/pci-rcar-gen2.c
>> @@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct
>> platform_device *pdev)
>>       return rcar_pci_add_controller(priv);
>>   }
>>
>> +static struct of_device_id rcar_pci_of_match[] = {
>> +    { .compatible = "renesas,pci-r8a7790", },
>
>     Why only H2 SoC, if the driver is for both Gen2 SoCs?

I can add a "renesas,pci-rcar-gen2" as a fallback match however
I've not got anything other than an r8a7790 to test on. Also the
compatible properties are preferably named after the soc.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius