From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] phy-rcar-usb-gen2: add device tree support
Date: Wed, 29 Jan 2014 10:41:58 +0000 [thread overview]
Message-ID: <52E8DAF6.5090105@cogentembedded.com> (raw)
In-Reply-To: <20140129062212.GD23833-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Hello.
On 29-01-2014 10:22, Simon Horman wrote:
>> [snip]
>>>> +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
>>>> + { .compatible = "renesas,usb-phy-r8a7790", },
>>>> + { .compatible = "renesas,rcar-gen2-usb-phy", },
>>> Frankly speaking, I don't understand the need for the clearly
>>> duplicate entries.
>> Thanks, will look into remove it.
>> Anyone else have any comments on this?
> I would like you to leave it there.
> As we know the r8a7790 is an R-Car Gen2 SoC. But there are other R-Car
> Gen2 SoCs, such as the r8a7791, they it could plausibly make use of
> rcar-gen2-usb-phy until the driver is updated with a usb-phy-r8a7791 entry.
Why not just "update" the driver this way now, may I ask?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] phy-rcar-usb-gen2: add device tree support
Date: Wed, 29 Jan 2014 14:41:58 +0400 [thread overview]
Message-ID: <52E8DAF6.5090105@cogentembedded.com> (raw)
In-Reply-To: <20140129062212.GD23833-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Hello.
On 29-01-2014 10:22, Simon Horman wrote:
>> [snip]
>>>> +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
>>>> + { .compatible = "renesas,usb-phy-r8a7790", },
>>>> + { .compatible = "renesas,rcar-gen2-usb-phy", },
>>> Frankly speaking, I don't understand the need for the clearly
>>> duplicate entries.
>> Thanks, will look into remove it.
>> Anyone else have any comments on this?
> I would like you to leave it there.
> As we know the r8a7790 is an R-Car Gen2 SoC. But there are other R-Car
> Gen2 SoCs, such as the r8a7791, they it could plausibly make use of
> rcar-gen2-usb-phy until the driver is updated with a usb-phy-r8a7791 entry.
Why not just "update" the driver this way now, may I ask?
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-29 10:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390754945-28142-1-git-send-email-ben.dooks@codethink.co.uk>
2014-01-26 16:48 ` [PATCH 1/8] pci-rcar-gen2: add of match table Ben Dooks
2014-01-27 12:48 ` Sergei Shtylyov
2014-01-27 12:48 ` Sergei Shtylyov
2014-01-27 13:27 ` Ben Dooks
2014-01-29 6:17 ` Simon Horman
2014-01-29 6:17 ` Simon Horman
2014-01-29 10:06 ` Geert Uytterhoeven
2014-01-29 10:06 ` Geert Uytterhoeven
2014-01-29 12:20 ` Simon Horman
2014-01-29 12:20 ` Simon Horman
2014-01-26 16:48 ` [PATCH 2/8] pci-rcar-gen2: add initial device tree documentation Ben Dooks
2014-01-26 19:09 ` Geert Uytterhoeven
2014-01-26 19:09 ` Geert Uytterhoeven
2014-01-27 12:07 ` Ben Dooks
2014-01-27 13:31 ` Sergei Shtylyov
2014-01-27 13:31 ` Sergei Shtylyov
2014-01-27 13:33 ` Ben Dooks
2014-01-27 17:13 ` Sergei Shtylyov
2014-01-27 18:13 ` Sergei Shtylyov
2014-01-26 16:49 ` [PATCH 3/8] ARM: shmbobile: r8a7790.dtsi: add pci0/1/2 nodes Ben Dooks
[not found] ` <1390754945-28142-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-26 16:49 ` [PATCH 4/8] ARM: shmobile: lager.dts: add pci 0/1/2 Ben Dooks
2014-01-26 16:49 ` Ben Dooks
2014-01-26 16:49 ` [PATCH 8/8] ARM: shmobile: lager.dtb: add usbphy reference Ben Dooks
2014-01-26 16:49 ` Ben Dooks
2014-01-26 16:49 ` [PATCH 5/8] phy-rcar-usb-gen2: add device tree support Ben Dooks
[not found] ` <1390754945-28142-6-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-26 17:04 ` Sergei Shtylyov
2014-01-26 18:03 ` Sergei Shtylyov
2014-01-26 17:08 ` Ben Dooks
2014-01-26 17:05 ` [PATCH] " Ben Dooks
2014-01-26 17:05 ` Ben Dooks
2014-01-27 15:33 ` Felipe Balbi
2014-01-27 15:33 ` Felipe Balbi
2014-01-27 17:23 ` Sergei Shtylyov
2014-01-27 18:23 ` Sergei Shtylyov
2014-01-27 19:06 ` Ben Dooks
[not found] ` <52E6AE32.5050906-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-29 6:22 ` Simon Horman
2014-01-29 6:22 ` Simon Horman
[not found] ` <20140129062212.GD23833-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-29 10:41 ` Sergei Shtylyov [this message]
2014-01-29 10:41 ` Sergei Shtylyov
2014-01-29 12:22 ` Simon Horman
2014-01-29 12:22 ` Simon Horman
[not found] ` <20140129122202.GB26253-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-29 12:26 ` Sergei Shtylyov
2014-01-29 12:26 ` Sergei Shtylyov
[not found] ` <52E8F38F.9030609-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-01-29 12:35 ` Simon Horman
2014-01-29 12:35 ` Simon Horman
2014-01-26 16:49 ` [PATCH 6/8] phy-rcar-usb-gen2: add device tree documentation Ben Dooks
2014-01-26 19:07 ` Geert Uytterhoeven
2014-01-26 19:07 ` Geert Uytterhoeven
2014-01-26 16:49 ` [PATCH 7/8] ARM: shmobile: r8a7790.dtsi: add usbphy node Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E8DAF6.5090105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.