From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@lists.codethink.co.uk,
Linux-sh list <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
horms+renesas@verge.net.au
Subject: Re: [PATCH 2/8] pci-rcar-gen2: add initial device tree documentation
Date: Mon, 27 Jan 2014 17:13:13 +0000 [thread overview]
Message-ID: <52E6A1B4.6060906@cogentembedded.com> (raw)
In-Reply-To: <52E6602A.8040003@codethink.co.uk>
Hello.
On 01/27/2014 04:33 PM, Ben Dooks wrote:
>>>> + - reg : A list of physical regions to access the device. The first is
>>>> + the operational registers for the OHCI/EHCI controller and the
>>>> + second region is for the bridge configuration and control
>>>> registers.
>>> You may want to add "reg-names" to use named regions, as there
>>> is more than one region.
>> I've already told Ben he can't claim EHCI/OHCI register ranges at
>> the bridge node, so there should be only one "reg" specifier.
> Well, that's going to take quite a bit of changing the driver as
> it already assumes two nodes from the platform device definition.
Ah, I failed to realize it's not your mistake, sorry.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@lists.codethink.co.uk,
Linux-sh list <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
horms+renesas@verge.net.au
Subject: Re: [PATCH 2/8] pci-rcar-gen2: add initial device tree documentation
Date: Mon, 27 Jan 2014 21:13:08 +0300 [thread overview]
Message-ID: <52E6A1B4.6060906@cogentembedded.com> (raw)
In-Reply-To: <52E6602A.8040003@codethink.co.uk>
Hello.
On 01/27/2014 04:33 PM, Ben Dooks wrote:
>>>> + - reg : A list of physical regions to access the device. The first is
>>>> + the operational registers for the OHCI/EHCI controller and the
>>>> + second region is for the bridge configuration and control
>>>> registers.
>>> You may want to add "reg-names" to use named regions, as there
>>> is more than one region.
>> I've already told Ben he can't claim EHCI/OHCI register ranges at
>> the bridge node, so there should be only one "reg" specifier.
> Well, that's going to take quite a bit of changing the driver as
> it already assumes two nodes from the platform device definition.
Ah, I failed to realize it's not your mistake, sorry.
WBR, Sergei
next prev parent reply other threads:[~2014-01-27 17:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390754945-28142-1-git-send-email-ben.dooks@codethink.co.uk>
2014-01-26 16:48 ` [PATCH 1/8] pci-rcar-gen2: add of match table Ben Dooks
2014-01-27 12:48 ` Sergei Shtylyov
2014-01-27 12:48 ` Sergei Shtylyov
2014-01-27 13:27 ` Ben Dooks
2014-01-29 6:17 ` Simon Horman
2014-01-29 6:17 ` Simon Horman
2014-01-29 10:06 ` Geert Uytterhoeven
2014-01-29 10:06 ` Geert Uytterhoeven
2014-01-29 12:20 ` Simon Horman
2014-01-29 12:20 ` Simon Horman
2014-01-26 16:48 ` [PATCH 2/8] pci-rcar-gen2: add initial device tree documentation Ben Dooks
2014-01-26 19:09 ` Geert Uytterhoeven
2014-01-26 19:09 ` Geert Uytterhoeven
2014-01-27 12:07 ` Ben Dooks
2014-01-27 13:31 ` Sergei Shtylyov
2014-01-27 13:31 ` Sergei Shtylyov
2014-01-27 13:33 ` Ben Dooks
2014-01-27 17:13 ` Sergei Shtylyov [this message]
2014-01-27 18:13 ` Sergei Shtylyov
2014-01-26 16:49 ` [PATCH 3/8] ARM: shmbobile: r8a7790.dtsi: add pci0/1/2 nodes Ben Dooks
[not found] ` <1390754945-28142-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-26 16:49 ` [PATCH 4/8] ARM: shmobile: lager.dts: add pci 0/1/2 Ben Dooks
2014-01-26 16:49 ` Ben Dooks
2014-01-26 16:49 ` [PATCH 8/8] ARM: shmobile: lager.dtb: add usbphy reference Ben Dooks
2014-01-26 16:49 ` Ben Dooks
2014-01-26 16:49 ` [PATCH 5/8] phy-rcar-usb-gen2: add device tree support Ben Dooks
[not found] ` <1390754945-28142-6-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-26 17:04 ` Sergei Shtylyov
2014-01-26 18:03 ` Sergei Shtylyov
2014-01-26 17:08 ` Ben Dooks
2014-01-26 17:05 ` [PATCH] " Ben Dooks
2014-01-26 17:05 ` Ben Dooks
2014-01-27 15:33 ` Felipe Balbi
2014-01-27 15:33 ` Felipe Balbi
2014-01-27 17:23 ` Sergei Shtylyov
2014-01-27 18:23 ` Sergei Shtylyov
2014-01-27 19:06 ` Ben Dooks
[not found] ` <52E6AE32.5050906-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-29 6:22 ` Simon Horman
2014-01-29 6:22 ` Simon Horman
[not found] ` <20140129062212.GD23833-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-29 10:41 ` Sergei Shtylyov
2014-01-29 10:41 ` Sergei Shtylyov
2014-01-29 12:22 ` Simon Horman
2014-01-29 12:22 ` Simon Horman
[not found] ` <20140129122202.GB26253-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-29 12:26 ` Sergei Shtylyov
2014-01-29 12:26 ` Sergei Shtylyov
[not found] ` <52E8F38F.9030609-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-01-29 12:35 ` Simon Horman
2014-01-29 12:35 ` Simon Horman
2014-01-26 16:49 ` [PATCH 6/8] phy-rcar-usb-gen2: add device tree documentation Ben Dooks
2014-01-26 19:07 ` Geert Uytterhoeven
2014-01-26 19:07 ` Geert Uytterhoeven
2014-01-26 16:49 ` [PATCH 7/8] ARM: shmobile: r8a7790.dtsi: add usbphy node Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E6A1B4.6060906@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.