From: Antti Palosaari <crope@iki.fi>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] tda10071: remove a duplicative test
Date: Thu, 30 Jan 2014 14:46:42 +0000 [thread overview]
Message-ID: <52EA65D2.90604@iki.fi> (raw)
In-Reply-To: <20140130120034.GA13267@elgon.mountain>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
I will query that to the kernel 3.15.
thanks
Antti
On 30.01.2014 14:00, Dan Carpenter wrote:
> "ret" is an error code here, we already tested that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/dvb-frontends/tda10071.c b/drivers/media/dvb-frontends/tda10071.c
> index 8ad3a57cf640..a76df29c4973 100644
> --- a/drivers/media/dvb-frontends/tda10071.c
> +++ b/drivers/media/dvb-frontends/tda10071.c
> @@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
> dev_err(&priv->i2c->dev, "%s: firmware " \
> "download failed=%d\n",
> KBUILD_MODNAME, ret);
> - if (ret)
> - goto error_release_firmware;
> + goto error_release_firmware;
> }
> }
> release_firmware(fw);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
http://palosaari.fi/
WARNING: multiple messages have this Message-ID (diff)
From: Antti Palosaari <crope@iki.fi>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] tda10071: remove a duplicative test
Date: Thu, 30 Jan 2014 16:46:42 +0200 [thread overview]
Message-ID: <52EA65D2.90604@iki.fi> (raw)
In-Reply-To: <20140130120034.GA13267@elgon.mountain>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
I will query that to the kernel 3.15.
thanks
Antti
On 30.01.2014 14:00, Dan Carpenter wrote:
> "ret" is an error code here, we already tested that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/dvb-frontends/tda10071.c b/drivers/media/dvb-frontends/tda10071.c
> index 8ad3a57cf640..a76df29c4973 100644
> --- a/drivers/media/dvb-frontends/tda10071.c
> +++ b/drivers/media/dvb-frontends/tda10071.c
> @@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
> dev_err(&priv->i2c->dev, "%s: firmware " \
> "download failed=%d\n",
> KBUILD_MODNAME, ret);
> - if (ret)
> - goto error_release_firmware;
> + goto error_release_firmware;
> }
> }
> release_firmware(fw);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-01-30 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 12:00 [patch] [media] tda10071: remove a duplicative test Dan Carpenter
2014-01-30 12:00 ` Dan Carpenter
2014-01-30 14:46 ` Antti Palosaari [this message]
2014-01-30 14:46 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA65D2.90604@iki.fi \
--to=crope@iki.fi \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.