* [patch] [media] tda10071: remove a duplicative test
@ 2014-01-30 12:00 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-01-30 12:00 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
"ret" is an error code here, we already tested that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb-frontends/tda10071.c b/drivers/media/dvb-frontends/tda10071.c
index 8ad3a57cf640..a76df29c4973 100644
--- a/drivers/media/dvb-frontends/tda10071.c
+++ b/drivers/media/dvb-frontends/tda10071.c
@@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
dev_err(&priv->i2c->dev, "%s: firmware " \
"download failed=%d\n",
KBUILD_MODNAME, ret);
- if (ret)
- goto error_release_firmware;
+ goto error_release_firmware;
}
}
release_firmware(fw);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] [media] tda10071: remove a duplicative test
@ 2014-01-30 12:00 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-01-30 12:00 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
"ret" is an error code here, we already tested that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb-frontends/tda10071.c b/drivers/media/dvb-frontends/tda10071.c
index 8ad3a57cf640..a76df29c4973 100644
--- a/drivers/media/dvb-frontends/tda10071.c
+++ b/drivers/media/dvb-frontends/tda10071.c
@@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
dev_err(&priv->i2c->dev, "%s: firmware " \
"download failed=%d\n",
KBUILD_MODNAME, ret);
- if (ret)
- goto error_release_firmware;
+ goto error_release_firmware;
}
}
release_firmware(fw);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] [media] tda10071: remove a duplicative test
2014-01-30 12:00 ` Dan Carpenter
@ 2014-01-30 14:46 ` Antti Palosaari
-1 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2014-01-30 14:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
I will query that to the kernel 3.15.
thanks
Antti
On 30.01.2014 14:00, Dan Carpenter wrote:
> "ret" is an error code here, we already tested that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/dvb-frontends/tda10071.c b/drivers/media/dvb-frontends/tda10071.c
> index 8ad3a57cf640..a76df29c4973 100644
> --- a/drivers/media/dvb-frontends/tda10071.c
> +++ b/drivers/media/dvb-frontends/tda10071.c
> @@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
> dev_err(&priv->i2c->dev, "%s: firmware " \
> "download failed=%d\n",
> KBUILD_MODNAME, ret);
> - if (ret)
> - goto error_release_firmware;
> + goto error_release_firmware;
> }
> }
> release_firmware(fw);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] [media] tda10071: remove a duplicative test
@ 2014-01-30 14:46 ` Antti Palosaari
0 siblings, 0 replies; 4+ messages in thread
From: Antti Palosaari @ 2014-01-30 14:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
I will query that to the kernel 3.15.
thanks
Antti
On 30.01.2014 14:00, Dan Carpenter wrote:
> "ret" is an error code here, we already tested that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/dvb-frontends/tda10071.c b/drivers/media/dvb-frontends/tda10071.c
> index 8ad3a57cf640..a76df29c4973 100644
> --- a/drivers/media/dvb-frontends/tda10071.c
> +++ b/drivers/media/dvb-frontends/tda10071.c
> @@ -1006,8 +1006,7 @@ static int tda10071_init(struct dvb_frontend *fe)
> dev_err(&priv->i2c->dev, "%s: firmware " \
> "download failed=%d\n",
> KBUILD_MODNAME, ret);
> - if (ret)
> - goto error_release_firmware;
> + goto error_release_firmware;
> }
> }
> release_firmware(fw);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-30 14:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 12:00 [patch] [media] tda10071: remove a duplicative test Dan Carpenter
2014-01-30 12:00 ` Dan Carpenter
2014-01-30 14:46 ` Antti Palosaari
2014-01-30 14:46 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.