[Qemu-trivial] [PULL 00/11] Trivial patches for 2014-01-16

[Qemu-trivial] [PULL 00/11] Trivial patches for 2014-01-16

[Michael Tokarev]

There's nothing exciting in there, but we have some small bugfixes here and
there, and a few cosmetic changes too.

This is my first signed pull request too, based on my regular GnuPG key which
I use to sign Debian packages.

Please pull.

Thanks,

/mjt

The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c:

  SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000)

are available in the git repository at:

  git://git.corpit.ru/qemu.git tags/trivial-patches-2014-01-16

for you to fetch changes up to 2c02d1ad48ad44cf00522df7d8de9138689fac85:

  vl: Add a blank space between the variable and '=' (2014-01-16 15:23:41 +0400)

----------------------------------------------------------------
trivial-patches for 2014-01-16

----------------------------------------------------------------
David du Colombier (1):
      ide: cmd_exec_dev_diagnostic() always set error register to 0x01

Eduardo Habkost (1):
      Add bios-256k.bin to BLOBS on Makefile

Kewei Yu (1):
      vl: Add a blank space between the variable and '='

Luiz Capitulino (1):
      virtio-balloon: don't hardcode config size value

Namhyung Kim (2):
      docs: Fix typo in QMP WAKEUP example
      Fix typo of tiemr in timer.h

Pavel Zbitskiy (3):
      linux-user: fixed s390x clone() argument order
      linux-user: fixed getsockopt() optlen
      linux-user: fixed recvfrom() addrlen

Stefan Weil (2):
      exec: Exclude non portable function for MinGW
      pc-bios: Remove execute flag from BIOS files

 Makefile                   |    2 +-
 docs/qmp/qmp-events.txt    |    2 +-
 hw/ide/core.c              |    1 +
 hw/virtio/virtio-balloon.c |    7 ++++---
 include/exec/ram_addr.h    |    2 ++
 include/qemu/timer.h       |    6 +++---
 linux-user/s390x/syscall.h |    2 +-
 linux-user/syscall.c       |    4 ++--
 pc-bios/kvmvapic.bin       |  Bin 9216 -> 9216 bytes
 pc-bios/multiboot.bin      |  Bin 1024 -> 1024 bytes
 pc-bios/sgabios.bin        |  Bin 4096 -> 4096 bytes
 vl.c                       |    2 +-
 12 files changed, 16 insertions(+), 12 deletions(-)
 mode change 100755 => 100644 pc-bios/kvmvapic.bin
 mode change 100755 => 100644 pc-bios/multiboot.bin
 mode change 100755 => 100644 pc-bios/sgabios.bin

[Qemu-devel] [PULL 00/11] Trivial patches for 2014-01-16

[Michael Tokarev]

There's nothing exciting in there, but we have some small bugfixes here and
there, and a few cosmetic changes too.

This is my first signed pull request too, based on my regular GnuPG key which
I use to sign Debian packages.

Please pull.

Thanks,

/mjt

The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c:

  SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000)

are available in the git repository at:

  git://git.corpit.ru/qemu.git tags/trivial-patches-2014-01-16

for you to fetch changes up to 2c02d1ad48ad44cf00522df7d8de9138689fac85:

  vl: Add a blank space between the variable and '=' (2014-01-16 15:23:41 +0400)

----------------------------------------------------------------
trivial-patches for 2014-01-16

----------------------------------------------------------------
David du Colombier (1):
      ide: cmd_exec_dev_diagnostic() always set error register to 0x01

Eduardo Habkost (1):
      Add bios-256k.bin to BLOBS on Makefile

Kewei Yu (1):
      vl: Add a blank space between the variable and '='

Luiz Capitulino (1):
      virtio-balloon: don't hardcode config size value

Namhyung Kim (2):
      docs: Fix typo in QMP WAKEUP example
      Fix typo of tiemr in timer.h

Pavel Zbitskiy (3):
      linux-user: fixed s390x clone() argument order
      linux-user: fixed getsockopt() optlen
      linux-user: fixed recvfrom() addrlen

Stefan Weil (2):
      exec: Exclude non portable function for MinGW
      pc-bios: Remove execute flag from BIOS files

 Makefile                   |    2 +-
 docs/qmp/qmp-events.txt    |    2 +-
 hw/ide/core.c              |    1 +
 hw/virtio/virtio-balloon.c |    7 ++++---
 include/exec/ram_addr.h    |    2 ++
 include/qemu/timer.h       |    6 +++---
 linux-user/s390x/syscall.h |    2 +-
 linux-user/syscall.c       |    4 ++--
 pc-bios/kvmvapic.bin       |  Bin 9216 -> 9216 bytes
 pc-bios/multiboot.bin      |  Bin 1024 -> 1024 bytes
 pc-bios/sgabios.bin        |  Bin 4096 -> 4096 bytes
 vl.c                       |    2 +-
 12 files changed, 16 insertions(+), 12 deletions(-)
 mode change 100755 => 100644 pc-bios/kvmvapic.bin
 mode change 100755 => 100644 pc-bios/multiboot.bin
 mode change 100755 => 100644 pc-bios/sgabios.bin

[Qemu-trivial] [PULL 01/11] docs: Fix typo in QMP WAKEUP example

[Michael Tokarev]

From: Namhyung Kim <namhyung@gmail.com>

Cc: qemu-trivial@nongnu.org
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 docs/qmp/qmp-events.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
index 6b87e97..a378c87 100644
--- a/docs/qmp/qmp-events.txt
+++ b/docs/qmp/qmp-events.txt
@@ -479,7 +479,7 @@ Data: None.
 
 Example:
 
-{ "event": "WATCHDOG",
+{ "event": "WAKEUP",
      "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
 
 WATCHDOG
-- 
1.7.10.4

[Qemu-devel] [PULL 01/11] docs: Fix typo in QMP WAKEUP example

[Michael Tokarev]

From: Namhyung Kim <namhyung@gmail.com>

Cc: qemu-trivial@nongnu.org
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 docs/qmp/qmp-events.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
index 6b87e97..a378c87 100644
--- a/docs/qmp/qmp-events.txt
+++ b/docs/qmp/qmp-events.txt
@@ -479,7 +479,7 @@ Data: None.
 
 Example:
 
-{ "event": "WATCHDOG",
+{ "event": "WAKEUP",
      "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
 
 WATCHDOG
-- 
1.7.10.4

[Qemu-trivial] [PULL 02/11] Fix typo of tiemr in timer.h

[Michael Tokarev]

From: Namhyung Kim <namhyung@gmail.com>

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/qemu/timer.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index 5afcffc..7f9a074 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -405,7 +405,7 @@ int64_t timerlistgroup_deadline_ns(QEMUTimerListGroup *tlg);
  * timer_init:
  * @ts: the timer to be initialised
  * @timer_list: the timer list to attach the timer to
- * @scale: the scale value for the tiemr
+ * @scale: the scale value for the timer
  * @cb: the callback to be called when the timer expires
  * @opaque: the opaque pointer to be passed to the callback
  *
@@ -422,7 +422,7 @@ void timer_init(QEMUTimer *ts,
 /**
  * timer_new_tl:
  * @timer_list: the timer list to attach the timer to
- * @scale: the scale value for the tiemr
+ * @scale: the scale value for the timer
  * @cb: the callback to be called when the timer expires
  * @opaque: the opaque pointer to be passed to the callback
  *
@@ -447,7 +447,7 @@ static inline QEMUTimer *timer_new_tl(QEMUTimerList *timer_list,
 /**
  * timer_new:
  * @type: the clock type to use
- * @scale: the scale value for the tiemr
+ * @scale: the scale value for the timer
  * @cb: the callback to be called when the timer expires
  * @opaque: the opaque pointer to be passed to the callback
  *
-- 
1.7.10.4

[Qemu-devel] [PULL 02/11] Fix typo of tiemr in timer.h

[Michael Tokarev]

From: Namhyung Kim <namhyung@gmail.com>

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/qemu/timer.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index 5afcffc..7f9a074 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -405,7 +405,7 @@ int64_t timerlistgroup_deadline_ns(QEMUTimerListGroup *tlg);
  * timer_init:
  * @ts: the timer to be initialised
  * @timer_list: the timer list to attach the timer to
- * @scale: the scale value for the tiemr
+ * @scale: the scale value for the timer
  * @cb: the callback to be called when the timer expires
  * @opaque: the opaque pointer to be passed to the callback
  *
@@ -422,7 +422,7 @@ void timer_init(QEMUTimer *ts,
 /**
  * timer_new_tl:
  * @timer_list: the timer list to attach the timer to
- * @scale: the scale value for the tiemr
+ * @scale: the scale value for the timer
  * @cb: the callback to be called when the timer expires
  * @opaque: the opaque pointer to be passed to the callback
  *
@@ -447,7 +447,7 @@ static inline QEMUTimer *timer_new_tl(QEMUTimerList *timer_list,
 /**
  * timer_new:
  * @type: the clock type to use
- * @scale: the scale value for the tiemr
+ * @scale: the scale value for the timer
  * @cb: the callback to be called when the timer expires
  * @opaque: the opaque pointer to be passed to the callback
  *
-- 
1.7.10.4

[Qemu-trivial] [PULL 03/11] Add bios-256k.bin to BLOBS on Makefile

[Michael Tokarev]

From: Eduardo Habkost <ehabkost@redhat.com>

The default machine-type (pc-i440fx-2.0) now requires bios-256k.bin, but
"make install" isn't installing it, so qemu-system-x86_64 won't run out
of the box. Add it to BLOBS so it gets installed.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: William Dauchy <william@gandi.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bdff4e4..807054b 100644
--- a/Makefile
+++ b/Makefile
@@ -290,7 +290,7 @@ common  de-ch  es     fo  fr-ca  hu     ja  mk  nl-be      pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \
 acpi-dsdt.aml q35-acpi-dsdt.aml \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin \
-- 
1.7.10.4

[Qemu-devel] [PULL 03/11] Add bios-256k.bin to BLOBS on Makefile

[Michael Tokarev]

From: Eduardo Habkost <ehabkost@redhat.com>

The default machine-type (pc-i440fx-2.0) now requires bios-256k.bin, but
"make install" isn't installing it, so qemu-system-x86_64 won't run out
of the box. Add it to BLOBS so it gets installed.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: William Dauchy <william@gandi.net>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bdff4e4..807054b 100644
--- a/Makefile
+++ b/Makefile
@@ -290,7 +290,7 @@ common  de-ch  es     fo  fr-ca  hu     ja  mk  nl-be      pt  sl     tr \
 bepo    cz
 
 ifdef INSTALL_BLOBS
-BLOBS=bios.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \
 acpi-dsdt.aml q35-acpi-dsdt.aml \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin \
-- 
1.7.10.4

[Qemu-trivial] [PULL 04/11] exec: Exclude non portable function for MinGW

[Michael Tokarev]

From: Stefan Weil <sw@weilnetz.de>

cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are
unavailable for MinGW. As the function is unused for MinGW, it can simply
be excluded from compilation.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/exec/ram_addr.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index 33c8acc..481a447 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr.h
@@ -79,6 +79,7 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
     xen_modified_memory(start, length);
 }
 
+#if !defined(_WIN32)
 static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap,
                                                           ram_addr_t start,
                                                           ram_addr_t pages)
@@ -127,6 +128,7 @@ static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap,
         }
     }
 }
+#endif /* not _WIN32 */
 
 static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start,
                                                          ram_addr_t length,
-- 
1.7.10.4

[Qemu-devel] [PULL 04/11] exec: Exclude non portable function for MinGW

[Michael Tokarev]

From: Stefan Weil <sw@weilnetz.de>

cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are
unavailable for MinGW. As the function is unused for MinGW, it can simply
be excluded from compilation.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/exec/ram_addr.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index 33c8acc..481a447 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr.h
@@ -79,6 +79,7 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
     xen_modified_memory(start, length);
 }
 
+#if !defined(_WIN32)
 static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap,
                                                           ram_addr_t start,
                                                           ram_addr_t pages)
@@ -127,6 +128,7 @@ static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap,
         }
     }
 }
+#endif /* not _WIN32 */
 
 static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start,
                                                          ram_addr_t length,
-- 
1.7.10.4

[Qemu-trivial] [PULL 05/11] virtio-balloon: don't hardcode config size value

[Michael Tokarev]

From: Luiz Capitulino <lcapitulino@redhat.com>

Use sizeof(struct virtio_balloon_config) instead.

Signed-off-by: Luiz capitulino <lcapitulino@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/virtio/virtio-balloon.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index d9754db..a470a0b 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -263,7 +263,7 @@ static void virtio_balloon_get_config(VirtIODevice *vdev, uint8_t *config_data)
     config.num_pages = cpu_to_le32(dev->num_pages);
     config.actual = cpu_to_le32(dev->actual);
 
-    memcpy(config_data, &config, 8);
+    memcpy(config_data, &config, sizeof(struct virtio_balloon_config));
 }
 
 static void virtio_balloon_set_config(VirtIODevice *vdev,
@@ -272,7 +272,7 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
     VirtIOBalloon *dev = VIRTIO_BALLOON(vdev);
     struct virtio_balloon_config config;
     uint32_t oldactual = dev->actual;
-    memcpy(&config, config_data, 8);
+    memcpy(&config, config_data, sizeof(struct virtio_balloon_config));
     dev->actual = le32_to_cpu(config.actual);
     if (dev->actual != oldactual) {
         qemu_balloon_changed(ram_size -
@@ -343,7 +343,8 @@ static void virtio_balloon_device_realize(DeviceState *dev, Error **errp)
     VirtIOBalloon *s = VIRTIO_BALLOON(dev);
     int ret;
 
-    virtio_init(vdev, "virtio-balloon", VIRTIO_ID_BALLOON, 8);
+    virtio_init(vdev, "virtio-balloon", VIRTIO_ID_BALLOON,
+                sizeof(struct virtio_balloon_config));
 
     ret = qemu_add_balloon_handler(virtio_balloon_to_target,
                                    virtio_balloon_stat, s);
-- 
1.7.10.4

[Qemu-devel] [PULL 05/11] virtio-balloon: don't hardcode config size value

[Michael Tokarev]

From: Luiz Capitulino <lcapitulino@redhat.com>

Use sizeof(struct virtio_balloon_config) instead.

Signed-off-by: Luiz capitulino <lcapitulino@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/virtio/virtio-balloon.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index d9754db..a470a0b 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -263,7 +263,7 @@ static void virtio_balloon_get_config(VirtIODevice *vdev, uint8_t *config_data)
     config.num_pages = cpu_to_le32(dev->num_pages);
     config.actual = cpu_to_le32(dev->actual);
 
-    memcpy(config_data, &config, 8);
+    memcpy(config_data, &config, sizeof(struct virtio_balloon_config));
 }
 
 static void virtio_balloon_set_config(VirtIODevice *vdev,
@@ -272,7 +272,7 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
     VirtIOBalloon *dev = VIRTIO_BALLOON(vdev);
     struct virtio_balloon_config config;
     uint32_t oldactual = dev->actual;
-    memcpy(&config, config_data, 8);
+    memcpy(&config, config_data, sizeof(struct virtio_balloon_config));
     dev->actual = le32_to_cpu(config.actual);
     if (dev->actual != oldactual) {
         qemu_balloon_changed(ram_size -
@@ -343,7 +343,8 @@ static void virtio_balloon_device_realize(DeviceState *dev, Error **errp)
     VirtIOBalloon *s = VIRTIO_BALLOON(dev);
     int ret;
 
-    virtio_init(vdev, "virtio-balloon", VIRTIO_ID_BALLOON, 8);
+    virtio_init(vdev, "virtio-balloon", VIRTIO_ID_BALLOON,
+                sizeof(struct virtio_balloon_config));
 
     ret = qemu_add_balloon_handler(virtio_balloon_to_target,
                                    virtio_balloon_stat, s);
-- 
1.7.10.4

[Qemu-trivial] [PULL 06/11] ide: cmd_exec_dev_diagnostic() always set error register to 0x01

[Michael Tokarev]

From: David du Colombier <0intro@gmail.com>

This notably fix IDE CD probing on the Plan 9 operating system,
which rely on the error register set by the Execute Device
Diagnostic command to detect drive configurations.

Thanks to Rémi Pommarel for reporting this issue.

Signed-off-by: David du Colombier <0intro@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/ide/core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index e1f4c33..7783d58 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1321,6 +1321,7 @@ static bool cmd_exec_dev_diagnostic(IDEState *s, uint8_t cmd)
         s->status = 0; /* ATAPI spec (v6) section 9.10 defines packet
                         * devices to return a clear status register
                         * with READY_STAT *not* set. */
+        s->error = 0x01;
     } else {
         s->status = READY_STAT | SEEK_STAT;
         /* The bits of the error register are not as usual for this command!
-- 
1.7.10.4

[Qemu-devel] [PULL 06/11] ide: cmd_exec_dev_diagnostic() always set error register to 0x01

[Michael Tokarev]

From: David du Colombier <0intro@gmail.com>

This notably fix IDE CD probing on the Plan 9 operating system,
which rely on the error register set by the Execute Device
Diagnostic command to detect drive configurations.

Thanks to Rémi Pommarel for reporting this issue.

Signed-off-by: David du Colombier <0intro@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/ide/core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index e1f4c33..7783d58 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1321,6 +1321,7 @@ static bool cmd_exec_dev_diagnostic(IDEState *s, uint8_t cmd)
         s->status = 0; /* ATAPI spec (v6) section 9.10 defines packet
                         * devices to return a clear status register
                         * with READY_STAT *not* set. */
+        s->error = 0x01;
     } else {
         s->status = READY_STAT | SEEK_STAT;
         /* The bits of the error register are not as usual for this command!
-- 
1.7.10.4

[Qemu-trivial] [PULL 07/11] linux-user: fixed s390x clone() argument order

[Michael Tokarev]

From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db,
where TARGET_CLONE_BACKWARDS was specified instead of
TARGET_CLONE_BACKWARDS2.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/s390x/syscall.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/s390x/syscall.h b/linux-user/s390x/syscall.h
index ea8c304..e5ce30b 100644
--- a/linux-user/s390x/syscall.h
+++ b/linux-user/s390x/syscall.h
@@ -22,4 +22,4 @@ struct target_pt_regs {
 
 #define UNAME_MACHINE "s390x"
 
-#define TARGET_CLONE_BACKWARDS
+#define TARGET_CLONE_BACKWARDS2
-- 
1.7.10.4

[Qemu-devel] [PULL 07/11] linux-user: fixed s390x clone() argument order

[Michael Tokarev]

From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db,
where TARGET_CLONE_BACKWARDS was specified instead of
TARGET_CLONE_BACKWARDS2.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/s390x/syscall.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/s390x/syscall.h b/linux-user/s390x/syscall.h
index ea8c304..e5ce30b 100644
--- a/linux-user/s390x/syscall.h
+++ b/linux-user/s390x/syscall.h
@@ -22,4 +22,4 @@ struct target_pt_regs {
 
 #define UNAME_MACHINE "s390x"
 
-#define TARGET_CLONE_BACKWARDS
+#define TARGET_CLONE_BACKWARDS2
-- 
1.7.10.4

[Qemu-trivial] [PULL 08/11] linux-user: fixed getsockopt() optlen

[Michael Tokarev]

From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

optlen parameter of getsockopt() of type socklen_t* was read into
variable of type socklen_t, that caused zeroing out of upper 4 bytes
when running s390x on top of x86_64. This patch changes optlen type
to abi_ulong.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/syscall.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 0ac05b8..a9ce6ba 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2406,7 +2406,7 @@ static abi_long do_socketcall(int num, abi_ulong vptr)
             abi_ulong level;
             abi_ulong optname;
             abi_ulong optval;
-            socklen_t optlen;
+            abi_ulong optlen;
 
             if (get_user_ual(sockfd, vptr)
                 || get_user_ual(level, vptr + n)
-- 
1.7.10.4

[Qemu-devel] [PULL 08/11] linux-user: fixed getsockopt() optlen

[Michael Tokarev]

From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

optlen parameter of getsockopt() of type socklen_t* was read into
variable of type socklen_t, that caused zeroing out of upper 4 bytes
when running s390x on top of x86_64. This patch changes optlen type
to abi_ulong.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/syscall.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 0ac05b8..a9ce6ba 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2406,7 +2406,7 @@ static abi_long do_socketcall(int num, abi_ulong vptr)
             abi_ulong level;
             abi_ulong optname;
             abi_ulong optval;
-            socklen_t optlen;
+            abi_ulong optlen;
 
             if (get_user_ual(sockfd, vptr)
                 || get_user_ual(level, vptr + n)
-- 
1.7.10.4

[Qemu-trivial] [PULL 09/11] linux-user: fixed recvfrom() addrlen

[Michael Tokarev]

From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

addrlen parameter of recvfrom() of type socklen_t* was read into
variable of type socklen_t, that caused zeroing out of upper 4 bytes
when running s390x on top of x86_64. This patch changes addrlen type
to abi_ulong.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/syscall.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a9ce6ba..bc0ac98 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2340,7 +2340,7 @@ static abi_long do_socketcall(int num, abi_ulong vptr)
             size_t len;
             abi_ulong flags;
             abi_ulong addr;
-            socklen_t addrlen;
+            abi_ulong addrlen;
 
             if (get_user_ual(sockfd, vptr)
                 || get_user_ual(msg, vptr + n)
-- 
1.7.10.4

[Qemu-devel] [PULL 09/11] linux-user: fixed recvfrom() addrlen

[Michael Tokarev]

From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

addrlen parameter of recvfrom() of type socklen_t* was read into
variable of type socklen_t, that caused zeroing out of upper 4 bytes
when running s390x on top of x86_64. This patch changes addrlen type
to abi_ulong.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/syscall.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a9ce6ba..bc0ac98 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2340,7 +2340,7 @@ static abi_long do_socketcall(int num, abi_ulong vptr)
             size_t len;
             abi_ulong flags;
             abi_ulong addr;
-            socklen_t addrlen;
+            abi_ulong addrlen;
 
             if (get_user_ual(sockfd, vptr)
                 || get_user_ual(msg, vptr + n)
-- 
1.7.10.4

[Qemu-trivial] [PULL 10/11] pc-bios: Remove execute flag from BIOS files

[Michael Tokarev]

From: Stefan Weil <sw@weilnetz.de>

BIOS files are not directly executable, so they don't need this flag.
All other BIOS files don't use the execute flag.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 pc-bios/kvmvapic.bin  |  Bin 9216 -> 9216 bytes
 pc-bios/multiboot.bin |  Bin 1024 -> 1024 bytes
 pc-bios/sgabios.bin   |  Bin 4096 -> 4096 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 pc-bios/kvmvapic.bin
 mode change 100755 => 100644 pc-bios/multiboot.bin
 mode change 100755 => 100644 pc-bios/sgabios.bin

diff --git a/pc-bios/kvmvapic.bin b/pc-bios/kvmvapic.bin
old mode 100755
new mode 100644
diff --git a/pc-bios/multiboot.bin b/pc-bios/multiboot.bin
old mode 100755
new mode 100644
diff --git a/pc-bios/sgabios.bin b/pc-bios/sgabios.bin
old mode 100755
new mode 100644
-- 
1.7.10.4

[Qemu-devel] [PULL 10/11] pc-bios: Remove execute flag from BIOS files

[Michael Tokarev]

From: Stefan Weil <sw@weilnetz.de>

BIOS files are not directly executable, so they don't need this flag.
All other BIOS files don't use the execute flag.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 pc-bios/kvmvapic.bin  |  Bin 9216 -> 9216 bytes
 pc-bios/multiboot.bin |  Bin 1024 -> 1024 bytes
 pc-bios/sgabios.bin   |  Bin 4096 -> 4096 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 pc-bios/kvmvapic.bin
 mode change 100755 => 100644 pc-bios/multiboot.bin
 mode change 100755 => 100644 pc-bios/sgabios.bin

diff --git a/pc-bios/kvmvapic.bin b/pc-bios/kvmvapic.bin
old mode 100755
new mode 100644
diff --git a/pc-bios/multiboot.bin b/pc-bios/multiboot.bin
old mode 100755
new mode 100644
diff --git a/pc-bios/sgabios.bin b/pc-bios/sgabios.bin
old mode 100755
new mode 100644
-- 
1.7.10.4

[Qemu-trivial] [PULL 11/11] vl: Add a blank space between the variable and '='

[Michael Tokarev]

From: Kewei Yu <keweihk@gmail.com>

Signed-off-by: Kewei Yu <keweihk@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 vl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index 7f4fe0d..2b47866 100644
--- a/vl.c
+++ b/vl.c
@@ -2925,7 +2925,7 @@ int main(int argc, char **argv, char **envp)
 
     bdrv_init_with_whitelist();
 
-    autostart= 1;
+    autostart = 1;
 
     /* first pass of option parsing */
     optind = 1;
-- 
1.7.10.4

[Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

[Michael Tokarev]

From: Kewei Yu <keweihk@gmail.com>

Signed-off-by: Kewei Yu <keweihk@gmail.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 vl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index 7f4fe0d..2b47866 100644
--- a/vl.c
+++ b/vl.c
@@ -2925,7 +2925,7 @@ int main(int argc, char **argv, char **envp)
 
     bdrv_init_with_whitelist();
 
-    autostart= 1;
+    autostart = 1;
 
     /* first pass of option parsing */
     optind = 1;
-- 
1.7.10.4

Re: [Qemu-trivial] [PULL 11/11] vl: Add a blank space between the variable and '='

[Kewei Yu]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Thanks, I will send patch with prefix to indicate which file of the
codebase after this.

Regard
Kewei


2014/1/17 Michael Tokarev <mjt@tls.msk.ru>

> From: Kewei Yu <keweihk@gmail.com>
>
> Signed-off-by: Kewei Yu <keweihk@gmail.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  vl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 7f4fe0d..2b47866 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2925,7 +2925,7 @@ int main(int argc, char **argv, char **envp)
>
>      bdrv_init_with_whitelist();
>
> -    autostart= 1;
> +    autostart = 1;
>
>      /* first pass of option parsing */
>      optind = 1;
> --
> 1.7.10.4
>
>

[-- Attachment #2: Type: text/html, Size: 1526 bytes --]

Re: [Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

[Kewei Yu]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Thanks, I will send patch with prefix to indicate which file of the
codebase after this.

Regard
Kewei


2014/1/17 Michael Tokarev <mjt@tls.msk.ru>

> From: Kewei Yu <keweihk@gmail.com>
>
> Signed-off-by: Kewei Yu <keweihk@gmail.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  vl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 7f4fe0d..2b47866 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2925,7 +2925,7 @@ int main(int argc, char **argv, char **envp)
>
>      bdrv_init_with_whitelist();
>
> -    autostart= 1;
> +    autostart = 1;
>
>      /* first pass of option parsing */
>      optind = 1;
> --
> 1.7.10.4
>
>

[-- Attachment #2: Type: text/html, Size: 1526 bytes --]

Re: [Qemu-trivial] [PULL 11/11] vl: Add a blank space between the variable and '='

[Michael Tokarev]

17.01.2014 10:04, Kewei Yu пишет:
> Thanks, I will send patch with prefix to indicate which file of the codebase after this.

I already fixed it when applying, see http://git.corpit.ru/?p=qemu.git;h=2c02d1ad48ad44cf00522df7d8de9138689fac85

/mjt

Re: [Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

[Michael Tokarev]

17.01.2014 10:04, Kewei Yu пишет:
> Thanks, I will send patch with prefix to indicate which file of the codebase after this.

I already fixed it when applying, see http://git.corpit.ru/?p=qemu.git;h=2c02d1ad48ad44cf00522df7d8de9138689fac85

/mjt

Re: [Qemu-trivial] [PULL 00/11] Trivial patches for 2014-01-16

[Michael Tokarev]

Ping?

We've a few more patches in the queue, should I drop the ones from previous
week?

Thanks,

/mjt

16.01.2014 21:35, Michael Tokarev wrote:
> There's nothing exciting in there, but we have some small bugfixes here and
> there, and a few cosmetic changes too.
> 
> This is my first signed pull request too, based on my regular GnuPG key which
> I use to sign Debian packages.
> 
> Please pull.
> 
> Thanks,
> 
> /mjt
> 
> The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c:
> 
>   SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000)
> 
> are available in the git repository at:
> 
>   git://git.corpit.ru/qemu.git tags/trivial-patches-2014-01-16
> 
> for you to fetch changes up to 2c02d1ad48ad44cf00522df7d8de9138689fac85:
> 
>   vl: Add a blank space between the variable and '=' (2014-01-16 15:23:41 +0400)
> 
> ----------------------------------------------------------------
> trivial-patches for 2014-01-16
> 
> ----------------------------------------------------------------
> David du Colombier (1):
>       ide: cmd_exec_dev_diagnostic() always set error register to 0x01
> 
> Eduardo Habkost (1):
>       Add bios-256k.bin to BLOBS on Makefile
> 
> Kewei Yu (1):
>       vl: Add a blank space between the variable and '='
> 
> Luiz Capitulino (1):
>       virtio-balloon: don't hardcode config size value
> 
> Namhyung Kim (2):
>       docs: Fix typo in QMP WAKEUP example
>       Fix typo of tiemr in timer.h
> 
> Pavel Zbitskiy (3):
>       linux-user: fixed s390x clone() argument order
>       linux-user: fixed getsockopt() optlen
>       linux-user: fixed recvfrom() addrlen
> 
> Stefan Weil (2):
>       exec: Exclude non portable function for MinGW
>       pc-bios: Remove execute flag from BIOS files
> 
>  Makefile                   |    2 +-
>  docs/qmp/qmp-events.txt    |    2 +-
>  hw/ide/core.c              |    1 +
>  hw/virtio/virtio-balloon.c |    7 ++++---
>  include/exec/ram_addr.h    |    2 ++
>  include/qemu/timer.h       |    6 +++---
>  linux-user/s390x/syscall.h |    2 +-
>  linux-user/syscall.c       |    4 ++--
>  pc-bios/kvmvapic.bin       |  Bin 9216 -> 9216 bytes
>  pc-bios/multiboot.bin      |  Bin 1024 -> 1024 bytes
>  pc-bios/sgabios.bin        |  Bin 4096 -> 4096 bytes
>  vl.c                       |    2 +-
>  12 files changed, 16 insertions(+), 12 deletions(-)
>  mode change 100755 => 100644 pc-bios/kvmvapic.bin
>  mode change 100755 => 100644 pc-bios/multiboot.bin
>  mode change 100755 => 100644 pc-bios/sgabios.bin
> 

Re: [Qemu-devel] [Qemu-trivial] [PULL 00/11] Trivial patches for 2014-01-16

[Michael Tokarev]

Ping?

We've a few more patches in the queue, should I drop the ones from previous
week?

Thanks,

/mjt

16.01.2014 21:35, Michael Tokarev wrote:
> There's nothing exciting in there, but we have some small bugfixes here and
> there, and a few cosmetic changes too.
> 
> This is my first signed pull request too, based on my regular GnuPG key which
> I use to sign Debian packages.
> 
> Please pull.
> 
> Thanks,
> 
> /mjt
> 
> The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c:
> 
>   SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000)
> 
> are available in the git repository at:
> 
>   git://git.corpit.ru/qemu.git tags/trivial-patches-2014-01-16
> 
> for you to fetch changes up to 2c02d1ad48ad44cf00522df7d8de9138689fac85:
> 
>   vl: Add a blank space between the variable and '=' (2014-01-16 15:23:41 +0400)
> 
> ----------------------------------------------------------------
> trivial-patches for 2014-01-16
> 
> ----------------------------------------------------------------
> David du Colombier (1):
>       ide: cmd_exec_dev_diagnostic() always set error register to 0x01
> 
> Eduardo Habkost (1):
>       Add bios-256k.bin to BLOBS on Makefile
> 
> Kewei Yu (1):
>       vl: Add a blank space between the variable and '='
> 
> Luiz Capitulino (1):
>       virtio-balloon: don't hardcode config size value
> 
> Namhyung Kim (2):
>       docs: Fix typo in QMP WAKEUP example
>       Fix typo of tiemr in timer.h
> 
> Pavel Zbitskiy (3):
>       linux-user: fixed s390x clone() argument order
>       linux-user: fixed getsockopt() optlen
>       linux-user: fixed recvfrom() addrlen
> 
> Stefan Weil (2):
>       exec: Exclude non portable function for MinGW
>       pc-bios: Remove execute flag from BIOS files
> 
>  Makefile                   |    2 +-
>  docs/qmp/qmp-events.txt    |    2 +-
>  hw/ide/core.c              |    1 +
>  hw/virtio/virtio-balloon.c |    7 ++++---
>  include/exec/ram_addr.h    |    2 ++
>  include/qemu/timer.h       |    6 +++---
>  linux-user/s390x/syscall.h |    2 +-
>  linux-user/syscall.c       |    4 ++--
>  pc-bios/kvmvapic.bin       |  Bin 9216 -> 9216 bytes
>  pc-bios/multiboot.bin      |  Bin 1024 -> 1024 bytes
>  pc-bios/sgabios.bin        |  Bin 4096 -> 4096 bytes
>  vl.c                       |    2 +-
>  12 files changed, 16 insertions(+), 12 deletions(-)
>  mode change 100755 => 100644 pc-bios/kvmvapic.bin
>  mode change 100755 => 100644 pc-bios/multiboot.bin
>  mode change 100755 => 100644 pc-bios/sgabios.bin
> 

Re: [Qemu-trivial] [Qemu-devel] [PULL 00/11] Trivial patches for 2014-01-16

[Peter Maydell]

On 16 January 2014 17:35, Michael Tokarev <mjt@tls.msk.ru> wrote:
> There's nothing exciting in there, but we have some small bugfixes here and
> there, and a few cosmetic changes too.
>
> This is my first signed pull request too, based on my regular GnuPG key which
> I use to sign Debian packages.
>
> Please pull.

Thanks, applied. You'll see that gpg is a bit alarmist in
the merge commit message because we don't have a strong enough
web of trust between us yet (see also commit 4cddc7f44 for
earlier instances of that in our history).

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/11] Trivial patches for 2014-01-16

[Peter Maydell]

On 16 January 2014 17:35, Michael Tokarev <mjt@tls.msk.ru> wrote:
> There's nothing exciting in there, but we have some small bugfixes here and
> there, and a few cosmetic changes too.
>
> This is my first signed pull request too, based on my regular GnuPG key which
> I use to sign Debian packages.
>
> Please pull.

Thanks, applied. You'll see that gpg is a bit alarmist in
the merge commit message because we don't have a strong enough
web of trust between us yet (see also commit 4cddc7f44 for
earlier instances of that in our history).

thanks
-- PMM

[Qemu-devel] Signed pull requests (was: Re: [PULL 00/11] Trivial patches for 2014-01-16)

[Stefan Weil]

Am 30.01.2014 15:33, schrieb Peter Maydell:
> On 16 January 2014 17:35, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> There's nothing exciting in there, but we have some small bugfixes here and
>> there, and a few cosmetic changes too.
>>
>> This is my first signed pull request too, based on my regular GnuPG key which
>> I use to sign Debian packages.
>>
>> Please pull.
> Thanks, applied. You'll see that gpg is a bit alarmist in
> the merge commit message because we don't have a strong enough
> web of trust between us yet (see also commit 4cddc7f44 for
> earlier instances of that in our history).
>
> thanks
> -- PMM

Never mind. Up to now, only Andreas' and Michael's signatures were
checked by gpg, and neither of these two were trusted. :-)

If you look for the output of "git log | grep gpg:", you'll see that in
the remaining 68 cases, gpg did not find the public keys (which normally
are available from public key servers).

My own signature should also be available from public key servers, and
it is also signed by CAcert. We can exchange more information via
private e-mail if needed for the web of trust.

Regards
Stefan

Re: [Qemu-devel] Signed pull requests (was: Re: [PULL 00/11] Trivial patches for 2014-01-16)

[Peter Maydell]

On 30 January 2014 21:45, Stefan Weil <sw@weilnetz.de> wrote:
> Am 30.01.2014 15:33, schrieb Peter Maydell:
>> On 16 January 2014 17:35, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>> There's nothing exciting in there, but we have some small bugfixes here and
>>> there, and a few cosmetic changes too.
>>>
>>> This is my first signed pull request too, based on my regular GnuPG key which
>>> I use to sign Debian packages.
>>>
>>> Please pull.
>> Thanks, applied. You'll see that gpg is a bit alarmist in
>> the merge commit message because we don't have a strong enough
>> web of trust between us yet (see also commit 4cddc7f44 for
>> earlier instances of that in our history).

> Never mind. Up to now, only Andreas' and Michael's signatures were
> checked by gpg, and neither of these two were trusted. :-)

We're also still accepting unsigned pull requests at the moment.
(I guess that moving to "all pull requests are signed even if the
key isn't trusted" is probably a useful step forward in getting
everybody's workflow set up right.)

> If you look for the output of "git log | grep gpg:", you'll see that in
> the remaining 68 cases, gpg did not find the public keys (which normally
> are available from public key servers).

Yes. I could have deleted mjt's untrusted key from my keyring
to produce the other error message; I didn't think that was worth
the effort :-)

The handful of people whose keys I signed after KVM Forum
last year will find the git commit message looks prettier.
(I'd have made a greater effort to sign more keys if I'd known
at the time I was going to be a committer.)

> My own signature should also be available from public key servers, and
> it is also signed by CAcert. We can exchange more information via
> private e-mail if needed for the web of trust.

If anybody wants to suggest guidelines for what we should
consider a "trusted" key [and whatever the gpg config for
that would be], feel free; otherwise since I think
neither Anthony nor I are gpg gurus we're likely to end up
with "whatever gpg does by default" plus the "only sign
keys where you've seen the person and their official photo
ID" type rules from last year's keysigning.

thanks
-- PMM

Re: [Qemu-devel] Signed pull requests

[Markus Armbruster]

Peter Maydell <peter.maydell@linaro.org> writes:

[...]
> The handful of people whose keys I signed after KVM Forum
> last year will find the git commit message looks prettier.
> (I'd have made a greater effort to sign more keys if I'd known
> at the time I was going to be a committer.)

I suspect many of the keys examined there have not actually been
signed, because Anthony failed to follow up as promised.  Sad.

[...]