All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc3: keystone: switch to use runtime pm
Date: Fri, 31 Jan 2014 10:50:40 -0500	[thread overview]
Message-ID: <52EBC650.50305@ti.com> (raw)
In-Reply-To: <20140131154721.GD20736@saruman.home>

On Friday 31 January 2014 10:47 AM, Felipe Balbi wrote:
> On Fri, Jan 31, 2014 at 10:43:21AM -0500, Santosh Shilimkar wrote:
>> On Friday 31 January 2014 10:19 AM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Fri, Jan 31, 2014 at 03:20:26PM +0200, Grygorii Strashko wrote:
>>>> The Keystone PM management layer has been implemented using PM bus for
>>>> power management clocks. As result, most of Keystone drivers don't need
>>>> to manage clocks directly. They just need to enable runtime PM and use it
>>>> to handle their PM state and clocks.
>>>>
>>>> Hence, remove clock management code and switch to use runtime PM.
>>>>
>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>
>>> quite a few weeks back I sent a series enabling runtime pm for all glue
>>> layers. I'll use that version instead, sorry.
>>>
>> That should be fine but you need to drop clk_*() related code
>> from that patch. I assume you will send refresh version of it then.
> 
> why ? it makes no difference if you enable twice and disable twice.
> 
Sure but why do you want to have the clock node handling code in drivers
if it is not needed. Isn't that better ?

WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: <balbi@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<ivan.khoronzhuk@ti.com>, <linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: keystone: switch to use runtime pm
Date: Fri, 31 Jan 2014 10:50:40 -0500	[thread overview]
Message-ID: <52EBC650.50305@ti.com> (raw)
In-Reply-To: <20140131154721.GD20736@saruman.home>

On Friday 31 January 2014 10:47 AM, Felipe Balbi wrote:
> On Fri, Jan 31, 2014 at 10:43:21AM -0500, Santosh Shilimkar wrote:
>> On Friday 31 January 2014 10:19 AM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Fri, Jan 31, 2014 at 03:20:26PM +0200, Grygorii Strashko wrote:
>>>> The Keystone PM management layer has been implemented using PM bus for
>>>> power management clocks. As result, most of Keystone drivers don't need
>>>> to manage clocks directly. They just need to enable runtime PM and use it
>>>> to handle their PM state and clocks.
>>>>
>>>> Hence, remove clock management code and switch to use runtime PM.
>>>>
>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>>
>>> quite a few weeks back I sent a series enabling runtime pm for all glue
>>> layers. I'll use that version instead, sorry.
>>>
>> That should be fine but you need to drop clk_*() related code
>> from that patch. I assume you will send refresh version of it then.
> 
> why ? it makes no difference if you enable twice and disable twice.
> 
Sure but why do you want to have the clock node handling code in drivers
if it is not needed. Isn't that better ?

  reply	other threads:[~2014-01-31 15:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 13:20 [PATCH] usb: dwc3: keystone: switch to use runtime pm Grygorii Strashko
2014-01-31 13:20 ` Grygorii Strashko
2014-01-31 14:35 ` Santosh Shilimkar
2014-01-31 14:35   ` Santosh Shilimkar
2014-01-31 15:19 ` Felipe Balbi
2014-01-31 15:19   ` Felipe Balbi
2014-01-31 15:43   ` Santosh Shilimkar
2014-01-31 15:43     ` Santosh Shilimkar
2014-01-31 15:47     ` Felipe Balbi
2014-01-31 15:47       ` Felipe Balbi
2014-01-31 15:50       ` Santosh Shilimkar [this message]
2014-01-31 15:50         ` Santosh Shilimkar
2014-01-31 16:45         ` Felipe Balbi
2014-01-31 16:45           ` Felipe Balbi
2014-01-31 19:20           ` Santosh Shilimkar
2014-01-31 19:20             ` Santosh Shilimkar
2014-01-31 22:15             ` Felipe Balbi
2014-01-31 22:15               ` Felipe Balbi
2014-01-31 23:04               ` Santosh Shilimkar
2014-01-31 23:04                 ` Santosh Shilimkar
2014-01-31 21:13           ` Alan Stern
2014-01-31 21:13             ` Alan Stern
2014-01-31 22:11             ` Felipe Balbi
2014-01-31 22:11               ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EBC650.50305@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.