From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jean-Francois Moine <moinejf@free.fr>,
alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Clark <robdclark@gmail.com>, Dave Airlie <airlied@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x
Date: Tue, 04 Feb 2014 14:36:50 +0100 [thread overview]
Message-ID: <52F0ECF2.9070102@metafoo.de> (raw)
In-Reply-To: <20140204133014.GA22609@sirena.org.uk>
On 02/04/2014 02:30 PM, Mark Brown wrote:
[...]
>
> What does this actually do? No information is being passed in to the
> core function here, not even any information on if it's starting or
> stopping. Looking at the rest of the code I can't help thinking it
> might be clearer to inline this possibly with a lookup helper, the code
> is very small and the lack of parameters makes it hard to follow.
>
>> +static const struct snd_soc_dapm_route tda_routes[] = {
>> + { "hdmi-out", NULL, "HDMI I2S Playback" },
>> + { "hdmi-out", NULL, "HDMI SPDIF Playback" },
>> +};
>
> S/PDIF.
Won't this cause issues with the debugfs widget entries? It's fixable by
escaping it (replace it by a dash or something) in the debugfs widget
filename, but I don't think we do this right now.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x
Date: Tue, 04 Feb 2014 14:36:50 +0100 [thread overview]
Message-ID: <52F0ECF2.9070102@metafoo.de> (raw)
In-Reply-To: <20140204133014.GA22609@sirena.org.uk>
On 02/04/2014 02:30 PM, Mark Brown wrote:
[...]
>
> What does this actually do? No information is being passed in to the
> core function here, not even any information on if it's starting or
> stopping. Looking at the rest of the code I can't help thinking it
> might be clearer to inline this possibly with a lookup helper, the code
> is very small and the lack of parameters makes it hard to follow.
>
>> +static const struct snd_soc_dapm_route tda_routes[] = {
>> + { "hdmi-out", NULL, "HDMI I2S Playback" },
>> + { "hdmi-out", NULL, "HDMI SPDIF Playback" },
>> +};
>
> S/PDIF.
Won't this cause issues with the debugfs widget entries? It's fixable by
escaping it (replace it by a dash or something) in the debugfs widget
filename, but I don't think we do this right now.
- Lars
next prev parent reply other threads:[~2014-02-04 13:36 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 17:10 [PATCH v3 0/5] add a TDA998x CODEC Jean-Francois Moine
2014-02-01 17:10 ` Jean-Francois Moine
2014-02-01 17:10 ` Jean-Francois Moine
2014-01-26 18:02 ` [PATCH v3 1/5] drm/i2c: tda998x: add a function for dynamic audio input switch Jean-Francois Moine
2014-01-26 18:02 ` Jean-Francois Moine
2014-01-26 18:02 ` Jean-Francois Moine
2014-01-26 18:45 ` [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x Jean-Francois Moine
2014-01-26 18:45 ` Jean-Francois Moine
2014-01-26 18:45 ` Jean-Francois Moine
2014-02-04 13:30 ` Mark Brown
2014-02-04 13:30 ` Mark Brown
2014-02-04 13:36 ` Lars-Peter Clausen [this message]
2014-02-04 13:36 ` [alsa-devel] " Lars-Peter Clausen
2014-02-04 17:46 ` Mark Brown
2014-02-04 17:46 ` Mark Brown
2014-02-04 17:16 ` Jean-Francois Moine
2014-02-04 17:16 ` Jean-Francois Moine
2014-02-04 17:16 ` Jean-Francois Moine
2014-02-04 17:54 ` Mark Brown
2014-02-04 17:54 ` Mark Brown
2014-02-04 17:54 ` Mark Brown
2014-02-04 18:59 ` Jean-Francois Moine
2014-02-04 18:59 ` Jean-Francois Moine
2014-02-04 18:59 ` Jean-Francois Moine
2014-02-04 19:40 ` Mark Brown
2014-02-04 19:40 ` Mark Brown
2014-01-27 8:48 ` [PATCH v3 4/5] ASoC: tda998x: adjust the audio hw parameters from EDID Jean-Francois Moine
2014-01-27 8:48 ` Jean-Francois Moine
2014-01-27 8:48 ` Jean-Francois Moine
2014-02-04 18:06 ` Mark Brown
2014-02-04 18:06 ` Mark Brown
2014-02-04 18:06 ` Mark Brown
2014-02-05 9:11 ` Jean-Francois Moine
2014-02-05 9:11 ` Jean-Francois Moine
2014-02-05 9:11 ` Jean-Francois Moine
2014-02-05 9:19 ` [alsa-devel] " Lars-Peter Clausen
2014-02-05 9:19 ` Lars-Peter Clausen
2014-02-05 9:19 ` Lars-Peter Clausen
2014-02-05 11:18 ` Mark Brown
2014-02-05 11:18 ` Mark Brown
2014-02-05 13:31 ` Lars-Peter Clausen
2014-02-05 13:31 ` Lars-Peter Clausen
2014-02-05 13:31 ` Lars-Peter Clausen
2014-02-05 14:08 ` Mark Brown
2014-02-05 14:08 ` Mark Brown
2014-02-05 18:07 ` Jean-Francois Moine
2014-02-05 18:07 ` Jean-Francois Moine
2014-02-05 18:07 ` Jean-Francois Moine
2014-02-05 18:21 ` Lars-Peter Clausen
2014-02-05 18:21 ` Lars-Peter Clausen
2014-02-05 18:21 ` Lars-Peter Clausen
2014-01-30 11:08 ` [PATCH v3 5/5] ASoC: tda998x: adjust the audio CTS_N pre-divider from audio format Jean-Francois Moine
2014-01-30 11:08 ` Jean-Francois Moine
2014-02-04 18:09 ` Mark Brown
2014-02-04 18:09 ` Mark Brown
2014-02-04 18:09 ` Mark Brown
2014-02-01 16:48 ` [PATCH v3 3/5] ASoC: tda998x: add DT documentation of the tda998x CODEC Jean-Francois Moine
2014-02-01 16:48 ` Jean-Francois Moine
2014-02-01 16:48 ` Jean-Francois Moine
[not found] ` <8e4231b7a55802f58a14dd07ac5cd8b0babb1dce.1391274628.git.moinejf-GANU6spQydw@public.gmane.org>
2014-02-01 18:30 ` Sergei Shtylyov
2014-02-01 18:30 ` Sergei Shtylyov
2014-02-01 18:30 ` Sergei Shtylyov
2014-02-04 18:12 ` Mark Brown
2014-02-04 18:12 ` Mark Brown
2014-02-04 18:12 ` Mark Brown
2014-02-04 19:02 ` Jean-Francois Moine
2014-02-04 19:02 ` Jean-Francois Moine
2014-02-04 19:02 ` Jean-Francois Moine
2014-02-04 19:54 ` Mark Brown
2014-02-04 19:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F0ECF2.9070102@metafoo.de \
--to=lars@metafoo.de \
--cc=airlied@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=moinejf@free.fr \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.