From: ivan.khoronzhuk@ti.com (Ivan Khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 4 Feb 2014 18:54:52 +0200 [thread overview]
Message-ID: <52F11B5C.40407@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402041715220.24986@ionos.tec.linutronix.de>
It was so in v1. But it was decided to use explicit memory barriers,
because we're always sure the memory barriers are there and that
they're properly documented. Also in this case I don't need to add
keystone readl/writel relaxed function variants and to use mixed calls of
writel/writel_relaxed functions.
See:
http://www.spinics.net/lists/arm-kernel/msg294941.html
On 02/04/2014 06:24 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>> + keystone_timer_writel(off, TCR);
>> + /* here we have to be sure the timer has been disabled */
>> + wmb();
> We have explicit writew_relaxed and writew. Why open coding the
> barriers?
>
> Thanks,
>
> tglx
--
Regards,
Ivan Khoronzhuk
WARNING: multiple messages have this Message-ID (diff)
From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: santosh.shilimkar@ti.com, rob@landley.net,
linux@arm.linux.org.uk, galak@codeaurora.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, daniel.lezcano@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, grygorii.strashko@ti.com
Subject: Re: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 4 Feb 2014 18:54:52 +0200 [thread overview]
Message-ID: <52F11B5C.40407@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402041715220.24986@ionos.tec.linutronix.de>
It was so in v1. But it was decided to use explicit memory barriers,
because we're always sure the memory barriers are there and that
they're properly documented. Also in this case I don't need to add
keystone readl/writel relaxed function variants and to use mixed calls of
writel/writel_relaxed functions.
See:
http://www.spinics.net/lists/arm-kernel/msg294941.html
On 02/04/2014 06:24 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>> + keystone_timer_writel(off, TCR);
>> + /* here we have to be sure the timer has been disabled */
>> + wmb();
> We have explicit writew_relaxed and writew. Why open coding the
> barriers?
>
> Thanks,
>
> tglx
--
Regards,
Ivan Khoronzhuk
WARNING: multiple messages have this Message-ID (diff)
From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <santosh.shilimkar@ti.com>, <rob@landley.net>,
<linux@arm.linux.org.uk>, <galak@codeaurora.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<daniel.lezcano@linaro.org>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <grygorii.strashko@ti.com>
Subject: Re: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 4 Feb 2014 18:54:52 +0200 [thread overview]
Message-ID: <52F11B5C.40407@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402041715220.24986@ionos.tec.linutronix.de>
It was so in v1. But it was decided to use explicit memory barriers,
because we're always sure the memory barriers are there and that
they're properly documented. Also in this case I don't need to add
keystone readl/writel relaxed function variants and to use mixed calls of
writel/writel_relaxed functions.
See:
http://www.spinics.net/lists/arm-kernel/msg294941.html
On 02/04/2014 06:24 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>> + keystone_timer_writel(off, TCR);
>> + /* here we have to be sure the timer has been disabled */
>> + wmb();
> We have explicit writew_relaxed and writew. Why open coding the
> barriers?
>
> Thanks,
>
> tglx
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2014-02-04 16:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 11:30 [PATCH v4 0/3] Introduce clocksource driver for Keystone platform Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:41 ` Ivan Khoronzhuk
2014-02-04 11:41 ` Ivan Khoronzhuk
2014-02-04 11:41 ` Ivan Khoronzhuk
2014-02-04 16:24 ` Thomas Gleixner
2014-02-04 16:24 ` Thomas Gleixner
2014-02-04 16:54 ` Ivan Khoronzhuk [this message]
2014-02-04 16:54 ` Ivan Khoronzhuk
2014-02-04 16:54 ` Ivan Khoronzhuk
2014-02-04 20:17 ` Thomas Gleixner
2014-02-04 20:17 ` Thomas Gleixner
2014-02-04 22:15 ` Santosh Shilimkar
2014-02-04 22:15 ` Santosh Shilimkar
2014-02-04 22:15 ` Santosh Shilimkar
2014-02-04 22:35 ` Ivan Khoronzhuk
2014-02-04 22:35 ` Ivan Khoronzhuk
2014-02-04 22:35 ` Ivan Khoronzhuk
2014-02-04 11:30 ` [PATCH v4 2/3] clocksource: keystone: add bindings for keystone timer Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:42 ` Ivan Khoronzhuk
2014-02-04 11:42 ` Ivan Khoronzhuk
2014-02-04 11:42 ` Ivan Khoronzhuk
2014-02-04 11:30 ` [PATCH v4 3/3] arm: dts: keystone: add keystone timer entry Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F11B5C.40407@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.