From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 4 Feb 2014 17:15:39 -0500 [thread overview]
Message-ID: <52F1668B.9040507@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402042113270.24986@ionos.tec.linutronix.de>
On Tuesday 04 February 2014 03:17 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>
> Please do not top post.
>
>> It was so in v1. But it was decided to use explicit memory barriers,
>> because we're always sure the memory barriers are there and that
>> they're properly documented. Also in this case I don't need to add
>> keystone readl/writel relaxed function variants and to use mixed calls of
>> writel/writel_relaxed functions.
>>
>> See:
>> http://www.spinics.net/lists/arm-kernel/msg294941.html
>
> Fair enough, but we want a proper explanation for explicit barriers in
> the code and not in some random discussion of patch version X on some
> random mailing list.
>
> Aside of that it should be iowmb(), but I might miss something ...
>
Agree. __iowmb() seems to be more appropriate.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
grygorii.strashko@ti.com, linux@arm.linux.org.uk,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
daniel.lezcano@linaro.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
rob@landley.net, galak@codeaurora.org,
Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 4 Feb 2014 17:15:39 -0500 [thread overview]
Message-ID: <52F1668B.9040507@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402042113270.24986@ionos.tec.linutronix.de>
On Tuesday 04 February 2014 03:17 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>
> Please do not top post.
>
>> It was so in v1. But it was decided to use explicit memory barriers,
>> because we're always sure the memory barriers are there and that
>> they're properly documented. Also in this case I don't need to add
>> keystone readl/writel relaxed function variants and to use mixed calls of
>> writel/writel_relaxed functions.
>>
>> See:
>> http://www.spinics.net/lists/arm-kernel/msg294941.html
>
> Fair enough, but we want a proper explanation for explicit barriers in
> the code and not in some random discussion of patch version X on some
> random mailing list.
>
> Aside of that it should be iowmb(), but I might miss something ...
>
Agree. __iowmb() seems to be more appropriate.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>, <rob@landley.net>,
<linux@arm.linux.org.uk>, <galak@codeaurora.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<daniel.lezcano@linaro.org>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <grygorii.strashko@ti.com>
Subject: Re: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone
Date: Tue, 4 Feb 2014 17:15:39 -0500 [thread overview]
Message-ID: <52F1668B.9040507@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402042113270.24986@ionos.tec.linutronix.de>
On Tuesday 04 February 2014 03:17 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>
> Please do not top post.
>
>> It was so in v1. But it was decided to use explicit memory barriers,
>> because we're always sure the memory barriers are there and that
>> they're properly documented. Also in this case I don't need to add
>> keystone readl/writel relaxed function variants and to use mixed calls of
>> writel/writel_relaxed functions.
>>
>> See:
>> http://www.spinics.net/lists/arm-kernel/msg294941.html
>
> Fair enough, but we want a proper explanation for explicit barriers in
> the code and not in some random discussion of patch version X on some
> random mailing list.
>
> Aside of that it should be iowmb(), but I might miss something ...
>
Agree. __iowmb() seems to be more appropriate.
Regards,
Santosh
next prev parent reply other threads:[~2014-02-04 22:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 11:30 [PATCH v4 0/3] Introduce clocksource driver for Keystone platform Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:41 ` Ivan Khoronzhuk
2014-02-04 11:41 ` Ivan Khoronzhuk
2014-02-04 11:41 ` Ivan Khoronzhuk
2014-02-04 16:24 ` Thomas Gleixner
2014-02-04 16:24 ` Thomas Gleixner
2014-02-04 16:54 ` Ivan Khoronzhuk
2014-02-04 16:54 ` Ivan Khoronzhuk
2014-02-04 16:54 ` Ivan Khoronzhuk
2014-02-04 20:17 ` Thomas Gleixner
2014-02-04 20:17 ` Thomas Gleixner
2014-02-04 22:15 ` Santosh Shilimkar [this message]
2014-02-04 22:15 ` Santosh Shilimkar
2014-02-04 22:15 ` Santosh Shilimkar
2014-02-04 22:35 ` Ivan Khoronzhuk
2014-02-04 22:35 ` Ivan Khoronzhuk
2014-02-04 22:35 ` Ivan Khoronzhuk
2014-02-04 11:30 ` [PATCH v4 2/3] clocksource: keystone: add bindings for keystone timer Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:42 ` Ivan Khoronzhuk
2014-02-04 11:42 ` Ivan Khoronzhuk
2014-02-04 11:42 ` Ivan Khoronzhuk
2014-02-04 11:30 ` [PATCH v4 3/3] arm: dts: keystone: add keystone timer entry Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
2014-02-04 11:30 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F1668B.9040507@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.