From: Frank Rowand <frowand.list@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
linux-arm-msm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
Saravana Kannan <skannan@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller
Date: Fri, 07 Feb 2014 11:38:42 -0800 [thread overview]
Message-ID: <52F53642.3030606@gmail.com> (raw)
In-Reply-To: <1391749891.15777.31.camel@joe-AO722>
On 2/6/2014 9:11 PM, Joe Perches wrote:
> On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote:
>> On 1/15/2014 10:47 AM, Stephen Boyd wrote:
>>> The first breaks a reset-controller include ordering requirement. It got
>>> an ack so I think we're ok for it to go through the clock tree.
>>>
>>
>> < snip >
>>
>> checkpatch is whining about patches
>>
>> 4
>> 5
>> 6
>> 7
>> 8
>>
>> (Just for completeness if someone thinks I did not check all the patches,
>> it also whines about patch 11, but I think the whining should be ignored,
>> and it whines about patch 1 but I think that might be a checkpatch bug.)
>
> Hi Frank.
>
> For patch 1, what checkpatch bug might that be?
see below
>
> I think all the checkpatch whinges in patch 11 are correct.
Agreed on patch 11, judgement call on whether to ignore the warnings.
>
> I didn't check any of 4-8.
Hi Joe,
Thanks for jumping in. I did not want to bother you until I dug a little
deeper into the warning to see if I was just misunderstanding something.
Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add set_rate_and_parent() op"):
WARNING: Multiple spaces after return type
#188: FILE: include/linux/clk-provider.h:154:
+ int (*set_rate_and_parent)(struct clk_hw *hw,
total: 0 errors, 1 warnings, 152 lines checked
-Frank
WARNING: multiple messages have this Message-ID (diff)
From: frowand.list@gmail.com (Frank Rowand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller
Date: Fri, 07 Feb 2014 11:38:42 -0800 [thread overview]
Message-ID: <52F53642.3030606@gmail.com> (raw)
In-Reply-To: <1391749891.15777.31.camel@joe-AO722>
On 2/6/2014 9:11 PM, Joe Perches wrote:
> On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote:
>> On 1/15/2014 10:47 AM, Stephen Boyd wrote:
>>> The first breaks a reset-controller include ordering requirement. It got
>>> an ack so I think we're ok for it to go through the clock tree.
>>>
>>
>> < snip >
>>
>> checkpatch is whining about patches
>>
>> 4
>> 5
>> 6
>> 7
>> 8
>>
>> (Just for completeness if someone thinks I did not check all the patches,
>> it also whines about patch 11, but I think the whining should be ignored,
>> and it whines about patch 1 but I think that might be a checkpatch bug.)
>
> Hi Frank.
>
> For patch 1, what checkpatch bug might that be?
see below
>
> I think all the checkpatch whinges in patch 11 are correct.
Agreed on patch 11, judgement call on whether to ignore the warnings.
>
> I didn't check any of 4-8.
Hi Joe,
Thanks for jumping in. I did not want to bother you until I dug a little
deeper into the warning to see if I was just misunderstanding something.
Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add set_rate_and_parent() op"):
WARNING: Multiple spaces after return type
#188: FILE: include/linux/clk-provider.h:154:
+ int (*set_rate_and_parent)(struct clk_hw *hw,
total: 0 errors, 1 warnings, 152 lines checked
-Frank
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Saravana Kannan <skannan@codeaurora.org>
Subject: Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller
Date: Fri, 07 Feb 2014 11:38:42 -0800 [thread overview]
Message-ID: <52F53642.3030606@gmail.com> (raw)
In-Reply-To: <1391749891.15777.31.camel@joe-AO722>
On 2/6/2014 9:11 PM, Joe Perches wrote:
> On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote:
>> On 1/15/2014 10:47 AM, Stephen Boyd wrote:
>>> The first breaks a reset-controller include ordering requirement. It got
>>> an ack so I think we're ok for it to go through the clock tree.
>>>
>>
>> < snip >
>>
>> checkpatch is whining about patches
>>
>> 4
>> 5
>> 6
>> 7
>> 8
>>
>> (Just for completeness if someone thinks I did not check all the patches,
>> it also whines about patch 11, but I think the whining should be ignored,
>> and it whines about patch 1 but I think that might be a checkpatch bug.)
>
> Hi Frank.
>
> For patch 1, what checkpatch bug might that be?
see below
>
> I think all the checkpatch whinges in patch 11 are correct.
Agreed on patch 11, judgement call on whether to ignore the warnings.
>
> I didn't check any of 4-8.
Hi Joe,
Thanks for jumping in. I did not want to bother you until I dug a little
deeper into the warning to see if I was just misunderstanding something.
Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add set_rate_and_parent() op"):
WARNING: Multiple spaces after return type
#188: FILE: include/linux/clk-provider.h:154:
+ int (*set_rate_and_parent)(struct clk_hw *hw,
total: 0 errors, 1 warnings, 152 lines checked
-Frank
next prev parent reply other threads:[~2014-02-07 19:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 18:47 [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 01/14] reset: Silence warning in reset-controller.h Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 02/14] clk: Add set_rate_and_parent() op Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 03/14] clk: qcom: Add a regmap type clock struct Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 04/14] clk: qcom: Add support for phase locked loops (PLLs) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 05/14] clk: qcom: Add support for root clock generators (RCGs) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 06/14] clk: qcom: Add support for branches/gate clocks Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 07/14] clk: qcom: Add reset controller support Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 08/14] clk: qcom: Add support for MSM8960's global clock controller (GCC) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 09/14] clk: qcom: Add support for MSM8960's multimedia clock controller (MMCC) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 10/14] clk: qcom: Add support for MSM8974's global clock controller (GCC) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 11/14] clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 12/14] clk: qcom: Add support for MSM8660's global clock controller (GCC) Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` [PATCH v5 13/14] devicetree: bindings: Document qcom,gcc Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
[not found] ` <1389811654-21397-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-15 18:47 ` [PATCH v5 14/14] devicetree: bindings: Document qcom,mmcc Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-15 18:47 ` Stephen Boyd
2014-01-16 19:28 ` [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller Mike Turquette
2014-01-16 19:28 ` Mike Turquette
2014-02-07 4:15 ` Frank Rowand
2014-02-07 4:15 ` Frank Rowand
2014-02-07 4:32 ` Frank Rowand
2014-02-07 4:32 ` Frank Rowand
2014-02-07 5:11 ` Joe Perches
2014-02-07 5:11 ` Joe Perches
2014-02-07 19:38 ` Frank Rowand [this message]
2014-02-07 19:38 ` Frank Rowand
2014-02-07 19:38 ` Frank Rowand
2014-02-07 20:51 ` Joe Perches
2014-02-07 20:51 ` Joe Perches
2014-02-07 23:36 ` Frank Rowand
2014-02-07 23:36 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F53642.3030606@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.