From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: enable I2C MUX PCA954x
Date: Fri, 07 Feb 2014 16:34:45 -0700 [thread overview]
Message-ID: <52F56D95.50707@wwwdotorg.org> (raw)
In-Reply-To: <1391806412-8561-1-git-send-email-pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 02/07/2014 01:53 PM, Bryan Wu wrote:
> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
> cameras. It's required for Tegra V4L2 soc camera driver and camera
> sensor drivers.
> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
> arch/arm/configs/tegra_defconfig | 1 +
DT and defconfig changes go into separate branches. Could I get this
split into two patches please?
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> + /* NXP PCA9546 I2C Mux */
That comment isn't useful, since the compatible value below spells out
what the device is.
> + pca9546@70 {
DT nodes should be named after the class/type of device, not the
identify. As such, use "i2cmux@70".
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: enable I2C MUX PCA954x
Date: Fri, 07 Feb 2014 16:34:45 -0700 [thread overview]
Message-ID: <52F56D95.50707@wwwdotorg.org> (raw)
In-Reply-To: <1391806412-8561-1-git-send-email-pengw@nvidia.com>
On 02/07/2014 01:53 PM, Bryan Wu wrote:
> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
> cameras. It's required for Tegra V4L2 soc camera driver and camera
> sensor drivers.
> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
> arch/arm/configs/tegra_defconfig | 1 +
DT and defconfig changes go into separate branches. Could I get this
split into two patches please?
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> + /* NXP PCA9546 I2C Mux */
That comment isn't useful, since the compatible value below spells out
what the device is.
> + pca9546 at 70 {
DT nodes should be named after the class/type of device, not the
identify. As such, use "i2cmux at 70".
next prev parent reply other threads:[~2014-02-07 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 20:53 [PATCH] ARM: tegra: enable I2C MUX PCA954x Bryan Wu
2014-02-07 20:53 ` Bryan Wu
[not found] ` <1391806412-8561-1-git-send-email-pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-07 23:34 ` Stephen Warren [this message]
2014-02-07 23:34 ` Stephen Warren
[not found] ` <52F56D95.50707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-07 23:43 ` Bryan Wu
2014-02-07 23:43 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F56D95.50707@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.