* [PATCH] ARM: tegra: enable I2C MUX PCA954x
@ 2014-02-07 20:53 ` Bryan Wu
0 siblings, 0 replies; 6+ messages in thread
From: Bryan Wu @ 2014-02-07 20:53 UTC (permalink / raw)
To: swarren-3lzwWm7+Weoh9ZMKESR00Q,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Cardhu has a PCA9546 for I2C bus extension, which connects to 3
cameras. It's required for Tegra V4L2 soc camera driver and camera
sensor drivers.
Signed-off-by: Bryan Wu <pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
arch/arm/configs/tegra_defconfig | 1 +
2 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 9104224..bfce643 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,6 +187,14 @@
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
};
+
+ /* NXP PCA9546 I2C Mux */
+ pca9546@70 {
+ compatible = "nxp,pca9546";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x70>;
+ };
};
i2c@7000c700 {
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 995d434..efcf15f 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -125,6 +125,7 @@ CONFIG_SERIAL_TEGRA=y
CONFIG_SERIAL_OF_PLATFORM=y
# CONFIG_HW_RANDOM is not set
# CONFIG_I2C_COMPAT is not set
+CONFIG_I2C_MUX_PCA954x=y
CONFIG_I2C_MUX_PINCTRL=y
CONFIG_I2C_TEGRA=y
CONFIG_SPI=y
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: tegra: enable I2C MUX PCA954x
@ 2014-02-07 20:53 ` Bryan Wu
0 siblings, 0 replies; 6+ messages in thread
From: Bryan Wu @ 2014-02-07 20:53 UTC (permalink / raw)
To: linux-arm-kernel
Cardhu has a PCA9546 for I2C bus extension, which connects to 3
cameras. It's required for Tegra V4L2 soc camera driver and camera
sensor drivers.
Signed-off-by: Bryan Wu <pengw@nvidia.com>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
arch/arm/configs/tegra_defconfig | 1 +
2 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 9104224..bfce643 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,6 +187,14 @@
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
};
+
+ /* NXP PCA9546 I2C Mux */
+ pca9546 at 70 {
+ compatible = "nxp,pca9546";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x70>;
+ };
};
i2c at 7000c700 {
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 995d434..efcf15f 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -125,6 +125,7 @@ CONFIG_SERIAL_TEGRA=y
CONFIG_SERIAL_OF_PLATFORM=y
# CONFIG_HW_RANDOM is not set
# CONFIG_I2C_COMPAT is not set
+CONFIG_I2C_MUX_PCA954x=y
CONFIG_I2C_MUX_PINCTRL=y
CONFIG_I2C_TEGRA=y
CONFIG_SPI=y
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1391806412-8561-1-git-send-email-pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ARM: tegra: enable I2C MUX PCA954x
2014-02-07 20:53 ` Bryan Wu
@ 2014-02-07 23:34 ` Stephen Warren
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2014-02-07 23:34 UTC (permalink / raw)
To: Bryan Wu, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 02/07/2014 01:53 PM, Bryan Wu wrote:
> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
> cameras. It's required for Tegra V4L2 soc camera driver and camera
> sensor drivers.
> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
> arch/arm/configs/tegra_defconfig | 1 +
DT and defconfig changes go into separate branches. Could I get this
split into two patches please?
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> + /* NXP PCA9546 I2C Mux */
That comment isn't useful, since the compatible value below spells out
what the device is.
> + pca9546@70 {
DT nodes should be named after the class/type of device, not the
identify. As such, use "i2cmux@70".
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: tegra: enable I2C MUX PCA954x
@ 2014-02-07 23:34 ` Stephen Warren
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2014-02-07 23:34 UTC (permalink / raw)
To: linux-arm-kernel
On 02/07/2014 01:53 PM, Bryan Wu wrote:
> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
> cameras. It's required for Tegra V4L2 soc camera driver and camera
> sensor drivers.
> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
> arch/arm/configs/tegra_defconfig | 1 +
DT and defconfig changes go into separate branches. Could I get this
split into two patches please?
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> + /* NXP PCA9546 I2C Mux */
That comment isn't useful, since the compatible value below spells out
what the device is.
> + pca9546 at 70 {
DT nodes should be named after the class/type of device, not the
identify. As such, use "i2cmux at 70".
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <52F56D95.50707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]
* Re: [PATCH] ARM: tegra: enable I2C MUX PCA954x
2014-02-07 23:34 ` Stephen Warren
@ 2014-02-07 23:43 ` Bryan Wu
-1 siblings, 0 replies; 6+ messages in thread
From: Bryan Wu @ 2014-02-07 23:43 UTC (permalink / raw)
To: Stephen Warren
Cc: Thierry Reding, Russell King - ARM Linux,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra
On Fri, Feb 7, 2014 at 3:34 PM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
> On 02/07/2014 01:53 PM, Bryan Wu wrote:
>> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
>> cameras. It's required for Tegra V4L2 soc camera driver and camera
>> sensor drivers.
>
>> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
>> arch/arm/configs/tegra_defconfig | 1 +
>
> DT and defconfig changes go into separate branches. Could I get this
> split into two patches please?
>
>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
>
>> + /* NXP PCA9546 I2C Mux */
>
> That comment isn't useful, since the compatible value below spells out
> what the device is.
>
>> + pca9546@70 {
>
> DT nodes should be named after the class/type of device, not the
> identify. As such, use "i2cmux@70".
>
OK, cool. I will take all the comments and post my V2 patches.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: tegra: enable I2C MUX PCA954x
@ 2014-02-07 23:43 ` Bryan Wu
0 siblings, 0 replies; 6+ messages in thread
From: Bryan Wu @ 2014-02-07 23:43 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 7, 2014 at 3:34 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/07/2014 01:53 PM, Bryan Wu wrote:
>> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
>> cameras. It's required for Tegra V4L2 soc camera driver and camera
>> sensor drivers.
>
>> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
>> arch/arm/configs/tegra_defconfig | 1 +
>
> DT and defconfig changes go into separate branches. Could I get this
> split into two patches please?
>
>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
>
>> + /* NXP PCA9546 I2C Mux */
>
> That comment isn't useful, since the compatible value below spells out
> what the device is.
>
>> + pca9546 at 70 {
>
> DT nodes should be named after the class/type of device, not the
> identify. As such, use "i2cmux at 70".
>
OK, cool. I will take all the comments and post my V2 patches.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-07 23:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-07 20:53 [PATCH] ARM: tegra: enable I2C MUX PCA954x Bryan Wu
2014-02-07 20:53 ` Bryan Wu
[not found] ` <1391806412-8561-1-git-send-email-pengw-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-07 23:34 ` Stephen Warren
2014-02-07 23:34 ` Stephen Warren
[not found] ` <52F56D95.50707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-07 23:43 ` Bryan Wu
2014-02-07 23:43 ` Bryan Wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.