From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers
Date: Tue, 11 Feb 2014 14:06:15 +0000 [thread overview]
Message-ID: <52FA2E57.3010300@ti.com> (raw)
In-Reply-To: <523BF40B.1090002@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 20/09/13 10:06, Ryan Mallon wrote:
> Several video drivers open code the fb_write write function with code
> which is very similar to fb_sys_write. Replace the open code versions
> with calls to fb_sys_write. An fb_sync callback is added to each of
> the drivers.
>
> Signed-off-by: Ryan Mallon <rmallon@gmail.com>
> ---
Doesn't this change the behavior so that fb_write does no longer update
the display, but fb_sync does? I don't think fb_sync is even meant to
update the display, it's meant to wait for an update to finish. Then
again, I'm not sure about that, all I see in fb.h is "wait for blit
idle, optional"
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers
Date: Tue, 11 Feb 2014 16:06:15 +0200 [thread overview]
Message-ID: <52FA2E57.3010300@ti.com> (raw)
In-Reply-To: <523BF40B.1090002@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 20/09/13 10:06, Ryan Mallon wrote:
> Several video drivers open code the fb_write write function with code
> which is very similar to fb_sys_write. Replace the open code versions
> with calls to fb_sys_write. An fb_sync callback is added to each of
> the drivers.
>
> Signed-off-by: Ryan Mallon <rmallon@gmail.com>
> ---
Doesn't this change the behavior so that fb_write does no longer update
the display, but fb_sync does? I don't think fb_sync is even meant to
update the display, it's meant to wait for an update to finish. Then
again, I'm not sure about that, all I see in fb.h is "wait for blit
idle, optional"
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-02-11 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 7:06 [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers Ryan Mallon
2013-09-20 7:06 ` Ryan Mallon
2014-02-11 14:06 ` Tomi Valkeinen [this message]
2014-02-11 14:06 ` Tomi Valkeinen
2014-02-11 19:07 ` Ryan Mallon
2014-02-11 19:07 ` Ryan Mallon
2014-02-12 6:54 ` Tomi Valkeinen
2014-02-12 6:54 ` Tomi Valkeinen
2014-02-12 5:02 ` Ryan Mallon
2014-02-12 5:02 ` Ryan Mallon
2014-02-12 8:17 ` Tomi Valkeinen
2014-02-12 8:17 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA2E57.3010300@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.