From: Thomas Hellstrom <thellstrom@vmware.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Maarten Lankhorst <m.b.lankhorst@gmail.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jerome Glisse <jglisse@redhat.com>,
Brian Paul <brianp@vmware.com>
Subject: Re: [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
Date: Wed, 12 Feb 2014 11:24:10 +0000 [thread overview]
Message-ID: <52FB59DA.5020700@vmware.com> (raw)
In-Reply-To: <20140211160346.GA9406@elgon.mountain>
On 02/11/2014 05:03 PM, Dan Carpenter wrote:
> There is a missing unlock on error here.
>
> Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 269b85cc875a..9fbbaaa9e541 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
> if (dev_priv->has_mob) {
> ret = vmw_rebind_contexts(sw_context);
> if (unlikely(ret != 0))
> - goto out_err;
> + goto out_unlock_binding;
> }
>
> cmd = vmw_fifo_reserve(dev_priv, command_size);
Dan, thanks,
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Queued for next vmwgfx-fixes pull.
/Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Maarten Lankhorst <m.b.lankhorst@gmail.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jerome Glisse <jglisse@redhat.com>,
Brian Paul <brianp@vmware.com>
Subject: Re: [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
Date: Wed, 12 Feb 2014 12:24:10 +0100 [thread overview]
Message-ID: <52FB59DA.5020700@vmware.com> (raw)
In-Reply-To: <20140211160346.GA9406@elgon.mountain>
On 02/11/2014 05:03 PM, Dan Carpenter wrote:
> There is a missing unlock on error here.
>
> Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 269b85cc875a..9fbbaaa9e541 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
> if (dev_priv->has_mob) {
> ret = vmw_rebind_contexts(sw_context);
> if (unlikely(ret != 0))
> - goto out_err;
> + goto out_unlock_binding;
> }
>
> cmd = vmw_fifo_reserve(dev_priv, command_size);
Dan, thanks,
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Queued for next vmwgfx-fixes pull.
/Thomas
next prev parent reply other threads:[~2014-02-12 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 16:03 [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process() Dan Carpenter
2014-02-11 16:03 ` Dan Carpenter
2014-02-12 11:24 ` Thomas Hellstrom [this message]
2014-02-12 11:24 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB59DA.5020700@vmware.com \
--to=thellstrom@vmware.com \
--cc=brianp@vmware.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.