* [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
@ 2014-02-11 16:03 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-11 16:03 UTC (permalink / raw)
To: David Airlie
Cc: Maarten Lankhorst, Thomas Hellstrom, kernel-janitors, dri-devel,
Jerome Glisse, Brian Paul
There is a missing unlock on error here.
Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 269b85cc875a..9fbbaaa9e541 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
if (dev_priv->has_mob) {
ret = vmw_rebind_contexts(sw_context);
if (unlikely(ret != 0))
- goto out_err;
+ goto out_unlock_binding;
}
cmd = vmw_fifo_reserve(dev_priv, command_size);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
@ 2014-02-11 16:03 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-11 16:03 UTC (permalink / raw)
To: David Airlie
Cc: Maarten Lankhorst, Thomas Hellstrom, kernel-janitors, dri-devel,
Jerome Glisse, Brian Paul
There is a missing unlock on error here.
Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 269b85cc875a..9fbbaaa9e541 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
if (dev_priv->has_mob) {
ret = vmw_rebind_contexts(sw_context);
if (unlikely(ret != 0))
- goto out_err;
+ goto out_unlock_binding;
}
cmd = vmw_fifo_reserve(dev_priv, command_size);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
2014-02-11 16:03 ` Dan Carpenter
@ 2014-02-12 11:24 ` Thomas Hellstrom
-1 siblings, 0 replies; 4+ messages in thread
From: Thomas Hellstrom @ 2014-02-12 11:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Maarten Lankhorst, kernel-janitors, dri-devel, Jerome Glisse,
Brian Paul
On 02/11/2014 05:03 PM, Dan Carpenter wrote:
> There is a missing unlock on error here.
>
> Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 269b85cc875a..9fbbaaa9e541 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
> if (dev_priv->has_mob) {
> ret = vmw_rebind_contexts(sw_context);
> if (unlikely(ret != 0))
> - goto out_err;
> + goto out_unlock_binding;
> }
>
> cmd = vmw_fifo_reserve(dev_priv, command_size);
Dan, thanks,
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Queued for next vmwgfx-fixes pull.
/Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
@ 2014-02-12 11:24 ` Thomas Hellstrom
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Hellstrom @ 2014-02-12 11:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Maarten Lankhorst, kernel-janitors, dri-devel, Jerome Glisse,
Brian Paul
On 02/11/2014 05:03 PM, Dan Carpenter wrote:
> There is a missing unlock on error here.
>
> Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 269b85cc875a..9fbbaaa9e541 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
> if (dev_priv->has_mob) {
> ret = vmw_rebind_contexts(sw_context);
> if (unlikely(ret != 0))
> - goto out_err;
> + goto out_unlock_binding;
> }
>
> cmd = vmw_fifo_reserve(dev_priv, command_size);
Dan, thanks,
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Queued for next vmwgfx-fixes pull.
/Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-12 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-11 16:03 [patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process() Dan Carpenter
2014-02-11 16:03 ` Dan Carpenter
2014-02-12 11:24 ` Thomas Hellstrom
2014-02-12 11:24 ` Thomas Hellstrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.