All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Sanjay Lal <sanjayl@kymasys.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH v2 09/10] hw/mips: malta: Add KVM support
Date: Wed, 12 Feb 2014 15:07:52 +0000	[thread overview]
Message-ID: <52FB8E48.3080202@imgtec.com> (raw)
In-Reply-To: <CAFEAcA-+rGcB=+v9qVRLHLCPYmZDrgkJ-S18Gz_iShepEY=gVg@mail.gmail.com>

On 21/12/13 20:42, Peter Maydell wrote:
> On 16 December 2013 14:12, James Hogan <james.hogan@imgtec.com> wrote:
>> +#include "linux/kvm.h"
> 
> You can't include linux/kvm.h like this -- on Linux this will pull in
> whatever the host's system kvm.h happens to be, and on non-Linux
> it won't compile:
> 
> /Users/pm215/src/qemu/hw/mips/mips_malta.c:56:10: fatal error:
> 'linux/kvm.h' file not found
> #include "linux/kvm.h"
>          ^
> 1 error generated.

Thanks Peter, I've removed all these new includes except sysemu/kvm.h.

Cheers
James

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Sanjay Lal <sanjayl@kymasys.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2 09/10] hw/mips: malta: Add KVM support
Date: Wed, 12 Feb 2014 15:07:52 +0000	[thread overview]
Message-ID: <52FB8E48.3080202@imgtec.com> (raw)
In-Reply-To: <CAFEAcA-+rGcB=+v9qVRLHLCPYmZDrgkJ-S18Gz_iShepEY=gVg@mail.gmail.com>

On 21/12/13 20:42, Peter Maydell wrote:
> On 16 December 2013 14:12, James Hogan <james.hogan@imgtec.com> wrote:
>> +#include "linux/kvm.h"
> 
> You can't include linux/kvm.h like this -- on Linux this will pull in
> whatever the host's system kvm.h happens to be, and on non-Linux
> it won't compile:
> 
> /Users/pm215/src/qemu/hw/mips/mips_malta.c:56:10: fatal error:
> 'linux/kvm.h' file not found
> #include "linux/kvm.h"
>          ^
> 1 error generated.

Thanks Peter, I've removed all these new includes except sysemu/kvm.h.

Cheers
James

  reply	other threads:[~2014-02-12 15:07 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 14:12 [PATCH v2 00/10] KVM Support for MIPS32 Processors James Hogan
2013-12-16 14:12 ` [Qemu-devel] " James Hogan
2013-12-16 14:12 ` [PATCH v2 01/10] hw/mips/cputimer: Don't start periodic timer in KVM mode James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:34   ` Aurelien Jarno
2013-12-21 15:34     ` [Qemu-devel] " Aurelien Jarno
2013-12-16 14:12 ` [PATCH v2 02/10] hw/mips: Add API to convert KVM guest KSEG0 <-> GPA James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:34   ` Aurelien Jarno
2013-12-21 15:34     ` [Qemu-devel] " Aurelien Jarno
2013-12-16 14:12 ` [PATCH v2 03/10] target-mips: get_physical_address: Add defines for segment bases James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:34   ` Aurelien Jarno
2013-12-21 15:34     ` [Qemu-devel] " Aurelien Jarno
2013-12-16 14:12 ` [PATCH v2 04/10] target-mips: get_physical_address: Add KVM awareness James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:34   ` Aurelien Jarno
2013-12-21 15:34     ` [Qemu-devel] " Aurelien Jarno
2013-12-16 14:12 ` [PATCH v2 05/10] kvm: Set sigmask length to 16 for MIPS targets James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:34   ` Aurelien Jarno
2013-12-21 15:34     ` [Qemu-devel] " Aurelien Jarno
2013-12-21 20:18   ` Peter Maydell
2013-12-21 20:18     ` Peter Maydell
2013-12-16 14:12 ` [PATCH v2 06/10] target-mips: Set target page size to 16K in KVM mode James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:34   ` Aurelien Jarno
2013-12-21 15:34     ` [Qemu-devel] " Aurelien Jarno
2013-12-16 14:12 ` [PATCH v2 07/10] target-mips: kvm: Add main KVM support for MIPS James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:35   ` Aurelien Jarno
2013-12-21 15:35     ` [Qemu-devel] " Aurelien Jarno
2014-02-10 14:07   ` Andreas Färber
2014-02-10 14:07     ` Andreas Färber
2014-02-11 10:54     ` James Hogan
2014-02-11 10:54       ` James Hogan
2013-12-16 14:12 ` [PATCH v2 08/10] hw/mips: In KVM mode, inject IRQ2 (I/O) interupts via ioctls James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:41   ` Aurelien Jarno
2013-12-21 15:41     ` [Qemu-devel] " Aurelien Jarno
2013-12-21 20:40   ` Peter Maydell
2013-12-21 20:40     ` Peter Maydell
2013-12-16 14:12 ` [PATCH v2 09/10] hw/mips: malta: Add KVM support James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:37   ` Aurelien Jarno
2013-12-21 15:37     ` [Qemu-devel] " Aurelien Jarno
2013-12-21 20:42   ` Peter Maydell
2013-12-21 20:42     ` Peter Maydell
2014-02-12 15:07     ` James Hogan [this message]
2014-02-12 15:07       ` James Hogan
2013-12-16 14:12 ` [PATCH v2 10/10] target-mips: Enable KVM support in build system James Hogan
2013-12-16 14:12   ` [Qemu-devel] " James Hogan
2013-12-21 15:38   ` Aurelien Jarno
2013-12-21 15:38     ` [Qemu-devel] " Aurelien Jarno
2013-12-21 18:59   ` Peter Maydell
2013-12-21 18:59     ` [Qemu-devel] " Peter Maydell
2013-12-23 12:31     ` James Hogan
2013-12-23 12:31       ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FB8E48.3080202@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=aurelien@aurel32.net \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sanjayl@kymasys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.