From: Goffredo Baroncelli <kreijack@libero.it>
To: Hugo Mills <hugo@carfax.org.uk>
Cc: Josef Bacik <jbacik@fb.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: What to do about df and btrfs fi df
Date: Wed, 12 Feb 2014 22:03:37 +0100 [thread overview]
Message-ID: <52FBE1A9.7080100@libero.it> (raw)
In-Reply-To: <20140211185657.GM6490@carfax.org.uk>
Hi Hugo,
On 02/11/2014 07:56 PM, Hugo Mills wrote:
>> $ sudo btrfs filesystem df /mnt/btrfs1/
>> Disk size: 400.00GB
>> Disk unallocated: 391.97GB
>> Disk allocation:
>> Allocated Used
>> Data, single: 2.01GB, 1.00GB
>> System, DUP: 4.00MB 2.00MB
>> System, single: 4.00MB 1.00MB
>> Metadata, DUP: 2.00GB 750.00MB
>> Metadata, single: 8.00MB 2.20MB
>> ------ -------
>> Total: 7.00GB 1.75GB
>
> Two minor nits here: please put a space between the number and the
> units, and distinguish between e.g. MB (powers of 10) and MiB (powers
> of 2).
I will use the pretty_size_snprintf() function, which uses the powers
of 2 units, but unfortunately doesn't seems to have the space.
The space could be added with a dedicated patch.
>
> Hugo.
>
--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2014-02-12 21:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 16:41 What to do about df and btrfs fi df Josef Bacik
2014-02-10 17:06 ` Hugo Mills
2014-02-10 18:24 ` cwillu
2014-02-10 18:28 ` Josef Bacik
2014-02-10 18:36 ` cwillu
2014-02-10 18:41 ` Josef Bacik
2014-02-10 18:54 ` cwillu
2014-02-10 19:05 ` Hugo Mills
2014-02-11 17:36 ` David Sterba
2014-02-17 17:08 ` David Sterba
2014-02-18 8:33 ` Goswin von Brederlow
2014-02-18 16:43 ` David Sterba
2014-02-11 1:02 ` Roger Binns
2014-02-11 3:13 ` cwillu
2014-02-11 3:35 ` ronnie sahlberg
2014-02-11 19:58 ` Roger Binns
2014-02-10 22:14 ` Goffredo Baroncelli
2014-02-10 22:26 ` Goffredo Baroncelli
2014-02-10 22:56 ` cwillu
2014-02-11 13:14 ` Josef Bacik
2014-02-11 18:20 ` Goffredo Baroncelli
2014-02-11 18:33 ` Josef Bacik
2014-02-11 18:46 ` Goffredo Baroncelli
2014-02-11 18:56 ` Hugo Mills
2014-02-12 21:03 ` Goffredo Baroncelli [this message]
2014-02-11 20:53 ` Sandy McArthur
2014-02-12 3:09 ` Kostia Khlebopros
2014-02-12 21:12 ` Goffredo Baroncelli
2014-02-12 3:55 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FBE1A9.7080100@libero.it \
--to=kreijack@libero.it \
--cc=hugo@carfax.org.uk \
--cc=jbacik@fb.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.