From: Timur Tabi <timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA
Date: Thu, 13 Feb 2014 11:11:55 -0600 [thread overview]
Message-ID: <52FCFCDB.5090907@codeaurora.org> (raw)
In-Reply-To: <20140213170408.GM13576-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
On 02/13/2014 11:04 AM, Will Deacon wrote:
> It's harmless to enable CONFIG_ARM_AMBA, even if you don't have any AMBA
> devices in your SoC,
Ah, ok. It's seems obvious now, but somehow that didn't click.
> it just makes your binary a bit bigger because you're
> compiling in code that you don't need. Instead, you might elect to set
> CONFIG_ARM_AMBA=n, at which point the arm-smmu driver will fail to build
> without this patch.
Ok, thanks. We discovered the same problem internally, and had the same
solution, but during code reviews some concerns were raised.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA
Date: Thu, 13 Feb 2014 11:11:55 -0600 [thread overview]
Message-ID: <52FCFCDB.5090907@codeaurora.org> (raw)
In-Reply-To: <20140213170408.GM13576@mudshark.cambridge.arm.com>
On 02/13/2014 11:04 AM, Will Deacon wrote:
> It's harmless to enable CONFIG_ARM_AMBA, even if you don't have any AMBA
> devices in your SoC,
Ah, ok. It's seems obvious now, but somehow that didn't click.
> it just makes your binary a bit bigger because you're
> compiling in code that you don't need. Instead, you might elect to set
> CONFIG_ARM_AMBA=n, at which point the arm-smmu driver will fail to build
> without this patch.
Ok, thanks. We discovered the same problem internally, and had the same
solution, but during code reviews some concerns were raised.
next prev parent reply other threads:[~2014-02-13 17:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 18:09 [PATCH 0/5] iommu/arm-smmu: fixes for 3.14 Will Deacon
2014-02-06 18:09 ` Will Deacon
2014-02-06 18:09 ` [PATCH 2/5] iommu/arm-smmu: really fix page table locking Will Deacon
2014-02-06 18:09 ` Will Deacon
[not found] ` <1391710173-4343-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-02-06 18:09 ` [PATCH 1/5] iommu/arm-smmu: fix pud/pmd entry fill sequence Will Deacon
2014-02-06 18:09 ` Will Deacon
2014-02-06 18:09 ` [PATCH 3/5] iommu/arm-smmu: fix table flushing during initial allocations Will Deacon
2014-02-06 18:09 ` Will Deacon
2014-02-06 18:09 ` [PATCH 4/5] iommu/arm-smmu: set CBARn.BPSHCFG to NSH for s1-s2-bypass contexts Will Deacon
2014-02-06 18:09 ` Will Deacon
2014-02-06 18:09 ` [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA Will Deacon
2014-02-06 18:09 ` Will Deacon
2014-02-13 16:55 ` Timur Tabi
2014-02-13 16:55 ` Timur Tabi
[not found] ` <CAOZdJXW6tY=MjHGMa1EQtJayY=ToqiJOWsggCsEjfPzirUeUxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-13 17:04 ` Will Deacon
2014-02-13 17:04 ` Will Deacon
[not found] ` <20140213170408.GM13576-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-13 17:11 ` Timur Tabi [this message]
2014-02-13 17:11 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCFCDB.5090907@codeaurora.org \
--to=timur-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.