[-mm patch] inotify: fsnotify.h: use kstrdup

[-mm patch] inotify: fsnotify.h: use kstrdup

[Adrian Bunk]

kstrdup was added in 2.6.13-rc1.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-mm2-full/include/linux/fsnotify.h.old	2005-06-30 22:26:07.000000000 +0200
+++ linux-2.6.12-mm2-full/include/linux/fsnotify.h	2005-06-30 22:27:26.000000000 +0200
@@ -216,19 +216,10 @@
 
 /*
  * fsnotify_oldname_init - save off the old filename before we change it
- *
- * XXX: This could be kstrdup if only we could add that to lib/string.c
  */
 static inline const char *fsnotify_oldname_init(const char *name)
 {
-	size_t len;
-	char *buf;
-
-	len = strlen(name) + 1;
-	buf = kmalloc(len, GFP_KERNEL);
-	if (likely(buf))
-		memcpy(buf, name, len);
-	return buf;
+	return kstrdup(name, GFP_KERNEL);
 }
 
 /*

Re: [-mm patch] inotify: fsnotify.h: use kstrdup

[Roland Dreier]

Why not just convert all calls of fsnotify_oldname_init() to kstrdup()
and delete the inline function?  The wrapper isn't adding much beyond
hard-coding GFP_KERNEL.

 - R.

Re: [-mm patch] inotify: fsnotify.h: use kstrdup

[Adrian Bunk]

On Fri, Jul 01, 2005 at 04:20:49PM -0700, Roland Dreier wrote:

> Why not just convert all calls of fsnotify_oldname_init() to kstrdup()
> and delete the inline function?  The wrapper isn't adding much beyond
> hard-coding GFP_KERNEL.

There's a different wrapper for CONFIG_INOTIFY=n.

>  - R.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [-mm patch] inotify: fsnotify.h: use kstrdup

[Robert Love]

On Fri, 2005-07-01 at 16:20 -0700, Roland Dreier wrote:
> Why not just convert all calls of fsnotify_oldname_init() to kstrdup()
> and delete the inline function?  The wrapper isn't adding much beyond
> hard-coding GFP_KERNEL.

Good idea, but the function is different if !CONFIG_INOTIFY.  It exists
to save us some ugly ifdefs in the source.

	Robert Love

Re: [-mm patch] inotify: fsnotify.h: use kstrdup

[Robert Love]

On Sat, 2005-07-02 at 00:55 +0200, Adrian Bunk wrote:

> kstrdup was added in 2.6.13-rc1.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Thanks.  I'll put this in the next release.

Andrew, you can merge this before then, if you want.

Signed-off-by: Robert Love <rml@novell.com>

	Robert Love