From: Paolo Bonzini <pbonzini@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] object: Report type in error when not user creatable.
Date: Wed, 19 Feb 2014 10:10:08 +0100 [thread overview]
Message-ID: <530474F0.5000101@redhat.com> (raw)
In-Reply-To: <1392763356-29026-1-git-send-email-kroosec@gmail.com>
Il 18/02/2014 23:42, Hani Benhabiles ha scritto:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
> }
>
> if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> - error_setg(&local_err, "object '%s' isn't supported by object-add",
> - id);
> + error_setg(&local_err, "object type '%s' isn't supported by object-add",
> + type);
> goto out;
> }
>
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] object: Report type in error when not user creatable.
Date: Wed, 19 Feb 2014 10:10:08 +0100 [thread overview]
Message-ID: <530474F0.5000101@redhat.com> (raw)
In-Reply-To: <1392763356-29026-1-git-send-email-kroosec@gmail.com>
Il 18/02/2014 23:42, Hani Benhabiles ha scritto:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
> }
>
> if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> - error_setg(&local_err, "object '%s' isn't supported by object-add",
> - id);
> + error_setg(&local_err, "object type '%s' isn't supported by object-add",
> + type);
> goto out;
> }
>
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2014-02-19 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:42 [Qemu-trivial] [PATCH] object: Report type in error when not user creatable Hani Benhabiles
2014-02-18 22:42 ` [Qemu-devel] " Hani Benhabiles
2014-02-19 3:46 ` [Qemu-trivial] " Hu Tao
2014-02-19 3:46 ` Hu Tao
2014-02-19 9:10 ` Paolo Bonzini [this message]
2014-02-19 9:10 ` Paolo Bonzini
2014-02-22 12:03 ` [Qemu-trivial] " Michael Tokarev
2014-02-22 12:03 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530474F0.5000101@redhat.com \
--to=pbonzini@redhat.com \
--cc=kroosec@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.