* [Qemu-devel] [PATCH] object: Report type in error when not user creatable.
@ 2014-02-18 22:42 ` Hani Benhabiles
0 siblings, 0 replies; 8+ messages in thread
From: Hani Benhabiles @ 2014-02-18 22:42 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, lcapitulino
Signed-off-by: Hani Benhabiles <hani@linux.com>
---
qmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qmp.c b/qmp.c
index d0d98e7..f556a04 100644
--- a/qmp.c
+++ b/qmp.c
@@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
}
if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
- error_setg(&local_err, "object '%s' isn't supported by object-add",
- id);
+ error_setg(&local_err, "object type '%s' isn't supported by object-add",
+ type);
goto out;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] object: Report type in error when not user creatable.
2014-02-18 22:42 ` [Qemu-devel] " Hani Benhabiles
@ 2014-02-19 3:46 ` Hu Tao
-1 siblings, 0 replies; 8+ messages in thread
From: Hu Tao @ 2014-02-19 3:46 UTC (permalink / raw)
To: Hani Benhabiles; +Cc: qemu-trivial, Igor Mammedov, qemu-devel, lcapitulino
cced: Igor
On Tue, Feb 18, 2014 at 11:42:36PM +0100, Hani Benhabiles wrote:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
> }
>
> if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> - error_setg(&local_err, "object '%s' isn't supported by object-add",
> - id);
> + error_setg(&local_err, "object type '%s' isn't supported by object-add",
> + type);
> goto out;
> }
Same problem here. In the case what we should let user know is the
type of object, instead of id which is just a normal property of object.
Reviewed-by: Hu Tao <hutao@cn.fujitsu.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] object: Report type in error when not user creatable.
@ 2014-02-19 3:46 ` Hu Tao
0 siblings, 0 replies; 8+ messages in thread
From: Hu Tao @ 2014-02-19 3:46 UTC (permalink / raw)
To: Hani Benhabiles; +Cc: qemu-trivial, Igor Mammedov, qemu-devel, lcapitulino
cced: Igor
On Tue, Feb 18, 2014 at 11:42:36PM +0100, Hani Benhabiles wrote:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
> }
>
> if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> - error_setg(&local_err, "object '%s' isn't supported by object-add",
> - id);
> + error_setg(&local_err, "object type '%s' isn't supported by object-add",
> + type);
> goto out;
> }
Same problem here. In the case what we should let user know is the
type of object, instead of id which is just a normal property of object.
Reviewed-by: Hu Tao <hutao@cn.fujitsu.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] object: Report type in error when not user creatable.
2014-02-18 22:42 ` [Qemu-devel] " Hani Benhabiles
@ 2014-02-19 9:10 ` Paolo Bonzini
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-02-19 9:10 UTC (permalink / raw)
To: Hani Benhabiles, qemu-devel; +Cc: qemu-trivial, lcapitulino
Il 18/02/2014 23:42, Hani Benhabiles ha scritto:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
> }
>
> if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> - error_setg(&local_err, "object '%s' isn't supported by object-add",
> - id);
> + error_setg(&local_err, "object type '%s' isn't supported by object-add",
> + type);
> goto out;
> }
>
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] object: Report type in error when not user creatable.
@ 2014-02-19 9:10 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-02-19 9:10 UTC (permalink / raw)
To: Hani Benhabiles, qemu-devel; +Cc: qemu-trivial, lcapitulino
Il 18/02/2014 23:42, Hani Benhabiles ha scritto:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const QDict *qdict,
> }
>
> if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> - error_setg(&local_err, "object '%s' isn't supported by object-add",
> - id);
> + error_setg(&local_err, "object type '%s' isn't supported by object-add",
> + type);
> goto out;
> }
>
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] object: Report type in error when not user creatable.
2014-02-18 22:42 ` [Qemu-devel] " Hani Benhabiles
@ 2014-02-22 12:03 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2014-02-22 12:03 UTC (permalink / raw)
To: Hani Benhabiles; +Cc: qemu-trivial, qemu-devel, lcapitulino
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread