All of lore.kernel.org
 help / color / mirror / Atom feed
From: emilio@elopez.com.ar (Emilio López)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] clk: mvebu: fix clk init order
Date: Wed, 19 Feb 2014 17:24:40 -0300	[thread overview]
Message-ID: <53051308.5040202@elopez.com.ar> (raw)
In-Reply-To: <53032C14.9020502@free-electrons.com>

Hi Gregory,

El 18/02/14 06:47, Gregory CLEMENT escribi?:
(snip)
> (...) what would be an acceptable
> version would be the something like the patch attached. There will be still
> an issue if old dtb is used with recent kernel, but at least the user will
> be warned.

The patch you attached is similar in spirit to what I suggested, but 
with way more warnings sprinkled around. I don't really mind either way, 
and if you prefer big warnings so be it; it's your driver after all :-)

> This code only fix the Armada 370 case, a complete solution should modify
> the dtsi for Armada XP, Armada 375, Armada 38x, Kirkwood and Dove. It should
> also make the outputname mandatory for gate-clk for consistency.

Again, all of them are your calls. Fix the issue as you see fit; as long 
as it's a technically sound I'm ok with it. But please don't reinvent 
the wheel on framework code under a principle that has no proven reason 
to be to cover up for a buggy driver.

Cheers, and have a great Wednesday :)

Emilio

PS: I'd really appreciate it if you could keep me cc'ed on respins of 
patches I comment on in the future.

WARNING: multiple messages have this Message-ID (diff)
From: "Emilio López" <emilio@elopez.com.ar>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Mike Turquette <mturquette@linaro.org>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] clk: mvebu: fix clk init order
Date: Wed, 19 Feb 2014 17:24:40 -0300	[thread overview]
Message-ID: <53051308.5040202@elopez.com.ar> (raw)
In-Reply-To: <53032C14.9020502@free-electrons.com>

Hi Gregory,

El 18/02/14 06:47, Gregory CLEMENT escribió:
(snip)
> (...) what would be an acceptable
> version would be the something like the patch attached. There will be still
> an issue if old dtb is used with recent kernel, but at least the user will
> be warned.

The patch you attached is similar in spirit to what I suggested, but 
with way more warnings sprinkled around. I don't really mind either way, 
and if you prefer big warnings so be it; it's your driver after all :-)

> This code only fix the Armada 370 case, a complete solution should modify
> the dtsi for Armada XP, Armada 375, Armada 38x, Kirkwood and Dove. It should
> also make the outputname mandatory for gate-clk for consistency.

Again, all of them are your calls. Fix the issue as you see fit; as long 
as it's a technically sound I'm ok with it. But please don't reinvent 
the wheel on framework code under a principle that has no proven reason 
to be to cover up for a buggy driver.

Cheers, and have a great Wednesday :)

Emilio

PS: I'd really appreciate it if you could keep me cc'ed on respins of 
patches I comment on in the future.

  parent reply	other threads:[~2014-02-19 20:24 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25 18:19 [PATCH 0/4] clk: mvebu: fix clk init order Sebastian Hesselbarth
2014-01-25 18:19 ` Sebastian Hesselbarth
2014-01-25 18:19 ` [PATCH 1/4] clk: mvebu: armada-370: maintain clock " Sebastian Hesselbarth
2014-01-25 18:19   ` Sebastian Hesselbarth
2014-01-25 18:19 ` [PATCH 2/4] clk: mvebu: armada-xp: " Sebastian Hesselbarth
2014-01-25 18:19   ` Sebastian Hesselbarth
2014-01-25 18:19 ` [PATCH 3/4] clk: mvebu: dove: " Sebastian Hesselbarth
2014-01-25 18:19   ` Sebastian Hesselbarth
2014-01-25 18:19 ` [PATCH 4/4] clk: mvebu: kirkwood: " Sebastian Hesselbarth
2014-01-25 18:19   ` Sebastian Hesselbarth
2014-01-25 21:32 ` [PATCH 0/4] clk: mvebu: fix clk " Emilio López
2014-01-25 21:32   ` Emilio López
2014-01-25 21:44   ` Sebastian Hesselbarth
2014-01-25 21:44     ` Sebastian Hesselbarth
2014-01-25 22:11     ` Emilio López
2014-01-25 22:11       ` Emilio López
2014-01-26  0:25       ` Ezequiel Garcia
2014-01-26  0:25         ` Ezequiel Garcia
2014-01-27 14:39 ` Thomas Petazzoni
2014-01-27 14:39   ` Thomas Petazzoni
2014-01-27 18:21   ` Sebastian Hesselbarth
2014-01-27 18:21     ` Sebastian Hesselbarth
2014-01-27 18:28     ` Jason Cooper
2014-01-27 18:28       ` Jason Cooper
2014-01-30 10:24 ` Gregory CLEMENT
2014-01-30 10:24   ` Gregory CLEMENT
2014-01-30 10:31   ` Sebastian Hesselbarth
2014-01-30 10:31     ` Sebastian Hesselbarth
2014-02-03 23:16     ` Willy Tarreau
2014-02-03 23:16       ` Willy Tarreau
2014-02-03 23:36       ` Sebastian Hesselbarth
2014-02-03 23:36         ` Sebastian Hesselbarth
2014-02-04 14:58         ` Gregory CLEMENT
2014-02-04 14:58           ` Gregory CLEMENT
2014-02-04 20:07           ` Thomas Petazzoni
2014-02-04 20:07             ` Thomas Petazzoni
2014-02-05 14:08 ` Mike Turquette
2014-02-05 14:08   ` Mike Turquette
2014-02-05 17:43   ` Jason Cooper
2014-02-05 17:43     ` Jason Cooper
2014-02-05 18:34 ` Jason Cooper
2014-02-05 18:34   ` Jason Cooper
2014-02-06 17:08   ` Ezequiel Garcia
2014-02-06 17:08     ` Ezequiel Garcia
2014-02-06 18:08     ` Jason Cooper
2014-02-06 18:08       ` Jason Cooper
2014-02-17 14:13   ` Ezequiel Garcia
2014-02-17 14:13     ` Ezequiel Garcia
2014-02-17 14:25     ` Gregory CLEMENT
2014-02-17 14:25       ` Gregory CLEMENT
2014-02-17 14:42       ` Emilio López
2014-02-17 14:42         ` Emilio López
2014-02-17 15:04         ` Gregory CLEMENT
2014-02-17 15:04           ` Gregory CLEMENT
2014-02-17 15:31           ` Emilio López
2014-02-17 15:31             ` Emilio López
2014-02-17 15:21       ` Ezequiel Garcia
2014-02-17 15:21         ` Ezequiel Garcia
2014-02-17 15:28         ` Gregory CLEMENT
2014-02-17 15:28           ` Gregory CLEMENT
2014-02-17 15:44           ` Ezequiel Garcia
2014-02-17 15:44             ` Ezequiel Garcia
2014-02-17 15:59             ` Gregory CLEMENT
2014-02-17 15:59               ` Gregory CLEMENT
2014-02-17 18:19               ` Ezequiel Garcia
2014-02-17 18:19                 ` Ezequiel Garcia
2014-02-18  9:47                 ` Gregory CLEMENT
2014-02-18  9:47                   ` Gregory CLEMENT
2014-02-19 16:28                   ` Ezequiel Garcia
2014-02-19 16:28                     ` Ezequiel Garcia
2014-02-19 20:24                   ` Emilio López [this message]
2014-02-19 20:24                     ` Emilio López

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53051308.5040202@elopez.com.ar \
    --to=emilio@elopez.com.ar \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.