From: Daniel Borkmann <dborkman@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>,
mingo@elte.hu, tglx@linutronix.de, davem@davemloft.net,
ffusco@redhat.com, tgraf@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/hash: swap parameters of crc32_u32()
Date: Tue, 25 Feb 2014 21:34:02 +0100 [thread overview]
Message-ID: <530CFE3A.2090403@redhat.com> (raw)
In-Reply-To: <530CFC93.8080505@zytor.com>
On 02/25/2014 09:26 PM, H. Peter Anvin wrote:
> On 02/21/2014 02:33 AM, Jan Beulich wrote:
>> ... to match its two callers (i.e. the alternative would have been to
>> swap the arguments at the call sites).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Cc: Francesco Fusco <ffusco@redhat.com>
>> Cc: Daniel Borkmann <dborkman@redhat.com>
>> Cc: Thomas Graf <tgraf@redhat.com>
>> Cc: David S. Miller <davem@davemloft.net>
>> ---
>> arch/x86/lib/hash.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Jan, do you want to do an updated version of this patch? Daniel, I
> presume you are going to push this patch?
Good point. I'm fine if this is going to be picked up
by x86 maintainers. Feel free to add my ...
Acked-by: Daniel Borkmann <dborkman@redhat.com>
... if you want to do an updated version that also
includes our recent findings/discussion, Jan.
Thanks!
next prev parent reply other threads:[~2014-02-25 20:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 10:33 [PATCH 2/3] x86/hash: swap parameters of crc32_u32() Jan Beulich
2014-02-22 12:09 ` Daniel Borkmann
2014-02-24 8:03 ` Jan Beulich
2014-02-24 10:22 ` Daniel Borkmann
2014-02-24 10:53 ` Jan Beulich
2014-02-24 11:46 ` Daniel Borkmann
2014-02-24 12:16 ` Jan Beulich
2014-02-24 12:32 ` H. Peter Anvin
2014-02-24 12:41 ` Jan Beulich
2014-02-24 12:51 ` H. Peter Anvin
2014-02-24 13:01 ` H. Peter Anvin
2014-02-24 13:07 ` Jan Beulich
2014-02-24 13:09 ` Daniel Borkmann
2014-02-24 13:16 ` H. Peter Anvin
2014-02-24 12:35 ` H. Peter Anvin
2014-02-25 20:26 ` H. Peter Anvin
2014-02-25 20:34 ` Daniel Borkmann [this message]
2014-02-25 20:37 ` H. Peter Anvin
2014-02-26 9:29 ` Jan Beulich
2014-02-26 16:06 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530CFE3A.2090403@redhat.com \
--to=dborkman@redhat.com \
--cc=JBeulich@suse.com \
--cc=davem@davemloft.net \
--cc=ffusco@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tgraf@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.