From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: davem@davemloft.net, Ingo Molnar <mingo@kernel.org>,
tglx@linutronix.de, Daniel Borkmann <dborkman@redhat.com>,
ffusco@redhat.com, tgraf@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/hash: swap parameters of crc32_u32()
Date: Wed, 26 Feb 2014 08:06:50 -0800 [thread overview]
Message-ID: <530E111A.7050100@zytor.com> (raw)
In-Reply-To: <530DC21F020000780011F67D@nat28.tlf.novell.com>
On 02/26/2014 01:29 AM, Jan Beulich wrote:
>
> or it would be (with parameter order kept and argument order
> swapped)
>
> static inline u32 crc32_u32(u32 crc, u32 val)
> seed = crc32_u32(seed, *p32++);
> seed = crc32_u32(seed, tmp);
> seed = crc32_u32(seed, *p32++);
>
> I.e. it is precisely the case that their names and functions disagree
> in the current (unpatched) version.
>
I guess I think this version seems more logical especially/when this
inline is moved into a global place somewhere.
It's not a big deal, though.
-hpa
prev parent reply other threads:[~2014-02-26 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 10:33 [PATCH 2/3] x86/hash: swap parameters of crc32_u32() Jan Beulich
2014-02-22 12:09 ` Daniel Borkmann
2014-02-24 8:03 ` Jan Beulich
2014-02-24 10:22 ` Daniel Borkmann
2014-02-24 10:53 ` Jan Beulich
2014-02-24 11:46 ` Daniel Borkmann
2014-02-24 12:16 ` Jan Beulich
2014-02-24 12:32 ` H. Peter Anvin
2014-02-24 12:41 ` Jan Beulich
2014-02-24 12:51 ` H. Peter Anvin
2014-02-24 13:01 ` H. Peter Anvin
2014-02-24 13:07 ` Jan Beulich
2014-02-24 13:09 ` Daniel Borkmann
2014-02-24 13:16 ` H. Peter Anvin
2014-02-24 12:35 ` H. Peter Anvin
2014-02-25 20:26 ` H. Peter Anvin
2014-02-25 20:34 ` Daniel Borkmann
2014-02-25 20:37 ` H. Peter Anvin
2014-02-26 9:29 ` Jan Beulich
2014-02-26 16:06 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E111A.7050100@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=ffusco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tgraf@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.