* [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
@ 2014-02-26 18:40 Yann E. MORIN
2014-02-26 20:51 ` Peter Korsgaard
2014-02-26 21:33 ` Arnout Vandecappelle
0 siblings, 2 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-02-26 18:40 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
ti-gfx uses custom extract commands, which first and foremost removes
the source dir unconditionally.
Thee side-effect of this is that make will re-extract, re-patch and
probably re-build ti-gfx at each run.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Spenser Gilliland <spenser@gillilanding.com>
---
package/ti-gfx/ti-gfx.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/ti-gfx/ti-gfx.mk b/package/ti-gfx/ti-gfx.mk
index 5ea6b92..e48715d 100644
--- a/package/ti-gfx/ti-gfx.mk
+++ b/package/ti-gfx/ti-gfx.mk
@@ -90,7 +90,6 @@ TI_GFX_HDR_DIRS = OGLES2/EGL OGLES2/EWS OGLES2/GLES2 OGLES2/KHR \
OGLES/GLES bufferclass_ti/ pvr2d/ wsegl/
define TI_GFX_EXTRACT_CMDS
- $(RM) -rf $(TI_GFX_DIR)
chmod +x $(DL_DIR)/$(TI_GFX_SOURCE)
printf "Y\nY\n qY\n\n" | $(DL_DIR)/$(TI_GFX_SOURCE) \
--prefix $(@D) \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
2014-02-26 18:40 [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract Yann E. MORIN
@ 2014-02-26 20:51 ` Peter Korsgaard
2014-02-26 21:33 ` Arnout Vandecappelle
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2014-02-26 20:51 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ti-gfx uses custom extract commands, which first and foremost removes
> the source dir unconditionally.
> Thee side-effect of this is that make will re-extract, re-patch and
> probably re-build ti-gfx at each run.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Spenser Gilliland <spenser@gillilanding.com>
Committed to next, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
2014-02-26 18:40 [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract Yann E. MORIN
2014-02-26 20:51 ` Peter Korsgaard
@ 2014-02-26 21:33 ` Arnout Vandecappelle
2014-02-26 21:43 ` Peter Korsgaard
2014-02-26 21:48 ` Yann E. MORIN
1 sibling, 2 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2014-02-26 21:33 UTC (permalink / raw)
To: buildroot
On 26/02/14 19:40, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> ti-gfx uses custom extract commands, which first and foremost removes
> the source dir unconditionally.
>
> Thee side-effect of this is that make will re-extract, re-patch and
> probably re-build ti-gfx at each run.
There actually was a reason for this - I think the extract fails if you
re-run it. Have you tried
make ti-gfx-extract; make ti-gfx-extract
?
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Spenser Gilliland <spenser@gillilanding.com>
> ---
> package/ti-gfx/ti-gfx.mk | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/ti-gfx/ti-gfx.mk b/package/ti-gfx/ti-gfx.mk
> index 5ea6b92..e48715d 100644
> --- a/package/ti-gfx/ti-gfx.mk
> +++ b/package/ti-gfx/ti-gfx.mk
> @@ -90,7 +90,6 @@ TI_GFX_HDR_DIRS = OGLES2/EGL OGLES2/EWS OGLES2/GLES2 OGLES2/KHR \
> OGLES/GLES bufferclass_ti/ pvr2d/ wsegl/
>
> define TI_GFX_EXTRACT_CMDS
> - $(RM) -rf $(TI_GFX_DIR)
> chmod +x $(DL_DIR)/$(TI_GFX_SOURCE)
> printf "Y\nY\n qY\n\n" | $(DL_DIR)/$(TI_GFX_SOURCE) \
> --prefix $(@D) \
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
2014-02-26 21:33 ` Arnout Vandecappelle
@ 2014-02-26 21:43 ` Peter Korsgaard
2014-02-26 21:50 ` Arnout Vandecappelle
2014-02-26 21:48 ` Yann E. MORIN
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2014-02-26 21:43 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 26/02/14 19:40, Yann E. MORIN wrote:
>> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>
>> ti-gfx uses custom extract commands, which first and foremost removes
>> the source dir unconditionally.
>>
>> Thee side-effect of this is that make will re-extract, re-patch and
>> probably re-build ti-gfx at each run.
> There actually was a reason for this - I think the extract fails if you
> re-run it. Have you tried
> make ti-gfx-extract; make ti-gfx-extract
That afaik simply says nothing to do, like it should.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
2014-02-26 21:33 ` Arnout Vandecappelle
2014-02-26 21:43 ` Peter Korsgaard
@ 2014-02-26 21:48 ` Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-02-26 21:48 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2014-02-26 22:33 +0100, Arnout Vandecappelle spake thusly:
> On 26/02/14 19:40, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > ti-gfx uses custom extract commands, which first and foremost removes
> > the source dir unconditionally.
> >
> > Thee side-effect of this is that make will re-extract, re-patch and
> > probably re-build ti-gfx at each run.
>
> There actually was a reason for this - I think the extract fails if you
> re-run it. Have you tried
>
> make ti-gfx-extract; make ti-gfx-extract
I shall try that right away... Nope, works!
I eventually understood what was going on. Basically, when you run:
make ti-gfx-extract
under the hood, it's as you did:
make ti-gfx-source
make ti-gfx-extract
But -source creates a stamp file. Then -extract would remove the
directory, thus removing the stamp file.
10 When you run make again, the stamp file for the download is missing, so
make tries to download it again (invisible, since we already have the
archive), creates the stamp file, and extract again, which removes the
stamp file.
20 GOTO 10.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract
2014-02-26 21:43 ` Peter Korsgaard
@ 2014-02-26 21:50 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2014-02-26 21:50 UTC (permalink / raw)
To: buildroot
On 26/02/14 22:43, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>
> > On 26/02/14 19:40, Yann E. MORIN wrote:
> >> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >>
> >> ti-gfx uses custom extract commands, which first and foremost removes
> >> the source dir unconditionally.
> >>
> >> Thee side-effect of this is that make will re-extract, re-patch and
> >> probably re-build ti-gfx at each run.
>
> > There actually was a reason for this - I think the extract fails if you
> > re-run it. Have you tried
>
> > make ti-gfx-extract; make ti-gfx-extract
>
> That afaik simply says nothing to do, like it should.
I mean if the stamp file is removed.
But I realize now that this is something that doesn't necessarily work
anyway, so please ignore my comment.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-26 21:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-26 18:40 [Buildroot] [PATCH] package/ti-gfx: do not forcefully remove source dir on extract Yann E. MORIN
2014-02-26 20:51 ` Peter Korsgaard
2014-02-26 21:33 ` Arnout Vandecappelle
2014-02-26 21:43 ` Peter Korsgaard
2014-02-26 21:50 ` Arnout Vandecappelle
2014-02-26 21:48 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.