Re: [PATCH v2 5/5] [RFC] Traditional console timestamps including milliseconds

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 01/03/14 04:06, Julien Grall wrote:
> Hello Andrew,
>
> On 01/03/14 02:57, Andrew Cooper wrote:
>> diff --git a/xen/include/asm-x86/time.h b/xen/include/asm-x86/time.h
>> index 147b39e..2f9dbd1 100644
>> --- a/xen/include/asm-x86/time.h
>> +++ b/xen/include/asm-x86/time.h
>> @@ -49,7 +49,7 @@ int dom0_pit_access(struct ioreq *ioreq);
>>   int cpu_frequency_change(u64 freq);
>>
>>   struct tm;
>> -struct tm wallclock_time(void);
>> +struct tm wallclock_time(uint64_t *ns);
>>
>
>
> You also need to modify the prototype in asm-arm/time.h. Otherwise it
> will break compilation on ARM.
>
> BTW, as the function is used by common code, can you merge the both
> prototype in xen/time.h?
>
> Regards,
>

Hmm yes - I had overlooked that it was a common function declared in an
x86 header.  It certainly should be moved, irrespective of whether this
change actually happens (subject to the RFCs in patch 0)

~Andrew