From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3] x86/time: Always count s_time from Xen boot
Date: Thu, 6 Mar 2014 16:18:42 +0000 [thread overview]
Message-ID: <53189FE2.6050309@citrix.com> (raw)
In-Reply-To: <5318AD3702000078001219A4@nat28.tlf.novell.com>
On 06/03/14 16:15, Jan Beulich wrote:
>>>> On 06.03.14 at 17:01, Tim Deegan <tim@xen.org> wrote:
>> @@ -203,6 +209,10 @@ GLOBAL(trampoline_end)
>> __high_start:
>> #include "x86_64.S"
>>
>> + .section .init.data, "a", @progbits
>> +GLOBAL(boot_tsc_stamp)
>> + .quad 0
> I think it would be better to have that definition in the C file, ...
>
>> --- a/xen/arch/x86/time.c
>> +++ b/xen/arch/x86/time.c
>> @@ -84,6 +84,9 @@ static u16 pit_stamp16;
>> static u32 pit_stamp32;
>> static bool_t __read_mostly using_pit;
>>
>> +/* Boot timestamp, filled in head.S (initdata) */
>> +extern u64 boot_tsc_stamp;
> ... instead of only declaring it here.
>
> Jan
>
Ok - I will see about cleaning this up (as it was my part of the patch)
and respin the full series.
next prev parent reply other threads:[~2014-03-06 16:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 18:56 [RFC PATCH v2 0/5] Improvements to console timestamps Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 1/5] x86/time: Avoid redundant this_cpu() Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 2/5] x86/time: Always count s_time from Xen boot Andrew Cooper
2014-03-03 10:59 ` David Vrabel
2014-03-06 16:01 ` [PATCH v3] " Tim Deegan
2014-03-06 16:15 ` Jan Beulich
2014-03-06 16:18 ` Andrew Cooper [this message]
2014-02-28 18:57 ` [PATCH v2 3/5] x86/time: Initialise time earlier during start_secondary() Andrew Cooper
2014-03-04 9:02 ` Jan Beulich
2014-03-04 10:40 ` Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 4/5] [RFC] xen/console: Provide timestamps as an offset since boot Andrew Cooper
2014-03-03 10:53 ` David Vrabel
2014-02-28 18:57 ` [PATCH v2 5/5] [RFC] Traditional console timestamps including milliseconds Andrew Cooper
2014-03-01 4:06 ` Julien Grall
2014-03-03 10:35 ` Andrew Cooper
2014-03-04 9:14 ` Jan Beulich
2014-03-04 10:30 ` Andrew Cooper
2014-03-04 20:51 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53189FE2.6050309@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.