Re: [PATCH v2 4/5] [RFC] xen/console: Provide timestamps as an offset since boot

[David Vrabel <david.vrabel@citrix.com>]

On 28/02/14 18:57, Andrew Cooper wrote:
> This adds a new "Linux style" console timestamp method, which is shorter and
> more useful than the current date/time timestamps with single-second
> granularity.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
>  xen/drivers/char/console.c |   58 +++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 49 insertions(+), 9 deletions(-)
> 
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 532c426..652d02d 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -49,8 +49,17 @@ static bool_t __read_mostly opt_console_to_ring;
>  boolean_param("console_to_ring", opt_console_to_ring);
>  
>  /* console_timestamps: include a timestamp prefix on every Xen console line. */
> -static bool_t __read_mostly opt_console_timestamps;
> -boolean_param("console_timestamps", opt_console_timestamps);
> +enum con_timestamp_mode
> +{
> +    TSM_NONE,          /* No timestamps */
> +    TSM_DATE,          /* [YYYY-MM-DD HH:MM:SS] */
> +    TSM_SINCE_BOOT     /* [SSSSSS.mmmmmm] */
> +};

A higher precision timestamp is useful, but do we really need different
options for this?  Can we not agree on one format?

David