From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2] ath10k: support msdu chaining.
Date: Mon, 03 Mar 2014 14:08:20 -0800 [thread overview]
Message-ID: <5314FD54.7070202@candelatech.com> (raw)
In-Reply-To: <CA+BoTQnCjkgr3V4bzXW8GHJDmGRHqg6x8An__vFW5bxdub=uyw@mail.gmail.com>
On 02/27/2014 11:51 PM, Michal Kazior wrote:
> On 28 February 2014 02:20, <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Consolidate the list of msdu skbs into the msdu-head skb, delete the
>> rest of the skbs, pass the msdu-head skb on up the stack as normal.
>>
>> Tested with high-speed TCP and UDP traffic on modified firmware that
>> supports raw-rx.
>
> As for an umodified firmware I expect ath10k will just re-assemble
> corrupted frames just to have them dropped by mac80211. It might be
> worth checking:
>
> if (chaining && fcs_error)
> drop();
As far as I can tell, packets with bad FCS are dropped earlier in that
rx method?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k: support msdu chaining.
Date: Mon, 03 Mar 2014 14:08:20 -0800 [thread overview]
Message-ID: <5314FD54.7070202@candelatech.com> (raw)
In-Reply-To: <CA+BoTQnCjkgr3V4bzXW8GHJDmGRHqg6x8An__vFW5bxdub=uyw@mail.gmail.com>
On 02/27/2014 11:51 PM, Michal Kazior wrote:
> On 28 February 2014 02:20, <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Consolidate the list of msdu skbs into the msdu-head skb, delete the
>> rest of the skbs, pass the msdu-head skb on up the stack as normal.
>>
>> Tested with high-speed TCP and UDP traffic on modified firmware that
>> supports raw-rx.
>
> As for an umodified firmware I expect ath10k will just re-assemble
> corrupted frames just to have them dropped by mac80211. It might be
> worth checking:
>
> if (chaining && fcs_error)
> drop();
As far as I can tell, packets with bad FCS are dropped earlier in that
rx method?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-03-03 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 1:20 [PATCH v2] ath10k: support msdu chaining greearb
2014-02-28 1:20 ` greearb
2014-02-28 7:38 ` Kalle Valo
2014-02-28 7:38 ` Kalle Valo
2014-02-28 7:51 ` Michal Kazior
2014-02-28 7:51 ` Michal Kazior
2014-03-03 22:08 ` Ben Greear [this message]
2014-03-03 22:08 ` Ben Greear
2014-03-04 7:14 ` Michal Kazior
2014-03-04 7:14 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314FD54.7070202@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.