All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k:  support msdu chaining.
Date: Fri, 28 Feb 2014 09:38:41 +0200	[thread overview]
Message-ID: <87fvn3d6v2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1393550452-1302-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Thu, 27 Feb 2014 17:20:52 -0800")

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Consolidate the list of msdu skbs into the msdu-head skb, delete the
> rest of the skbs, pass the msdu-head skb on up the stack as normal.
>
> Tested with high-speed TCP and UDP traffic on modified firmware that
> supports raw-rx.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2:  Add note about skb_try_coalesce, though I am not sure it will
>      work or not.
>      Only grow skb once, which should save on some memory (re)allocation
>      and copying when we have more than one chained skb.

I didn't look at the patch itself yet, but I see checkpatch warnings:

drivers/net/wireless/ath/ath10k/htt_rx.c:1022: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/htt_rx.c:1032: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/htt_rx.c:1044: WARNING: labels should not be indented
drivers/net/wireless/ath/ath10k/htt_rx.c:1053: WARNING: labels should not be indented

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k:  support msdu chaining.
Date: Fri, 28 Feb 2014 09:38:41 +0200	[thread overview]
Message-ID: <87fvn3d6v2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1393550452-1302-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Thu, 27 Feb 2014 17:20:52 -0800")

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Consolidate the list of msdu skbs into the msdu-head skb, delete the
> rest of the skbs, pass the msdu-head skb on up the stack as normal.
>
> Tested with high-speed TCP and UDP traffic on modified firmware that
> supports raw-rx.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2:  Add note about skb_try_coalesce, though I am not sure it will
>      work or not.
>      Only grow skb once, which should save on some memory (re)allocation
>      and copying when we have more than one chained skb.

I didn't look at the patch itself yet, but I see checkpatch warnings:

drivers/net/wireless/ath/ath10k/htt_rx.c:1022: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/htt_rx.c:1032: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/htt_rx.c:1044: WARNING: labels should not be indented
drivers/net/wireless/ath/ath10k/htt_rx.c:1053: WARNING: labels should not be indented

-- 
Kalle Valo

  reply	other threads:[~2014-02-28  7:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  1:20 [PATCH v2] ath10k: support msdu chaining greearb
2014-02-28  1:20 ` greearb
2014-02-28  7:38 ` Kalle Valo [this message]
2014-02-28  7:38   ` Kalle Valo
2014-02-28  7:51 ` Michal Kazior
2014-02-28  7:51   ` Michal Kazior
2014-03-03 22:08   ` Ben Greear
2014-03-03 22:08     ` Ben Greear
2014-03-04  7:14     ` Michal Kazior
2014-03-04  7:14       ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvn3d6v2.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.