From: Josh Wu <josh.wu@atmel.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Herve Codina <Herve.CODINA@celad.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Disable Subpage nand write when using Atmel PMECC
Date: Tue, 11 Mar 2014 11:07:57 +0800 [thread overview]
Message-ID: <531E7E0D.6080605@atmel.com> (raw)
In-Reply-To: <20140307080251.GI31517@norris-Latitude-E6410>
Hi, Brian
On 3/7/2014 4:02 PM, Brian Norris wrote:
> On Fri, Mar 07, 2014 at 11:59:46AM +0800, Josh Wu wrote:
>> On 3/3/2014 7:15 PM, Herve Codina wrote:
>>> Crash detected on sam5d35 and its pmecc nand ecc controller.
>>>
>>> The problem was a call to chip->ecc.hwctl from nand_write_subpage_hwecc
>>> (nand_base.c) when we write a sub page.
>>> chip->ecc.hwctl function is not set when we are using PMECC controller.
>>> As a workaround, set NAND_NO_SUBPAGE_WRITE for PMECC controller in
>>> order to disable sub page access in nand_write_page.
>>>
>>>
>>> Signed-off-by: Herve Codina <Herve.CODINA@celad.com>
>> Acked-by: Josh Wu <josh.wu@atmel.com>
> Pushed to l2-mtd.git. Thanks!
Sorry for the later thought. But I think this patch should go to the
stable Linux branch
since any subpage write will cause crash in SAMA5D3 and AT91SAM9X5.
So is it possible to add a tag: "Cc: stable@vger.kernel.org" for this
commit?
Best Regards,
Josh Wu
>
> Brian
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Disable Subpage nand write when using Atmel PMECC
Date: Tue, 11 Mar 2014 11:07:57 +0800 [thread overview]
Message-ID: <531E7E0D.6080605@atmel.com> (raw)
In-Reply-To: <20140307080251.GI31517@norris-Latitude-E6410>
Hi, Brian
On 3/7/2014 4:02 PM, Brian Norris wrote:
> On Fri, Mar 07, 2014 at 11:59:46AM +0800, Josh Wu wrote:
>> On 3/3/2014 7:15 PM, Herve Codina wrote:
>>> Crash detected on sam5d35 and its pmecc nand ecc controller.
>>>
>>> The problem was a call to chip->ecc.hwctl from nand_write_subpage_hwecc
>>> (nand_base.c) when we write a sub page.
>>> chip->ecc.hwctl function is not set when we are using PMECC controller.
>>> As a workaround, set NAND_NO_SUBPAGE_WRITE for PMECC controller in
>>> order to disable sub page access in nand_write_page.
>>>
>>>
>>> Signed-off-by: Herve Codina <Herve.CODINA@celad.com>
>> Acked-by: Josh Wu <josh.wu@atmel.com>
> Pushed to l2-mtd.git. Thanks!
Sorry for the later thought. But I think this patch should go to the
stable Linux branch
since any subpage write will cause crash in SAMA5D3 and AT91SAM9X5.
So is it possible to add a tag: "Cc: stable at vger.kernel.org" for this
commit?
Best Regards,
Josh Wu
>
> Brian
next prev parent reply other threads:[~2014-03-11 3:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 11:15 [PATCH] Disable Subpage nand write when using Atmel PMECC Herve Codina
2014-03-03 11:15 ` Herve Codina
2014-03-07 3:59 ` Josh Wu
2014-03-07 3:59 ` Josh Wu
2014-03-07 8:02 ` Brian Norris
2014-03-07 8:02 ` Brian Norris
2014-03-11 3:07 ` Josh Wu [this message]
2014-03-11 3:07 ` Josh Wu
2014-03-11 5:36 ` Brian Norris
2014-03-11 5:36 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531E7E0D.6080605@atmel.com \
--to=josh.wu@atmel.com \
--cc=Herve.CODINA@celad.com \
--cc=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.