* Re: [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header
@ 2014-03-17 11:33 Ben Hutchings
2014-03-17 12:12 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ben Hutchings @ 2014-03-17 11:33 UTC (permalink / raw)
To: linux-sh
On Mon, 2014-03-17 at 11:15 +0000, Ben Dooks wrote:
> Add definition of sh_pm_runtime_init() to machine header to allow calling
declaration not definition
> the pm_runtime initialisation code.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/mach-shmobile/include/mach/common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> index cb8e32d..4727d4f 100644
> --- a/arch/arm/mach-shmobile/include/mach/common.h
> +++ b/arch/arm/mach-shmobile/include/mach/common.h
> @@ -52,4 +52,6 @@ static inline void __init shmobile_init_late(void)
> shmobile_cpuidle_init();
> }
>
> +extern int sh_pm_runtime_init(void);
> +
> #endif /* __ARCH_MACH_COMMON_H */
The declaration should include '__init' and need not include 'extern'.
I would fold this into the previous patch.
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header
2014-03-17 11:33 [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header Ben Hutchings
@ 2014-03-17 12:12 ` Sergei Shtylyov
2014-03-17 14:28 ` Ben Hutchings
2014-03-17 17:15 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-03-17 12:12 UTC (permalink / raw)
To: linux-sh
Hello.
On 17-03-2014 15:33, Ben Hutchings wrote:
>> Add definition of sh_pm_runtime_init() to machine header to allow calling
> declaration not definition
>> the pm_runtime initialisation code.
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> arch/arm/mach-shmobile/include/mach/common.h | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
>> index cb8e32d..4727d4f 100644
>> --- a/arch/arm/mach-shmobile/include/mach/common.h
>> +++ b/arch/arm/mach-shmobile/include/mach/common.h
>> @@ -52,4 +52,6 @@ static inline void __init shmobile_init_late(void)
>> shmobile_cpuidle_init();
>> }
>>
>> +extern int sh_pm_runtime_init(void);
>> +
>> #endif /* __ARCH_MACH_COMMON_H */
> The declaration should include '__init'
Since when? It makes no sense for declarations.
> and need not include 'extern'.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header
2014-03-17 11:33 [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header Ben Hutchings
2014-03-17 12:12 ` Sergei Shtylyov
@ 2014-03-17 14:28 ` Ben Hutchings
2014-03-17 17:15 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2014-03-17 14:28 UTC (permalink / raw)
To: linux-sh
On Mon, 2014-03-17 at 16:12 +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 17-03-2014 15:33, Ben Hutchings wrote:
>
> >> Add definition of sh_pm_runtime_init() to machine header to allow calling
>
> > declaration not definition
>
> >> the pm_runtime initialisation code.
>
> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> >> ---
> >> arch/arm/mach-shmobile/include/mach/common.h | 2 ++
> >> 1 file changed, 2 insertions(+)
>
> >> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> >> index cb8e32d..4727d4f 100644
> >> --- a/arch/arm/mach-shmobile/include/mach/common.h
> >> +++ b/arch/arm/mach-shmobile/include/mach/common.h
> >> @@ -52,4 +52,6 @@ static inline void __init shmobile_init_late(void)
> >> shmobile_cpuidle_init();
> >> }
> >>
> >> +extern int sh_pm_runtime_init(void);
> >> +
> >> #endif /* __ARCH_MACH_COMMON_H */
>
> > The declaration should include '__init'
>
> Since when? It makes no sense for declarations.
It doesn't make any difference to the compiler, but it can be useful for
the programmer to see it.
Ben.
> > and need not include 'extern'.
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header
2014-03-17 11:33 [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header Ben Hutchings
2014-03-17 12:12 ` Sergei Shtylyov
2014-03-17 14:28 ` Ben Hutchings
@ 2014-03-17 17:15 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-03-17 17:15 UTC (permalink / raw)
To: linux-sh
Hello.
On 03/17/2014 05:28 PM, Ben Hutchings wrote:
>>>> Add definition of sh_pm_runtime_init() to machine header to allow calling
>>> declaration not definition
>>>> the pm_runtime initialisation code.
>>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>>> ---
>>>> arch/arm/mach-shmobile/include/mach/common.h | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
>>>> index cb8e32d..4727d4f 100644
>>>> --- a/arch/arm/mach-shmobile/include/mach/common.h
>>>> +++ b/arch/arm/mach-shmobile/include/mach/common.h
>>>> @@ -52,4 +52,6 @@ static inline void __init shmobile_init_late(void)
>>>> shmobile_cpuidle_init();
>>>> }
>>>>
>>>> +extern int sh_pm_runtime_init(void);
>>>> +
>>>> #endif /* __ARCH_MACH_COMMON_H */
>>> The declaration should include '__init'
>> Since when? It makes no sense for declarations.
> It doesn't make any difference to the compiler, but it can be useful for
> the programmer to see it.
I personally use 'make TAGS' on the kernel directory, and EMACS then shows
me the function definition, not declaration when I press <Alt>-<.> (I wish it
always worked correctly though). In general, people tend to remove '__init'
from the declarations as I could observe so far...
> Ben.
>>> and need not include 'extern'.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-17 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-17 11:33 [Linux-kernel] [RFC 3/6] ARM: shmobile: add sh_pm_runtime_init() to header Ben Hutchings
2014-03-17 12:12 ` Sergei Shtylyov
2014-03-17 14:28 ` Ben Hutchings
2014-03-17 17:15 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.