From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] scripts: add sample model file for Coverity Scan
Date: Wed, 19 Mar 2014 08:03:49 +0100 [thread overview]
Message-ID: <53294155.8040403@redhat.com> (raw)
In-Reply-To: <874n2vcpu9.fsf@blackfin.pond.sub.org>
Il 18/03/2014 19:40, Markus Armbruster ha scritto:
> > +void *
> > +g_malloc (size_t n_bytes)
> > +{
> > + void *mem;
> > + __coverity_negative_sink__((ssize_t) n_bytes);
> > + mem = malloc(n_bytes == 0 ? 1 : n_bytes);
> > + if (!mem) __coverity_panic__ ();
> > + return mem;
> > +}
>
> This isn't quite honest: g_malloc(0) yields NULL. Same for the other
> allocation functions.
Oh, I didn't know that.
It probably would make static analysis a bit less powerful or will
return more false positives. The NULL return for realloc (in the "free"
case) already causes some. So I'm undecided between a more correct
model and a more selective one (with a fat comment).
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scripts: add sample model file for Coverity Scan
Date: Wed, 19 Mar 2014 08:03:49 +0100 [thread overview]
Message-ID: <53294155.8040403@redhat.com> (raw)
In-Reply-To: <874n2vcpu9.fsf@blackfin.pond.sub.org>
Il 18/03/2014 19:40, Markus Armbruster ha scritto:
> > +void *
> > +g_malloc (size_t n_bytes)
> > +{
> > + void *mem;
> > + __coverity_negative_sink__((ssize_t) n_bytes);
> > + mem = malloc(n_bytes == 0 ? 1 : n_bytes);
> > + if (!mem) __coverity_panic__ ();
> > + return mem;
> > +}
>
> This isn't quite honest: g_malloc(0) yields NULL. Same for the other
> allocation functions.
Oh, I didn't know that.
It probably would make static analysis a bit less powerful or will
return more false positives. The NULL return for realloc (in the "free"
case) already causes some. So I'm undecided between a more correct
model and a more selective one (with a fat comment).
Paolo
next prev parent reply other threads:[~2014-03-19 7:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:03 [Qemu-trivial] [PATCH] scripts: add sample model file for Coverity Scan Paolo Bonzini
2014-03-18 17:03 ` [Qemu-devel] " Paolo Bonzini
2014-03-18 18:40 ` [Qemu-trivial] " Markus Armbruster
2014-03-18 18:40 ` Markus Armbruster
2014-03-19 7:03 ` Paolo Bonzini [this message]
2014-03-19 7:03 ` Paolo Bonzini
2014-03-19 9:08 ` [Qemu-trivial] " Markus Armbruster
2014-03-19 9:08 ` Markus Armbruster
2014-03-19 12:46 ` [Qemu-trivial] " Paolo Bonzini
2014-03-19 12:46 ` [Qemu-devel] " Paolo Bonzini
2014-03-19 13:56 ` [Qemu-trivial] " Paolo Bonzini
2014-03-19 13:56 ` [Qemu-devel] " Paolo Bonzini
2014-03-19 14:57 ` [Qemu-trivial] " Paolo Bonzini
2014-03-19 14:57 ` [Qemu-devel] " Paolo Bonzini
2014-03-19 15:56 ` [Qemu-trivial] " Markus Armbruster
2014-03-19 15:56 ` Markus Armbruster
2014-03-19 16:47 ` [Qemu-trivial] " Paolo Bonzini
2014-03-19 16:47 ` Paolo Bonzini
2014-03-19 9:36 ` [Qemu-trivial] " Kevin Wolf
2014-03-19 9:36 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53294155.8040403@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.