From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] micrel: fix masking off LED bits
Date: Wed, 19 Mar 2014 08:12:33 +0000 [thread overview]
Message-ID: <53295171.3020700@codethink.co.uk> (raw)
In-Reply-To: <201403190258.16812.sergei.shtylyov@cogentembedded.com>
On 19/03/14 00:58, Sergei Shtylyov wrote:
> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the
> obvious mistake when masking off the LED mode bits: forgot to do a logical NOT
> to the mask with which it ANDs the register value, so that unrelated bits are
> cleared instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Ben Dooks <ben.dooks@codethink.co.uk>
Oops, thanks for noticing that.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] micrel: fix masking off LED bits
Date: Wed, 19 Mar 2014 09:12:33 +0100 [thread overview]
Message-ID: <53295171.3020700@codethink.co.uk> (raw)
In-Reply-To: <201403190258.16812.sergei.shtylyov@cogentembedded.com>
On 19/03/14 00:58, Sergei Shtylyov wrote:
> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the
> obvious mistake when masking off the LED mode bits: forgot to do a logical NOT
> to the mask with which it ANDs the register value, so that unrelated bits are
> cleared instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Ben Dooks <ben.dooks@codethink.co.uk>
Oops, thanks for noticing that.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-03-19 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 22:58 [PATCH] micrel: fix masking off LED bits Sergei Shtylyov
2014-03-18 23:58 ` Sergei Shtylyov
2014-03-18 23:27 ` Laurent Pinchart
2014-03-18 23:27 ` Laurent Pinchart
2014-03-19 8:12 ` Ben Dooks [this message]
2014-03-19 8:12 ` Ben Dooks
2014-03-19 16:21 ` Florian Fainelli
2014-03-19 16:21 ` Florian Fainelli
2014-03-19 18:35 ` Sergei Shtylyov
2014-03-19 19:35 ` Sergei Shtylyov
2014-03-19 21:42 ` David Miller
2014-03-19 21:42 ` David Miller
2014-03-20 17:44 ` Sergei Shtylyov
2014-03-20 18:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53295171.3020700@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.